Skip to content

feat(scanner): reject plugin cabal upload and mvn deploy - #1186

Draft
seonghobae wants to merge 5 commits into
feat/claude-plugin-hex-conda-1099from
feat/claude-plugin-cabal-mvn-1099
Draft

feat(scanner): reject plugin cabal upload and mvn deploy#1186
seonghobae wants to merge 5 commits into
feat/claude-plugin-hex-conda-1099from
feat/claude-plugin-cabal-mvn-1099

Conversation

@seonghobae

@seonghobae seonghobae commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Successor of #1185 / issue #1099. Does not Close those. hex/conda stay #1185. dart/flutter pub stay #1184. gem/nuget stay #1183. Pass is not Noema admission.

Unique delta

Fail closed when a plugin hook or manifest runs remaining Hackage and Maven writes that #1185 left as inventory:

  • cabal upload and cabal v2-upload as claude-plugin-cabal-upload-command (CWE-269)
  • mvn deploy and mvn deploy:deploy-file as claude-plugin-mvn-deploy-command (CWE-250)
  • cabal list and mvn package stay inventory
  • hex publish stays claude-plugin-hex-publish-command
  • unquoted # comments, echo/printf lookalikes, assignment values, and marketplace description prose are not this class
  • README cabal/mvn wording is not a hook command
  • snippets are command labels, not tokens or secrets
  • composer publish and go upload are not invented; they are not real package-manager CLIs

#1185 remains owner of hex/conda publish.

Evidence

  • RED d057c3d then GREEN 98dac50
  • tests/test_claude_plugin_cabal_mvn.py plus sibling hex/pub/gem lock
  • plugin coverage suite 538 passed on Python 3.13

Relates to #1099. Relates to #1185.

Current heredoc-safe restack — 2026-09-08

Canonical #1173 exact head 184b4b4f55906284ac1d8059e46cec8f0d9cfc9a fixes closed literal here-document payload false positives with RED 6f6be77d... → GREEN 12faf2f.... This branch was integrated non-destructively on #1185 parent e350ee0ad6e2e313c2d1e38cbdc4f0418477280e; exact head is fb44e77367da1746c8460541c0baed3162c850dc. GitHub compare reports behind_by=0, ahead_by=5; the cabal/mvn detector delta remains in the tree. Exact-head hosted integration and independent review are not terminal, so this PR remains Draft. Earlier head strings are historical evidence only.

Hook and manifest cabal upload, cabal v2-upload, mvn deploy, and
mvn deploy:deploy-file must fail closed. cabal list, mvn package,
comments, echo lookalikes, assignment values, and README wording
stay inventory. Relates to #1099.
Fail closed on executable cabal upload, cabal v2-upload, and mvn
deploy. cabal list and mvn package stay inventory. hex publish stays
the Hex.pm class. Relates to #1099.
@coderabbitai

coderabbitai Bot commented Sep 8, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

seonghobae added a commit that referenced this pull request Sep 8, 2026
Exact head 98dac50 stacked on #1185 fails closed on cabal upload,
cabal v2-upload, and mvn deploy. Relates to #1099.
seonghobae added a commit that referenced this pull request Sep 8, 2026
seonghobae added a commit that referenced this pull request Sep 8, 2026
Snapshot 2026-09-08 08:39 UTC. Draft #1187 a2a800a stacked on #1186
fb44e77 fail-closes gradle publish, gradlew publish, and luarocks
upload. Remaining unique leftover is sbt publish / conan upload.
Does not Close #1099, #1186, or #1185.
seonghobae added a commit that referenced this pull request Sep 8, 2026
Snapshot 2026-09-08 08:46 UTC. Draft #1188 34ef68b stacked on #1187
a2a800a fail-closes sbt publish, sbt publishSigned, and conan upload.
Remaining unique leftover is deno publish / pod trunk push.
Does not Close #1099, #1187, or #1186.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request priority: high

Projects

Status: Backlog

Development

Successfully merging this pull request may close these issues.

1 participant