feat(scanner): reject plugin cabal upload and mvn deploy - #1186
Draft
seonghobae wants to merge 5 commits into
Draft
feat(scanner): reject plugin cabal upload and mvn deploy#1186seonghobae wants to merge 5 commits into
seonghobae wants to merge 5 commits into
Conversation
Hook and manifest cabal upload, cabal v2-upload, mvn deploy, and mvn deploy:deploy-file must fail closed. cabal list, mvn package, comments, echo lookalikes, assignment values, and README wording stay inventory. Relates to #1099.
Fail closed on executable cabal upload, cabal v2-upload, and mvn deploy. cabal list and mvn package stay inventory. hex publish stays the Hex.pm class. Relates to #1099.
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
seonghobae
added a commit
that referenced
this pull request
Sep 8, 2026
This was referenced Sep 8, 2026
seonghobae
added a commit
that referenced
this pull request
Sep 8, 2026
seonghobae
added a commit
that referenced
this pull request
Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successor of #1185 / issue #1099. Does not Close those. hex/conda stay #1185. dart/flutter pub stay #1184. gem/nuget stay #1183. Pass is not Noema admission.
Unique delta
Fail closed when a plugin hook or manifest runs remaining Hackage and Maven writes that #1185 left as inventory:
cabal uploadandcabal v2-uploadasclaude-plugin-cabal-upload-command(CWE-269)mvn deployandmvn deploy:deploy-fileasclaude-plugin-mvn-deploy-command(CWE-250)cabal listandmvn packagestay inventoryhex publishstaysclaude-plugin-hex-publish-command#comments,echo/printflookalikes, assignment values, and marketplace description prose are not this classcomposer publishandgo uploadare not invented; they are not real package-manager CLIs#1185 remains owner of hex/conda publish.
Evidence
d057c3dthen GREEN98dac50tests/test_claude_plugin_cabal_mvn.pyplus sibling hex/pub/gem lockRelates to #1099. Relates to #1185.
Current heredoc-safe restack — 2026-09-08
Canonical #1173 exact head
184b4b4f55906284ac1d8059e46cec8f0d9cfc9afixes closed literal here-document payload false positives with RED6f6be77d...→ GREEN12faf2f.... This branch was integrated non-destructively on #1185 parente350ee0ad6e2e313c2d1e38cbdc4f0418477280e; exact head isfb44e77367da1746c8460541c0baed3162c850dc. GitHub compare reportsbehind_by=0,ahead_by=5; the cabal/mvn detector delta remains in the tree. Exact-head hosted integration and independent review are not terminal, so this PR remains Draft. Earlier head strings are historical evidence only.