feat(scanner): reject plugin sbt publish and conan upload - #1188
Draft
seonghobae wants to merge 10 commits into
Draft
feat(scanner): reject plugin sbt publish and conan upload#1188seonghobae wants to merge 10 commits into
seonghobae wants to merge 10 commits into
Conversation
Hook and manifest sbt publish, sbt publishSigned, and conan upload must fail closed. sbt compile, sbt publishLocal, conan list, comments, echo lookalikes, assignment values, and README wording stay inventory. Relates to #1099.
Fail closed on executable sbt publish, sbt publishSigned, and conan upload. sbt compile, sbt publishLocal, and conan list stay inventory. gradle publish stays the Gradle class. Relates to #1099.
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
seonghobae
added a commit
that referenced
this pull request
Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successor of #1187 / issue #1099. Does not Close those. gradle/luarocks stay #1187. cabal/mvn stay #1186. hex/conda stay #1185. Pass is not Noema admission.
Unique delta
Fail closed when a plugin hook or manifest runs remaining sbt and Conan writes that #1187 left as inventory:
sbt publishandsbt publishSignedasclaude-plugin-sbt-publish-command(CWE-269)conan uploadasclaude-plugin-conan-upload-command(CWE-250)sbt compile,sbt publishLocal, andconan liststay inventorygradle publishstaysclaude-plugin-gradle-publish-command#comments,echo/printflookalikes, assignment values, and marketplace description prose are not this classcomposer publishandgo uploadare not invented; they are not real package-manager CLIs#1187 remains owner of gradle/luarocks publish.
Evidence
a88ac06then GREEN34ef68btests/test_claude_plugin_sbt_conan.pyplus sibling gradle/cabal lockRelates to #1099. Relates to #1187.
Current quoted sbt task repair — 2026-09-08
RED
ad3a238b1c35158c1301418928d8fa91e32634f8proves that executablesbt "publish"andsbt 'publishSigned'were missed. GREENccce2a0db42b6998de43fdd85f8f62a3cf7accc4matches the command from the unquotedsbttoken while keeping quoted/unquotedpublishLocalnegative. Follow-up RED25e07a631492f797858ce2622c607d5e6560d599proves the same task inside$(...)or backticks must remain executable; GREEN935a5fd7f4a8d7e979c46d9822ff6a9a2d05e968admits those closing delimiters. Exact AST caught and cleanup63c42a76c7b06d2b00ace53cfdde59d56ae9f0adremoved an invalid fixture escape. Exact source/test AST now passes with SyntaxWarning-as-error; extracted production helpers pass 6/6 positives and 5/5 negatives. The PR remains Draft pending hosted integration and independent current-head review. Earlier head strings are historical evidence only.