feat(scanner): reject plugin npm twine and cargo publish - #1180
Draft
seonghobae wants to merge 14 commits into
Draft
feat(scanner): reject plugin npm twine and cargo publish#1180seonghobae wants to merge 14 commits into
seonghobae wants to merge 14 commits into
Conversation
Lock executable npm publish, twine upload, and cargo publish. Keep npm pack, cargo check, comments, echo lookalikes, and s3 writes on their existing classes. Relates to #1099.
Fail closed on executable npm publish as claude-plugin-npm-publish-command, twine upload as claude-plugin-pypi-upload-command, and cargo publish as claude-plugin-cargo-publish-command. Reads, comments, and echo lookalikes stay inventory. Relates to #1099.
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
seonghobae
added a commit
that referenced
this pull request
Sep 8, 2026
Summary: - Snapshot 2026-09-08 05:11 UTC records Draft #1180 `ffcb8ef` stacked on #1179. - Executable npm publish, twine upload, and cargo publish fail closed. - Remaining leftover: pnpm/yarn/uv/poetry publish. Rationale: - #999 is the single writer of the product-technical gap baseline. - Do not Close #1099 or #1179. Tests: - documentation-only; detector evidence lives on #1180 (465 passed)
seonghobae
added a commit
that referenced
this pull request
Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successor of #1179 / issue #1099. Does not Close those. Object-store s3/containerapp stay #1179. Cloud deploy stays #1177. Pass is not Noema admission.
Unique delta
Fail closed when a plugin hook or manifest runs remaining registry publish writes that #1179 left as inventory:
npm publishasclaude-plugin-npm-publish-command(CWE-269)twine upload(includingpython -m twine upload) asclaude-plugin-pypi-upload-command(CWE-250)cargo publishasclaude-plugin-cargo-publish-command(CWE-269)npm pack,cargo check, andpip installstay inventory#comments,echo/printflookalikes, and marketplace description prose are not this classclaude-plugin-aws-s3-write-command#1179 remains owner of s3 writes and containerapp up.
Evidence
3253383then GREENffcb8ef.af45351edc214136780b66ed3a96ad15acca036cintegrates current feat(scanner): reject plugin s3 writes and containerapp up #11793073ffdb..., including S3 direction RED/GREEN and the download-before-later-upload regression, without changing this PR's five-file registry-publish delta.Relates to #1099. Relates to #1179.
Current quoted-command context repair
This descendant inherits #1173 RED
d7384e53d44a426356a73e24b2b9cc3fe153de27and final canonical repair3a5b14771cc7abb6553fa1ec9bcd8b62acc947acwithout copying a leaf workaround. Exact head:e835a8fc4e050bb6f960ed04686717b5773bc63f; current parent:f8372ece60fdf2db61a0fbd733414083ea09d3f1; Git compare is 0 behind and preserves this PR's unique detector/test delta. The top #1183 source AST and extracted helper probes pass quoted/reporting negatives while preserving direct and command-substitution positives. This custom-base PR stays Draft until its own hosted integration and independent review are terminal.Current assignment-value context repair — 2026-09-08
This normal two-parent descendant inherits canonical #1173 RED
90ae232e852b3d01463d978f9bccd9157c341fe7and GREEN1e6a3eb43a5bc2d146656af13e7fa6cad2a77315without a leaf workaround. Exact head:167a0ba7cc538bb2d3d56679ddc7d24fc71ef32d; current parent:10c0a34a14200f6013bd904e5bf205487e4b80e8; Git compare is 0 behind and preserves this PR's unique detector/test delta. Assignment-value negatives and environment-prefix/direct/substitution positives are present in the exact tree. This custom-base PR remains Draft until its own hosted integration and independent current-head review are terminal. Earlier head strings in this body are historical evidence only.Current heredoc-safe restack — 2026-09-08
Canonical #1173 exact head
184b4b4f55906284ac1d8059e46cec8f0d9cfc9afixes closed literal here-document payload false positives with RED6f6be77d...→ GREEN12faf2f.... This branch was integrated non-destructively on parent730d42926d383c59e9f01a12df625b32c3824285; exact head isecc7a1c883cd06d80a9431b35aa152282c7a5f9e. GitHub compare reportsbehind_by=0,ahead_by=14; the PR's unique detector delta remains in the tree. Exact-head hosted integration and independent review are not terminal, so this PR remains Draft. Earlier head strings are historical evidence only.