Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions CHANGELOG.d/1099-claude-plugin-supply-chain.md
Original file line number Diff line number Diff line change
Expand Up @@ -155,12 +155,15 @@
``az webapp deploy`` fails as `claude-plugin-az-deploy-command`.
``aws s3 sync`` and ``aws s3 cp`` fail as
`claude-plugin-aws-s3-write-command`. ``az containerapp up`` fails as
`claude-plugin-az-containerapp-up-command`.
`claude-plugin-az-containerapp-up-command`. ``npm publish`` fails as
`claude-plugin-npm-publish-command`. ``twine upload`` fails as
`claude-plugin-pypi-upload-command`. ``cargo publish`` fails as
`claude-plugin-cargo-publish-command`.
Hook comments and
``echo``/``printf`` lookalikes are not those classes.
``terraform plan``, ``helm list``,
``vercel ls``, ``fly status``, ``aws s3 ls``, ``gcloud config list``,
and ``az account show``
``az account show``, ``npm pack``, and ``cargo check``
stay inventory. Hardcoded
PATs stay `claude-plugin-github-write-token`. Snippets are command
labels, not tokens.
Expand Down
118 changes: 114 additions & 4 deletions appguardrail_core/claude_plugin_detector.py
Original file line number Diff line number Diff line change
Expand Up @@ -30,10 +30,13 @@
deploy``, and ``az webapp deploy`` fail closed as cloud-deploy command
findings. Hook or manifest ``aws s3 sync``, ``aws s3 cp``, and
``az containerapp up`` fail closed as object-store and Container Apps
writes. Unquoted ``#`` comments and
writes. Hook or manifest ``npm publish``, ``twine upload``, and
``cargo publish`` fail closed as registry-publish command findings.
Unquoted ``#`` comments and
``echo``/``printf``/``print`` lookalikes are not that class.
``terraform plan``, ``helm list``, ``vercel ls``, ``fly status``,
``aws s3 ls``, ``gcloud config list``, and ``az account show``
``aws s3 ls``, ``gcloud config list``, ``az account show``,
``npm pack``, and ``cargo check``
stay inventory. Hook or manifest paths into
``~/.netrc``, ``~/.aws/credentials``,
GitHub CLI hosts, Docker auth ``config.json``, cookie jars, and
Expand All @@ -42,7 +45,8 @@
Hardcoded PATs stay write-token findings.
``gh issue create``, ``gh pr review``, ``kubectl get``, ``docker ps``,
``terraform plan``, ``helm list``, ``vercel ls``, ``fly status``,
``aws s3 ls``, ``gcloud config list``, and ``az account show``
``aws s3 ls``, ``gcloud config list``, ``az account show``,
``npm pack``, and ``cargo check``
stay inventory. Skill
homoglyph, injection, exfiltration, and placeholder hits reuse #1036 rule
identities. Skill, command, or agent text that hides tool use, rewrites
Expand Down Expand Up @@ -310,6 +314,21 @@
"a Container Apps revision is write authority. Remove the command. "
"[CWE-250 - Execution with Unnecessary Privileges]"
)
CLAUDE_PLUGIN_NPM_PUBLISH_COMMAND_MESSAGE: Final = (
"Claude plugin hook or manifest runs npm publish. Publishing a package "
"is write authority on the npm registry. Remove the command. "
"[CWE-269 - Improper Privilege Management]"
)
CLAUDE_PLUGIN_PYPI_UPLOAD_COMMAND_MESSAGE: Final = (
"Claude plugin hook or manifest runs twine upload. Uploading a "
"distribution is write authority on PyPI. Remove the command. "
"[CWE-250 - Execution with Unnecessary Privileges]"
)
CLAUDE_PLUGIN_CARGO_PUBLISH_COMMAND_MESSAGE: Final = (
"Claude plugin hook or manifest runs cargo publish. Publishing a crate "
"is write authority on crates.io. Remove the command. "
"[CWE-269 - Improper Privilege Management]"
)
CLAUDE_PLUGIN_DOCKER_SOCKET_MESSAGE: Final = (
"Claude plugin hook reaches the host Docker socket. Socket access is host "
"control, not an image push. Remove the socket bind and keep builds "
Expand Down Expand Up @@ -459,6 +478,9 @@
r"\baz\s+containerapp\s+up\b",
re.IGNORECASE,
)
_NPM_PUBLISH_COMMAND = re.compile(r"\bnpm\s+publish\b", re.IGNORECASE)
_PYPI_UPLOAD_COMMAND = re.compile(r"\btwine\s+upload\b", re.IGNORECASE)
_CARGO_PUBLISH_COMMAND = re.compile(r"\bcargo\s+publish\b", re.IGNORECASE)
_REPORTING_BUILTINS: Final = frozenset(
{":", "echo", "false", "print", "printf", "true"}
)
Expand Down Expand Up @@ -767,7 +789,8 @@
(
"package_install",
re.compile(
r"\b(?:pip|npm|pnpm|yarn|uv|cargo|apt-get)\s+install\b",
r"\b(?:pip|npm|pnpm|yarn|uv|cargo|apt-get)\s+install\b|"
r"\b(?:npm\s+publish|twine\s+upload|cargo\s+publish)\b",
re.IGNORECASE,
),
),
Expand Down Expand Up @@ -987,6 +1010,9 @@ def inspect_claude_plugin_file(
hits.extend(_az_deploy_command_hits(content, manifest=manifest))
hits.extend(_aws_s3_write_command_hits(content, manifest=manifest))
hits.extend(_az_containerapp_up_command_hits(content, manifest=manifest))
hits.extend(_npm_publish_command_hits(content, manifest=manifest))
hits.extend(_pypi_upload_command_hits(content, manifest=manifest))
hits.extend(_cargo_publish_command_hits(content, manifest=manifest))
hits.extend(_docker_socket_hits(content))
hits.extend(_browser_profile_hits(content))
hits.extend(_credential_store_hits(content))
Expand Down Expand Up @@ -2616,6 +2642,90 @@ def _az_containerapp_up_command_hits(
return ()


def _npm_publish_command_hits(
content: str, *, manifest: bool = False
) -> tuple[PluginHit, ...]:
"""Return ``npm publish`` findings with a command label, not tokens.

Args:
content: Hook or manifest text.
manifest: When true, only structural command values are scanned.

Returns:
One hit for executable ``npm publish``. ``npm pack``, comments,
and echo lookalikes are not this class.
"""
for source, first_line in _hosted_command_sources(content, manifest=manifest):
match = _executable_command_match(source, _NPM_PUBLISH_COMMAND)
if match is None:
continue
return (
PluginHit(
rule_id="claude-plugin-npm-publish-command",
line=first_line + source[: match.start()].count("\n"),
snippet="npm publish",
message=CLAUDE_PLUGIN_NPM_PUBLISH_COMMAND_MESSAGE,
),
)
return ()


def _pypi_upload_command_hits(
content: str, *, manifest: bool = False
) -> tuple[PluginHit, ...]:
"""Return ``twine upload`` findings with a command label, not filenames.

Args:
content: Hook or manifest text.
manifest: When true, only structural command values are scanned.

Returns:
One hit for executable ``twine upload``. ``pip install`` is not
this class.
"""
for source, first_line in _hosted_command_sources(content, manifest=manifest):
match = _executable_command_match(source, _PYPI_UPLOAD_COMMAND)
if match is None:
continue
return (
PluginHit(
rule_id="claude-plugin-pypi-upload-command",
line=first_line + source[: match.start()].count("\n"),
snippet="twine upload",
message=CLAUDE_PLUGIN_PYPI_UPLOAD_COMMAND_MESSAGE,
),
)
return ()


def _cargo_publish_command_hits(
content: str, *, manifest: bool = False
) -> tuple[PluginHit, ...]:
"""Return ``cargo publish`` findings with a command label, not crate names.

Args:
content: Hook or manifest text.
manifest: When true, only structural command values are scanned.

Returns:
One hit for executable ``cargo publish``. ``cargo check`` is not
this class.
"""
for source, first_line in _hosted_command_sources(content, manifest=manifest):
match = _executable_command_match(source, _CARGO_PUBLISH_COMMAND)
if match is None:
continue
return (
PluginHit(
rule_id="claude-plugin-cargo-publish-command",
line=first_line + source[: match.start()].count("\n"),
snippet="cargo publish",
message=CLAUDE_PLUGIN_CARGO_PUBLISH_COMMAND_MESSAGE,
),
)
return ()


def _dynamic_eval_hits(content: str) -> tuple[PluginHit, ...]:
"""Return findings for eval/exec/compile/Function on hook surfaces."""
match = _DYNAMIC_EVAL.search(content)
Expand Down
2 changes: 1 addition & 1 deletion docs/TRACEABILITY.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
| structural Semgrep-style `pattern:` execution by lightweight engine | built-in scanner | not implemented unless a real structural matcher is added; fixtures are not execution |
| GitHub Actions transport-only polling loop (#1087, #938 vertical slice) | owned by PR #1088 / issue #1087; YAML rules and RED precision contracts | mapped-family only; this successor does not ship or close the detector |
| Password/database-url/auth-comment precision and test-file context (#1106) | existing `_scan_file` rules `hardcoded-password`, `hardcoded-database-url`, `todo-skip-auth`, `_finding_context` | implemented-branch regression lock |
| Claude plugin marketplace/package supply chain (#1099) | `claude-plugin-floating-git-ref`, `claude-plugin-provider-secret`, `claude-plugin-pipe-to-shell`, `claude-plugin-unsigned-executable-download` (hooks and package.json lifecycle scripts), `claude-plugin-unpinned-package-install`, `claude-plugin-undeclared-executable`, `claude-plugin-symlink-escape`, `claude-plugin-archive-path-traversal`, `claude-plugin-unadmitted-submodule`, `claude-plugin-duplicate-json-member`, `claude-plugin-nonstandard-json-constant`, `claude-plugin-malformed-utf8`, `claude-plugin-inconsistent-normalized-name`, `claude-plugin-vendored-scope-undeclared`, `claude-plugin-conflicting-identity`, `claude-plugin-unbounded-mcp`, `claude-plugin-license-missing`, `claude-plugin-license-mismatch`, `claude-plugin-dynamic-eval`, `claude-plugin-hidden-undeclared-executable`, `claude-plugin-concealed-identity`, `claude-plugin-oversized-package`, `claude-plugin-source-mismatch`, `claude-plugin-github-write-token`, `claude-plugin-docker-socket`, `claude-plugin-browser-profile-access`, `claude-plugin-deceptive-description`, `claude-plugin-secret-to-network`, `claude-plugin-secret-to-prompt`, `claude-plugin-secret-to-mcp`, `claude-plugin-hide-actions-directive` / `claude-plugin-self-modify-directive` / `claude-plugin-goal-escalation-directive`, `claude-plugin-setuid-executable` / `claude-plugin-world-writable-executable`, `claude-plugin-decompression-bomb`, reused #1036 `skill-name-homoglyph-confusable` / `skill-manifest-prompt-injection-payload` / `skill-doc-exfiltration-endpoint-directive` / `skill-placeholder-template-unresolved` on plugin skill/agent/command surfaces, deterministic scan receipt with catalog repository/SHA bind, SARIF 2.1.0 `sarif_sha256` bound to the same finding rule_ids, `policy_provenance` bound to the AppGuardrail release plus exact scan-policy digest, and `sbom_sha256` of a deterministic CycloneDX 1.5 document, `claude-plugin-checksum-mismatch` when a first-party SHA256SUMS or sibling `*.sha256` disagrees with bytes on disk, `claude-plugin-unsigned-checksum` when checksum digest rows have no sibling Cosign/GPG signature file, `claude-plugin-excessive-path-depth` when a materialized file or archive member nests past 32 path components, `claude-plugin-github-merge-command` for hook or manifest `gh pr merge`, `claude-plugin-github-release-command` for `gh release create|upload|delete|edit`, `claude-plugin-kubectl-apply-command` for hook or manifest `kubectl apply`, `claude-plugin-docker-push-command` for `docker push`, `claude-plugin-terraform-apply-command` for `terraform apply`, `claude-plugin-helm-install-command` for `helm install`, `claude-plugin-vercel-deploy-command` for hook or manifest `vercel deploy`, `claude-plugin-fly-deploy-command` for `fly deploy`, `claude-plugin-aws-deploy-command` for hook or manifest `aws cloudformation deploy`, `claude-plugin-gcloud-deploy-command` for `gcloud run deploy`, `claude-plugin-az-deploy-command` for `az webapp deploy`, `claude-plugin-aws-s3-write-command` for hook or manifest `aws s3 sync`/`cp`, `claude-plugin-az-containerapp-up-command` for `az containerapp up`, `claude-plugin-credential-store-access` for host cookie and token stores that are not browser profiles, fail-closed receipt verification | implemented-branch |
| Claude plugin marketplace/package supply chain (#1099) | `claude-plugin-floating-git-ref`, `claude-plugin-provider-secret`, `claude-plugin-pipe-to-shell`, `claude-plugin-unsigned-executable-download` (hooks and package.json lifecycle scripts), `claude-plugin-unpinned-package-install`, `claude-plugin-undeclared-executable`, `claude-plugin-symlink-escape`, `claude-plugin-archive-path-traversal`, `claude-plugin-unadmitted-submodule`, `claude-plugin-duplicate-json-member`, `claude-plugin-nonstandard-json-constant`, `claude-plugin-malformed-utf8`, `claude-plugin-inconsistent-normalized-name`, `claude-plugin-vendored-scope-undeclared`, `claude-plugin-conflicting-identity`, `claude-plugin-unbounded-mcp`, `claude-plugin-license-missing`, `claude-plugin-license-mismatch`, `claude-plugin-dynamic-eval`, `claude-plugin-hidden-undeclared-executable`, `claude-plugin-concealed-identity`, `claude-plugin-oversized-package`, `claude-plugin-source-mismatch`, `claude-plugin-github-write-token`, `claude-plugin-docker-socket`, `claude-plugin-browser-profile-access`, `claude-plugin-deceptive-description`, `claude-plugin-secret-to-network`, `claude-plugin-secret-to-prompt`, `claude-plugin-secret-to-mcp`, `claude-plugin-hide-actions-directive` / `claude-plugin-self-modify-directive` / `claude-plugin-goal-escalation-directive`, `claude-plugin-setuid-executable` / `claude-plugin-world-writable-executable`, `claude-plugin-decompression-bomb`, reused #1036 `skill-name-homoglyph-confusable` / `skill-manifest-prompt-injection-payload` / `skill-doc-exfiltration-endpoint-directive` / `skill-placeholder-template-unresolved` on plugin skill/agent/command surfaces, deterministic scan receipt with catalog repository/SHA bind, SARIF 2.1.0 `sarif_sha256` bound to the same finding rule_ids, `policy_provenance` bound to the AppGuardrail release plus exact scan-policy digest, and `sbom_sha256` of a deterministic CycloneDX 1.5 document, `claude-plugin-checksum-mismatch` when a first-party SHA256SUMS or sibling `*.sha256` disagrees with bytes on disk, `claude-plugin-unsigned-checksum` when checksum digest rows have no sibling Cosign/GPG signature file, `claude-plugin-excessive-path-depth` when a materialized file or archive member nests past 32 path components, `claude-plugin-github-merge-command` for hook or manifest `gh pr merge`, `claude-plugin-github-release-command` for `gh release create|upload|delete|edit`, `claude-plugin-kubectl-apply-command` for hook or manifest `kubectl apply`, `claude-plugin-docker-push-command` for `docker push`, `claude-plugin-terraform-apply-command` for `terraform apply`, `claude-plugin-helm-install-command` for `helm install`, `claude-plugin-vercel-deploy-command` for hook or manifest `vercel deploy`, `claude-plugin-fly-deploy-command` for `fly deploy`, `claude-plugin-aws-deploy-command` for hook or manifest `aws cloudformation deploy`, `claude-plugin-gcloud-deploy-command` for `gcloud run deploy`, `claude-plugin-az-deploy-command` for `az webapp deploy`, `claude-plugin-aws-s3-write-command` for hook or manifest `aws s3 sync`/`cp`, `claude-plugin-az-containerapp-up-command` for `az containerapp up`, `claude-plugin-npm-publish-command` for hook or manifest `npm publish`, `claude-plugin-pypi-upload-command` for `twine upload`, `claude-plugin-cargo-publish-command` for `cargo publish`, `claude-plugin-credential-store-access` for host cookie and token stores that are not browser profiles, fail-closed receipt verification | implemented-branch |
| Orphaned GitHub Actions registry identities (#929) | owned by PR #966 / issue #929; live registry DAST | mapped-family only; this successor does not ship or close the detector |
| Org security-failure CI tickets without copied vuln evidence | documented non-detectable family | snapshot in `tests/fixtures/cwl-security-issue-inventory.json` |

Expand Down
5 changes: 4 additions & 1 deletion docs/sast-dast-rule-research.md
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,9 @@ files being scanned, then applies the union of relevant checks. Examples:
`claude-plugin-az-deploy-command` for ``az webapp deploy``,
`claude-plugin-aws-s3-write-command` for ``aws s3 sync``/``cp``,
`claude-plugin-az-containerapp-up-command` for ``az containerapp up``,
`claude-plugin-npm-publish-command` for ``npm publish``,
`claude-plugin-pypi-upload-command` for ``twine upload``,
`claude-plugin-cargo-publish-command` for ``cargo publish``,
and
`claude-plugin-credential-store-access` for host ``~/.netrc``,
``~/.aws/credentials``, GitHub CLI hosts, Docker auth, cookie jars, and
Expand All @@ -120,7 +123,7 @@ files being scanned, then applies the union of relevant checks. Examples:
`claude-plugin-github-write-token`. ``gh issue create``, ``gh pr review``,
``kubectl get``, ``docker ps``, ``terraform plan``, ``helm list``,
``vercel ls``, ``fly status``, ``aws s3 ls``, ``gcloud config list``,
and ``az account show`` stay inventory.
``az account show``, ``npm pack``, and ``cargo check`` stay inventory.
- Mapped, not owned here: GitHub Actions transport-only poll loops (#1087,
PR #1088) and orphaned workflow registry DAST (#929, PR #966).
- `tool-execute-parameters-passthrough`: Strix-observed dynamic tool execution
Expand Down
Loading