feat(scanner): flag ambiguous vendored plugin code scope - #1156
Draft
seonghobae wants to merge 3 commits into
Draft
seonghobae wants to merge 3 commits into
seonghobae wants to merge 3 commits into
Conversation
RED contract for vendor/, node_modules/, dist/, and min.js copies that are not declared in plugin.json files[]. Relates to #1099.
Fail closed on undeclared vendor/, node_modules/, dist/, and min.js copies as one scope finding. files[] and admitted nested plugins stay identity-bound. Relates to #1099.
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
2 of 4 tasks
seonghobae
added a commit
that referenced
this pull request
Sep 7, 2026
Summary: - Snapshot 17:18 UTC records Draft #1156 `a6f6a74` stacked on #1155. - Undeclared vendor/node_modules/dist copies fail as one scope finding. - Hook walks skip those trees so admission is not a per-file flood. Rationale: - #999 is the single writer of the product-technical gap baseline. - #1099 remaining surfaces stay on stacked successors, not Close. Tests: - documentation-only; detector evidence lives on #1156 (1709/1709)
This was referenced Sep 7, 2026
2 of 5 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current repair boundary — 2026-09-12
feat/claude-plugin-normalized-name-1099@c40e616fa5e4a8268152132e777cbfd8e3da1d1412f968c76da6569dd281efdb91b0677fb2e1a754ecba5db7e8d21452a29b90d212ca9fa7f7a47817a6f6a74…and current feat(scanner): reject non-NFC plugin identity names #1155 headc40e616…; no force updatePYTHONPATH=. python -m pytest -q tests/test_claude_plugin*.py→ 205 passed;py_compileandgit diff --checkpassedSuccessor of #1155 / issue #1099. Does not Close those. NFC identity stays #1155. Inventory is evidence, not permission.
Unique delta
When a plugin tree contains vendored or generated third-party code that is not declared as a bounded, identity-bound dependency, fail closed as one scope finding (
claude-plugin-vendored-scope-undeclared):vendor/leftpad.jsornode_modules/foo/index.jsfails admissiondist/and*.min.jsbundles are the same classhooks/pre.shplus LICENSE is not this findingpackage.jsonplus a lockfile withoutnode_modules/stays inventoryfiles[]are declared scopevendor/nestedstay the submodule classscan_result=passis not Noema admission.Test plan
tests/test_claude_plugin_vendored_scope.py)Relates to #1099. Relates to #1155.