Skip to content

feat(scanner): reject deceptive plugin capability descriptions - #1151

Draft
seonghobae wants to merge 3 commits into
feat/claude-plugin-browser-profile-1099from
feat/claude-plugin-deceptive-description-1099
Draft

seonghobae wants to merge 3 commits into
feat/claude-plugin-browser-profile-1099from
feat/claude-plugin-deceptive-description-1099

Conversation

@seonghobae

@seonghobae seonghobae commented Sep 7, 2026 •

Copy link
Copy Markdown
Contributor

Current repair boundary — 2026-09-12

Successor of #1150 / issue #1099. Does not Close those. Browser-profile stays #1150. Inventory is evidence, not permission.

Unique delta

Fail closed on deceptive plugin/skill/command descriptions (claude-plugin-deceptive-description):

  • description read-only local helper plus a hook that curls a URL fails admission
  • description sends data to example.com plus the same hook is not this finding
  • a pinned licensed echo hook with a matching description may pass
  • an empty description is not deceptive by itself
  • a README claim is not a plugin/skill/command description
  • a bare Firefox product name stays browser_profile_access inventory, not this finding
  • write, GitHub write, credential, remote MCP, and shell denials that contradict inventory fail closed
  • snippets omit secrets and raw bidi

#1150 remains owner of host browser-profile stores.

Test plan

  • RED then GREEN (tests/test_claude_plugin_deceptive_description.py)
  • Detector statement coverage 1560/1560 with plugin suites on Python 3.13
  • Exact-head Checks on this head
  • Keep Draft until current-head gates are GREEN

Relates to #1099. Relates to #1150.

@coderabbitai

coderabbitai Bot commented Sep 7, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

seonghobae added a commit that referenced this pull request Sep 7, 2026
Summary:
- Snapshot 15:28 UTC records Draft #1151 `822ca12` on #1150 and
  Draft #1152 `255cfd8` on #1133.
- `_scan_file` emits poll analyzer findings once per (rule_id, file).
- Deceptive read-only descriptions fail closed when inventory shows
  write or egress.

Rationale:
- #999 is the single writer of the product-technical gap baseline.
- G-06 emission waited on #1133 exact-head coverage SUCCESS.

Tests:
- documentation-only; evidence lives on #1151 (1560/1560) and #1152
  (417/417 analyzer statements)
seonghobae added a commit that referenced this pull request Sep 7, 2026
Refresh the single-writer gap baseline from live exact-head evidence:
Draft #1153 on #1151. Relates to #1099.
@seonghobae seonghobae added enhancement New feature or request priority: medium Normal-priority or P2 work labels Sep 8, 2026 — with ChatGPT Codex Connector

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request priority: medium Normal-priority or P2 work

Projects

Status: Backlog

Development

Successfully merging this pull request may close these issues.

1 participant