Skip to content

feat(scanner): bind plugin SARIF findings to the scan receipt - #1142

Draft
seonghobae wants to merge 3 commits into
feat/claude-plugin-catalog-bind-1099from
feat/claude-plugin-sarif-receipt-1099
Draft

feat(scanner): bind plugin SARIF findings to the scan receipt#1142
seonghobae wants to merge 3 commits into
feat/claude-plugin-catalog-bind-1099from
feat/claude-plugin-sarif-receipt-1099

Conversation

@seonghobae

@seonghobae seonghobae commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Current repair boundary — 2026-09-12

Successor of #1141 / issue #1099. Unique remaining TDD item 15: receipt sarif_sha256 is the SHA-256 of a deterministic SARIF 2.1.0 document covering the same finding rule_ids as finding_summary. Semantic consistency requires matching IDs and counts; swapping one SARIF ruleId fails the check. An undeclared executable changes both finding_summary and sarif_sha256. Reuses findings_to_sarif. Does not Close #1099 or #1141. Does not steal G-06 #1133 or #1140 CLI unique delta. scan_result=pass is not Noema admission.

Test plan

  • RED then GREEN (test(scanner): require plugin SARIF receipt binding then this commit)
  • claude_plugin_sarif.py 50/50 statement coverage
  • claude_plugin_detector.py 1243/1243 with existing plugin tests
  • Exact-head Checks on this head
  • Keep Draft until current-head gates are GREEN

Relates to #1099. Relates to #1141.

Failing contracts for issue #1099 TDD item 15: receipt sarif_sha256
must hash a deterministic SARIF 2.1.0 document covering the same
rule_ids as finding_summary, stay stable across identical scans,
and fail a consistency check when a SARIF ruleId is swapped.
Hash receipt sarif_sha256 from a deterministic SARIF 2.1.0 document
that covers the same finding rule_ids as finding_summary, reusing
findings_to_sarif. Relates to #1099. Does not Close #1099 or #1141.
@coderabbitai

coderabbitai Bot commented Sep 7, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

seonghobae added a commit that referenced this pull request Sep 7, 2026
Summary:
- Snapshot 12:10 UTC records Draft #1142 `d5df6c7` stacked on #1141.
- Receipt sarif_sha256 matches finding_summary rule IDs.
- Pass is not Noema admission.

Rationale:
- #999 is the single writer of the product-technical gap baseline.
- #1099 remaining surfaces stay on stacked successors, not Close.

Tests:
- documentation-only; SARIF adapter evidence lives on #1142 (50/50)
@seonghobae seonghobae added enhancement New feature or request priority: medium Normal-priority or P2 work labels Sep 8, 2026 — with ChatGPT Codex Connector
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request priority: medium Normal-priority or P2 work

Projects

Status: Backlog

Development

Successfully merging this pull request may close these issues.

1 participant