feat(scanner): bind plugin SARIF findings to the scan receipt - #1142
Draft
seonghobae wants to merge 3 commits into
Draft
feat(scanner): bind plugin SARIF findings to the scan receipt#1142seonghobae wants to merge 3 commits into
seonghobae wants to merge 3 commits into
Conversation
Failing contracts for issue #1099 TDD item 15: receipt sarif_sha256 must hash a deterministic SARIF 2.1.0 document covering the same rule_ids as finding_summary, stay stable across identical scans, and fail a consistency check when a SARIF ruleId is swapped.
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
seonghobae
added a commit
that referenced
this pull request
Sep 7, 2026
Summary: - Snapshot 12:10 UTC records Draft #1142 `d5df6c7` stacked on #1141. - Receipt sarif_sha256 matches finding_summary rule IDs. - Pass is not Noema admission. Rationale: - #999 is the single writer of the product-technical gap baseline. - #1099 remaining surfaces stay on stacked successors, not Close. Tests: - documentation-only; SARIF adapter evidence lives on #1142 (50/50)
This was referenced Sep 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current repair boundary — 2026-09-12
feat/claude-plugin-catalog-bind-1099@a1bff47328ca8fe5c762e450537bdbfc692d72928850f01300e44615245e91a12bfe64c90a095a1a0b50a035dfc4510ad52179d68223b59bfba069d1d5df6c7…and current feat(scanner): bind marketplace catalog identity onto plugin receipts #1141 heada1bff47…; no force updatePYTHONPATH=. python -m pytest -q tests/test_claude_plugin*.py→ 110 passed;py_compileandgit diff --checkpassedSuccessor of #1141 / issue #1099. Unique remaining TDD item 15: receipt
sarif_sha256is the SHA-256 of a deterministic SARIF 2.1.0 document covering the same finding rule_ids asfinding_summary. Semantic consistency requires matching IDs and counts; swapping one SARIFruleIdfails the check. An undeclared executable changes bothfinding_summaryandsarif_sha256. Reusesfindings_to_sarif. Does not Close #1099 or #1141. Does not steal G-06 #1133 or #1140 CLI unique delta.scan_result=passis not Noema admission.Test plan
test(scanner): require plugin SARIF receipt bindingthen this commit)claude_plugin_sarif.py50/50 statement coverageclaude_plugin_detector.py1243/1243 with existing plugin testsRelates to #1099. Relates to #1141.