Skip to content

feat(scanner): fail closed on plugin LICENSE/NOTICE SPDX mismatch - #1143

Draft
seonghobae wants to merge 2 commits into
feat/claude-plugin-sarif-receipt-1099from
feat/claude-plugin-license-mismatch-1099
Draft

feat(scanner): fail closed on plugin LICENSE/NOTICE SPDX mismatch#1143
seonghobae wants to merge 2 commits into
feat/claude-plugin-sarif-receipt-1099from
feat/claude-plugin-license-mismatch-1099

Conversation

@seonghobae

@seonghobae seonghobae commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Current repair boundary — 2026-09-12

Summary

  • NOTICE files count as license evidence, so a NOTICE-only tree is not claude-plugin-license-missing.
  • Conflicting SPDX identifiers across the declared license field, LICENSE, and NOTICE fail as claude-plugin-license-mismatch.
  • Copyright-only NOTICE text does not invent an SPDX token. Matching MIT evidence still passes.
  • Does not invent legal approval. scan_result=pass is not Noema admission.

Stacked on #1142. Unique remaining #1099 TDD item 11 mismatch slice. Do not Close #1099 or #1142. Do not steal G-06 #1133.

Test plan

  • RED then GREEN (tests/test_claude_plugin_license_mismatch.py)
  • Detector statement coverage 935/935 with plugin suites
  • Exact-head Checks on this head
  • Keep Draft until current-head gates are GREEN

Relates to #1099. Relates to #1142.

NOTICE files count as license evidence. Conflicting SPDX identifiers
across the declared license field, LICENSE, and NOTICE fail admission
without inventing legal approval. Relates to #1099.
@coderabbitai

coderabbitai Bot commented Sep 7, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

seonghobae added a commit that referenced this pull request Sep 7, 2026
Snapshot 2026-09-07 12:58 UTC: #998 8b95c2b Tests/AST/Noema GREEN, Strix
in progress, CodeQL-compat pending-handoff; #1141 e9852bd; #1143 e5051ea
LICENSE/NOTICE SPDX mismatch. Do not Close #983 or #1099.

Copy link
Copy Markdown
Contributor Author

Unique remaining #1099 TDD item 11 mismatch slice on #1142 d5df6c7.

Exact head e5051ea32eeedb708e3f7e04c1f25c395fc4bbbd. NOTICE counts as license evidence. Conflicting SPDX tokens fail as claude-plugin-license-mismatch. Detector statement coverage 935/935. Keep Draft. Do not Close #1099 or #1142.

Copy link
Copy Markdown
Contributor Author

Successor slice for #1099 lifecycle/post-install scripts is stacked on this head as Draft #1144 (feat/claude-plugin-postinstall-download-1099 @ c66dfaf88b29ae478431c2fd1a0d325d91da4bc2).

package.json preinstall/install/postinstall unsigned downloads fail closed on the existing claude-plugin-unsigned-executable-download / pipe-to-shell / unpinned-package-install rules. Lockfile-only trees without a postinstall download stay package_install inventory. LICENSE/NOTICE SPDX mismatch on this PR is unchanged. Does not Close #1099 or #1143. Does not steal G-06 #1133 or #1142 SARIF.

seonghobae added a commit that referenced this pull request Sep 7, 2026
Summary:
- Snapshot 13:10 UTC records Draft #1144 `c66dfaf` stacked on #1143.
- package.json install lifecycle downloads fail closed.
- Lockfile-only trees stay package_install inventory.

Rationale:
- #999 is the single writer of the product-technical gap baseline.
- #1099 remaining surfaces stay on stacked successors, not Close.

Tests:
- documentation-only; detector evidence lives on #1144 (1359/1359)
@seonghobae seonghobae added enhancement New feature or request priority: medium Normal-priority or P2 work labels Sep 8, 2026 — with ChatGPT Codex Connector
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request priority: medium Normal-priority or P2 work

Projects

Status: Backlog

Development

Successfully merging this pull request may close these issues.

1 participant