feat(reports): leftover-map coordinate ticks on grouping comparison graphic (v2.77.0) - #860
Conversation
…raphic (v2.77.0)
Caption persisted leftover-map coordinate ticks on the grouping
comparison leftover-map graphic from already-named leftover-map
coordinates (ADR 0320). Comparison copy uses leftover map comparison
graphic leftover-map axis {axis} tick {value} so it stays distinct from
leftover-map axis {axis} tick {value} and from leftover map comparison
axis {axis} ({share}%). Origin and unique finite xi / zeta projections
only. Rank-0 origin cells still name leftover-map comparison graphic
leftover-map axis tick 0.00. Do not invent evenly spaced ticks.
Do not caption leftover-map singular values this increment.
Do not invent leftover-map coordinate ticks from leftover-map distance.
Never invent a leftover score. Never invent a theta. No new columns.
|
Cycle 2026-08-31T00:28Z. Exact head Frontend vitest: leftoverMapPlotLayout, LeftoverMapPlot, i18n, App — 520 passed. Oxlint on changed files: 0 warnings, 0 errors. Synthetic fixtures only. Next deferred increment (explicit in ADR 0320): leftover-map singular values on the grouping comparison leftover-map graphic. Never invent a leftover score. Never invent a theta. No new columns. |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
| aria-label={tf( | ||
| variant === "comparison" | ||
| ? LEFTOVER_MAP_COMPARE_PLOT_TICK | ||
| : LEFTOVER_MAP_PLOT_TICK, | ||
| { axis: tick.axis, value: tick.label }, | ||
| )} |
There was a problem hiding this comment.
🟡 Nearby coordinates lose comparison ticks
When distinct coordinates share a two-decimal label, layout.ticks contains only the first. The comparison graphic therefore omits a required coordinate tick.
Prompt for agents
ADR 0320 requires a tick at every unique finite persisted coordinate, but frontend/src/leftoverMapPlotLayout.ts uniqueCoordinateTicks deduplicates coordinates by their formatted two-decimal labels. Distinct values such as 0.001 and 0.002 collapse into one tick before LeftoverMapPlot renders the comparison labels. Preserve uniqueness by numeric coordinate while still using the shared formatter for display. Ensure React keys remain unique when multiple coordinates have the same displayed label, and add layout/component tests covering distinct same-label coordinates.
Was this helpful? React with 👍 or 👎 to provide feedback.
| aria-label={tf( | ||
| variant === "comparison" | ||
| ? LEFTOVER_MAP_COMPARE_PLOT_TICK | ||
| : LEFTOVER_MAP_PLOT_TICK, | ||
| { axis: tick.axis, value: tick.label }, | ||
| )} |
There was a problem hiding this comment.
📝 Info: Report tick names remain stable
The variant branch changes only comparison tick names. Existing report plots retain LEFTOVER_MAP_PLOT_TICK, and the production comparison caller supplies the required variant.
Was this helpful? React with 👍 or 👎 to provide feedback.
| export const LEFTOVER_MAP_COMPARE_PLOT_TICK = | ||
| "leftover map comparison graphic leftover-map axis {axis} tick {value}"; |
There was a problem hiding this comment.
📝 Info: Tick sources remain coordinate-bound
layoutLeftoverMapPlot still derives ticks only from finite persisted projections plus zero. Collapsed drawing scale adds no synthetic tick values.
Was this helpful? React with 👍 or 👎 to provide feedback.
| "name": "frontend", | ||
| "private": true, | ||
| "version": "2.76.0", | ||
| "version": "2.77.0", |
There was a problem hiding this comment.
🔍 Focused tests need CI confirmation
Local Corepack could not verify the pinned pnpm signature, so focused frontend tests never started. CI must confirm the rendering and translation suites.
Was this helpful? React with 👍 or 👎 to provide feedback.
seonghobae
added
enhancement
ChatGPT Codex Connector
1 participant
Caption persisted leftover-map coordinate ticks on the grouping comparison leftover-map graphic from already-named leftover-map coordinates (ADR 0320 / v2.77.0).
Stacked on #859 @
9ba8535. Independent APPROVE required on this exact head before squash-merge. Do not self-approve. Do not squash-merge onto the unprotected leftover base. Issues #79 and #87 stay open. Do not merge #808 without independent APPROVE.Comparison copy uses
leftover map comparison graphic leftover-map axis {axis} tick {value}so it stays distinct from hyphenleftover-map axis {axis} tick {value}and from comparison axis-shareleftover map comparison axis {axis} ({share}%). Ticks sit at the origin and at each unique finite persistedξ/ζprojection. Rank-0 origin cells still name leftover-map comparison graphic leftover-map axis tick0.00. Do not invent evenly spaced ticks that no persisted coordinate occupies. This increment does not caption leftover-map singular values on the comparison graphic with a distinct name. Do not invent leftover-map coordinate ticks from leftover-map distance. Never invent a leftover score. Never invent a theta. No new columns.Synthetic fixtures only.