-
Notifications
You must be signed in to change notification settings - Fork 1
feat(reports): leftover-map coordinate ticks on grouping comparison graphic (v2.77.0) #860
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
seonghobae
wants to merge
1
commit into
feat/leftover-map-compare-plot-distance-v2760
Choose a base branch
from
feat/leftover-map-compare-plot-ticks-v2770
base: feat/leftover-map-compare-plot-distance-v2760
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| ## 2.77.0 — Leftover-map coordinate ticks on grouping comparison leftover-map graphic | ||
|
|
||
| - Caption leftover-map coordinate ticks on the grouping comparison leftover-map | ||
| graphic (ADR 0320). After `make seed`, closest and farthest leftover pairs | ||
| sit above the member list with leftover-map coordinate ticks on that grouping | ||
| comparison leftover-map graphic at the origin and at each unique finite | ||
| persisted `ξ` / `ζ` projection; click a post marker or a pair button opens | ||
| that post. Rank-0 origin cells still name leftover-map comparison graphic | ||
| leftover-map axis tick `0.00`. Comparison copy uses | ||
| `leftover map comparison graphic leftover-map axis {axis} tick {value}` so it | ||
| stays distinct from `leftover-map axis {axis} tick {value}` and from | ||
| `leftover map comparison axis {axis} ({share}%)`. Do not invent evenly spaced | ||
| ticks that no persisted coordinate occupies. This increment does not caption | ||
| leftover-map singular values on the comparison graphic with a distinct name. | ||
| Do not invent leftover-map coordinate ticks from leftover-map distance. | ||
| A finite negative leftover is shown, never clamped. Never invent a leftover | ||
| score. Never invent a theta. No new columns. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,109 @@ | ||
| # ADR 0320 — Name leftover-map coordinate ticks on the grouping comparison leftover-map graphic | ||
|
|
||
| **Decision status:** Accepted | ||
| **Date:** 2026-08-31 | ||
|
|
||
| Amends leftover-map coordinate ticks on graphic-display axes | ||
| ([ADR 0270](0270-leftover-map-coordinate-ticks.md)), leftover-map distance | ||
| on the grouping comparison leftover-map graphic | ||
| ([ADR 0319](0319-leftover-map-compare-plot-distance.md)), leftover-map rank | ||
| on the grouping comparison leftover-map graphic | ||
| ([ADR 0318](0318-leftover-map-compare-plot-rank.md)), leftover-map graphic | ||
| display on the grouping comparison strip | ||
| ([ADR 0304](0304-leftover-map-compare-graphic.md)), leftover-map coordinates | ||
| ([ADR 0267](0267-leftover-map-coordinates.md)). Independent of leftover-map | ||
| singular values on the grouping comparison leftover-map graphic. | ||
|
|
||
| ## Context | ||
|
|
||
| ADR 0267 already persists two-axis Gabriel person coordinates | ||
| `ξ_{1:2}` and item coordinates `ζ_{1:2}` so `R̂ = ξ_{1:2} · ζ_{1:2}` | ||
| and `d = ‖ξ_{1:2} − ζ_{1:2}‖` stay auditable. ADR 0270 already ticks | ||
| period-report leftover-map axes at the origin and at each unique finite | ||
| persisted `ξ` / `ζ` projection under accessible name | ||
| `leftover-map axis {axis} tick {value}`. ADR 0319 already captions | ||
| leftover-map distance on the grouping comparison leftover-map graphic. | ||
| The comparison graphic still reuses `leftover-map axis {axis} tick {value}`, | ||
| so a buyer who compares leftover pairs can treat the period-report graphic | ||
| tick as the comparison graphic leftover-map coordinate even after the strip | ||
| names `ξ` / `ζ`. Hiding a distinct comparison-graphic leftover-map coordinate | ||
| tick lets leftover-map distance `d`, leftover-map rank, or leftover-map axis | ||
| share be read as leftover-map location without a next action. When | ||
| coordinates, reconstruction, and distance are finite, `R̂ = ξ · ζ` and | ||
| `d = ‖ξ − ζ‖`; the comparison graphic must name the same persisted | ||
| coordinates the pair row already shows. A finite negative leftover is shown, | ||
| never clamped. | ||
|
|
||
| This increment captions leftover-map coordinate ticks on the grouping | ||
| comparison leftover-map graphic from already-named leftover-map coordinates. | ||
| Comparison copy uses the accessible name | ||
| `leftover map comparison graphic leftover-map axis {axis} tick {value}` so it | ||
| stays distinct from `leftover-map axis {axis} tick {value}` on the | ||
| period-report graphic and from comparison axis-share copy | ||
| `leftover map comparison axis {axis} ({share}%)`. It does not add columns. | ||
| It does not invent evenly spaced ticks that no persisted coordinate occupies. | ||
| Do not invent a leftover score. Do not invent a theta. | ||
|
|
||
| This protected increment uses **0320** so it does not collide with leftover-map | ||
| distance on the grouping comparison leftover-map graphic (0319), leftover-map | ||
| rank on that graphic (0318), leftover-map coordinate ticks on pair-segment | ||
| graphic display (0270), leftover-map coordinates (0267), leftover-map graphic | ||
| display (0268), leftover-map axis share on that comparison graphic (0305), or | ||
| the dashboard stacks. | ||
|
|
||
| ## Decision | ||
|
|
||
| On the grouping comparison leftover-map graphic, tick leftover-map axis 1 and | ||
| leftover-map axis 2 at the origin and at each unique finite persisted `ξ` / | ||
| `ζ` coordinate projected onto that axis. Use the distinct accessible name | ||
| `leftover map comparison graphic leftover-map axis {axis} tick {value}` so the | ||
| graphic tick is not the period-report graphic tick | ||
| (`leftover-map axis {axis} tick {value}`) and is not comparison axis-share copy | ||
| (`leftover map comparison axis {axis} ({share}%)`). Tick labels use the same | ||
| signed leftover-map coordinate formatter as the pair-row badge. The origin is | ||
| always named `0` because it is the rank-0 unused-axis location, not a leftover | ||
| score. Duplicate coordinates share one tick. A rank-0 origin cell names only | ||
| `0`; the unit drawing window used to keep that origin visible is drawing scale | ||
| and must not sprout `−1` or `+1` ticks. Do not invent evenly spaced ticks that | ||
| no persisted coordinate occupies. Click a post marker to open that post. | ||
| Criterion markers are not post buttons. | ||
|
|
||
| Leftover-map comparison graphic leftover-map axis ticks omit independently of | ||
| leftover-map distance captions. A missing coordinate omits that leftover-map | ||
| comparison graphic leftover-map axis tick and keeps a usable leftover-map | ||
| distance caption, leftover-map rank caption, leftover expected `E`, leftover | ||
| observed `Y`, leftover residual `R`, leftover-map unexplained leftover `U`, | ||
| leftover-map reconstruction `R̂`, leftover-map comparison graphic coverage | ||
| notes, plus the pair-row leftover-map coordinate badge. | ||
|
|
||
| This increment does not caption leftover-map singular values on the comparison | ||
| graphic with a distinct comparison-graphic name. Those leftover singular values | ||
| already persist on leftover-map axes through ADR 0148. | ||
|
|
||
| Do not add SQL migrations. Do not edit shipped migrations. Do not invent a leftover | ||
| score. Do not invent a theta. | ||
|
|
||
| ## Consequences | ||
|
|
||
| After `make seed`, grouping comparison leftover pairs that already show | ||
| the leftover-map graphic of persisted `ξ` / `ζ` also name leftover-map | ||
| coordinate ticks on that graphic at the origin and at each unique finite | ||
| projection. Rank-0 unused axes still plot at the origin and still name | ||
| leftover-map comparison graphic leftover-map axis tick `0.00`. Click a post | ||
| marker or a pair button opens that post. When coordinates, reconstruction, | ||
| and distance are finite, `R̂ = ξ · ζ` and `d = ‖ξ − ζ‖`. | ||
|
|
||
| ## Related | ||
|
|
||
| Independent of leftover-map singular values on the grouping comparison leftover-map graphic. | ||
|
|
||
| ## References | ||
|
|
||
| Jeon, M., Jin, I. H., Schweinberger, M., & Baugh, S. (2021). Mapping | ||
| unobserved item–respondent interactions: A latent space item response | ||
| model with interaction map. *Psychometrika, 86*(2), 378–403. | ||
| https://doi.org/10.1007/s11336-021-09762-5 | ||
|
|
||
| Gabriel, K. R. (1971). The biplot graphic display of matrices with | ||
| application to principal component analysis. *Biometrika, 58*(3), | ||
| 453–467. https://doi.org/10.1093/biomet/58.3.453 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔍 Focused tests need CI confirmation
Local Corepack could not verify the pinned pnpm signature, so focused frontend tests never started. CI must confirm the rendering and translation suites.
Was this helpful? React with 👍 or 👎 to provide feedback.