Skip to content

feat(reports): leftover-map distance on grouping comparison graphic (v2.76.0) - #859

Draft
seonghobae wants to merge 1 commit into
feat/leftover-map-compare-plot-rank-v2750from
feat/leftover-map-compare-plot-distance-v2760
Draft

feat(reports): leftover-map distance on grouping comparison graphic (v2.76.0)#859
seonghobae wants to merge 1 commit into
feat/leftover-map-compare-plot-rank-v2750from
feat/leftover-map-compare-plot-distance-v2760

Conversation

@seonghobae

@seonghobae seonghobae commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Caption persisted leftover-map distance d on the grouping comparison leftover-map graphic from already-named leftover_distance (ADR 0319 / v2.76.0).

Stacked on #858 @ 4b9184f. Independent APPROVE required on this exact head before squash-merge. Do not self-approve. Do not squash-merge onto the unprotected leftover base. Issues #79 and #87 stay open. Do not merge #808 without independent APPROVE.

Comparison copy uses leftover map comparison graphic leftover-map distance {label} so it stays distinct from hyphen leftover-map distance {label}. A missing or non-finite d omits that caption and keeps leftover-map rank. Rank-0 origin cells still name d 0.00 when that persisted leftover-map distance is finite. This increment does not caption leftover-map coordinate ticks on the comparison graphic with a distinct name. Do not invent leftover-map distance from plotted coordinates. Never invent a leftover score. Never invent a theta. No new columns.

Synthetic fixtures only.


Devin Review

…v2.76.0)

Caption persisted leftover-map distance d on the grouping
comparison leftover-map graphic from already-named leftover_distance
(ADR 0319). Comparison copy uses leftover map comparison graphic leftover-map
distance {label} so it stays distinct from leftover-map distance {label}.
A missing or non-finite d omits that caption and keeps leftover-map rank,
leftover expected, leftover observed, leftover residual, leftover-map unexplained leftover,
leftover-map reconstruction, and comparison graphic coverage notes.
Rank-0 origin cells still name d 0.00 when that leftover-map distance is finite.
Do not caption leftover-map coordinate ticks this increment.
Do not invent leftover-map distance from plotted coordinates. Never invent a leftover score.
Never invent a theta. No new columns.
@coderabbitai

coderabbitai Bot commented Aug 31, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 0ef8cf30-0468-418f-a043-8b68e9dcc1f0

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copy link
Copy Markdown
Contributor Author

Exact head 9ba8535 stacked on #858 @ 4b9184f. Comparison graphic leftover-map distance uses leftover map comparison graphic leftover-map distance {label} so it stays distinct from hyphen leftover-map distance {label}. Independent APPROVE required on this leftover-map distance increment before squash-merge. Do not self-approve. Do not squash-merge onto the unprotected leftover base. Issues #79 and #87 stay open. Next buyer increment is leftover-map coordinate ticks on this comparison graphic (ADR 0320 / v2.77.0).

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

Copy link
Copy Markdown
Contributor Author

Cycle 2026-08-31T00:18Z. Exact head 9ba8535 (v2.76.0 / ADR 0319 leftover-map distance on grouping comparison leftover-map graphic). Independent APPROVE required on this exact head before squash-merge. Copilot/Devin COMMENT is not independent APPROVE. Do not self-approve. Do not squash-merge onto the unprotected leftover base. Issues #79 and #87 stay open. Do not merge #808 without independent APPROVE.

Next buyer increment (explicitly deferred in ADR 0319): leftover-map coordinate ticks on the grouping comparison leftover-map graphic with a distinct comparison-graphic accessible name (ADR 0320 / v2.77.0), stacked on this head. Period-report ticks already sit through ADR 0270. Do not invent leftover-map distance from plotted coordinates. Never invent a leftover score. Never invent a theta. No new columns. Synthetic fixtures only.

Copy link
Copy Markdown
Contributor Author

Cycle 2026-08-31T00:28Z. Exact head 9ba8535 (v2.76.0 / ADR 0319). Independent APPROVE still required. Stacked next increment is #860 leftover-map coordinate ticks on grouping comparison leftover-map graphic (v2.77.0 / ADR 0320) @ 40fa5bd. Do not self-approve. Do not squash-merge. Issues #79 and #87 stay open. Do not merge #808 without independent APPROVE.

@seonghobae
seonghobae marked this pull request as draft September 4, 2026 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant