Skip to content

feat(reports): leftover-map explained leftover share on grouping comparison graphic (v2.68.0) - #851

Draft
seonghobae wants to merge 4 commits into
feat/leftover-map-compare-plot-reconstruction-v2670from
feat/leftover-map-compare-plot-explained-share-v2680
Draft

feat(reports): leftover-map explained leftover share on grouping comparison graphic (v2.68.0)#851
seonghobae wants to merge 4 commits into
feat/leftover-map-compare-plot-reconstruction-v2670from
feat/leftover-map-compare-plot-explained-share-v2680

Conversation

@seonghobae

@seonghobae seonghobae commented Aug 30, 2026

Copy link
Copy Markdown
Contributor

Summary

Caption persisted leftover-map explained leftover share e on the grouping-comparison leftover-map graphic when formatLeftoverMapExplainedShare returns a usable badge (ADR 0311 / v2.68.0). It omits independently from reconstruction, distance, and coverage. No SQL/new columns; never derive e from neighbouring statistics.

Live authority

  • parent/base: #850@40a6b04c1a1fe81dbb6297aadea9158b9b644955
  • current product head: 72df615a8fb1350217039c6a62007243a6322ccc
  • PR: open / Draft

Parent convergence

#851 inherited the ADR-governance regression as 74e22f0bb62997fad1bb4f978b9a50addaa1d49c. GitHub generated exact current-parent merge 041c6d059a347d5683df84b96deca72589add23f, verified with parents #850@40a6b04c... and #851@74e22f0b...; its tree keeps ADR 0311/v2.68.0 and ADR 0304 Proposed. That tree was recorded child-first as 72df615a..., and the branch moved by non-force fast-forward only.

Historical 799 frontend tests/oxlint/py_compile evidence predates this exact head and is not transferred. Exact-head required/frontend/browser/a11y, PostgreSQL/k6 evidence, and independent approval remain outstanding. Direct descendants must be reconstructed before predecessor evidence transfers.

Product invariants

  • Missing/non-finite e omits only its graphic caption and preserves usable reconstruction/distance/coverage captions.
  • Finite zero remains displayable; no synthetic share or clamping.
  • This increment does not add unexplained-share captioning.

Keep Draft until exact-head evidence and independent approval exist. No self-approval, gate bypass, force push, or destructive rebase.

…arison graphic (v2.68.0)

Caption persisted leftover-map explained leftover share e on the grouping
comparison leftover-map graphic from already-named leftover_map_explained_share
(ADR 0311). Comparison copy uses leftover map comparison graphic explained
leftover share {label} so it stays distinct from hyphen leftover-map explained
leftover share {label} and from strip Leftover map comparison explained leftover
share. A missing or non-finite e omits that caption and keeps leftover-map
reconstruction and comparison graphic coverage notes. Rank-0 origin cells still
name R̂²/R² 0.00 when that explained leftover share is finite. Do not invent e
from leftover-map reconstruction or leftover residual. Never invent a leftover
score. Never invent a theta. No new columns.
@coderabbitai

coderabbitai Bot commented Aug 30, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copy link
Copy Markdown
Contributor Author

Queue retry: leftover-map explained leftover share on grouping comparison graphic (v2.68.0 / ADR 0311). Independent APPROVE required before squash-merge. Do not self-approve. Next stacked increment is leftover-map unexplained leftover share on that comparison graphic. Issues #79 and #87 stay open. #96 is already closed.

Copy link
Copy Markdown
Contributor Author

Cycle retry 2026-08-31 06:40 KST: exact head 2d6e8e7 still has no independent APPROVE (CodeRabbit skipped on non-default base). Copilot review requested this cycle. Leave #851 open. Do not self-approve. Do not squash-merge onto the unprotected leftover base. After independent review, retarget onto leftover-coordinates (#782, already on main) rather than squash-merging here.

Next stacked increment (ADR 0312 / v2.69.0) captions leftover-map unexplained leftover share on the grouping comparison leftover-map graphic with distinct accessible name leftover map comparison graphic unexplained leftover share {label}. It does not caption leftover-map unexplained leftover U this increment. Stack onto this PR; leave that PR open for independent review. Issues #79 and #87 stay open.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 potential issue.

Devin Review

Comment thread pyproject.toml
[project]
name = "lineageweave"
version = "2.67.0"
version = "2.68.0"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Version bump leaves frozen lock stale

The version bump declares 2.68.0, but the frozen lock still identifies lineageweave as 2.65.0. Frozen installs can fail or package the old release.

Prompt for agents
Regenerate uv.lock from the updated pyproject.toml so the local lineageweave package entry records version 2.68.0. Verify the repository's frozen CI sync and backend Docker installation succeed with the refreshed committed lock.
Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

Copy link
Copy Markdown
Contributor Author

Cycle 2026-08-31T06:40 KST: retrying GitHub writes (close/merge/comment/push). Head 2d6e8e7 v2.68.0 leftover-map explained leftover share on grouping comparison graphic. Not self-approving. Independent APPROVE required before squash-merge.

Copy link
Copy Markdown
Contributor Author

Stacked next increment opened as #852 (feat/leftover-map-compare-plot-unexplained-share-v2690 @ 2c34896, ADR 0312 / v2.69.0). Leave #851 open for independent review. Exact head 2d6e8e7 still has no independent APPROVE. Do not self-approve. Do not squash-merge.

Copy link
Copy Markdown
Contributor Author

Stacked #852 leftover-map unexplained leftover share on grouping comparison graphic (v2.69.0 / ADR 0312) is open on this head. Independent APPROVE required. Do not self-approve. Do not squash-merge onto the unprotected leftover base.

@seonghobae
seonghobae marked this pull request as draft September 4, 2026 08:06
Adopt the conflict-free GitHub test-merge tree for exact parent #850 e14d7e0 while preserving existing #851 product head 2d6e8e7 as first-parent ancestry. No force push and no product delta is dropped.
seonghobae added a commit that referenced this pull request Sep 6, 2026
Adopt the conflict-free GitHub test-merge tree for exact parent #851 89fe034 while preserving existing #852 product head 2c34896 as first-parent ancestry. No force push and no product delta is dropped.
Adopt the GitHub-verified conflict-free merge tree for exact parent #85040a6b04 and child 74e22f0. The tree preserves ADR 0311/v2.68.0 and inherits ADR 0304 Proposed plus its regression. No force push and no valid delta is dropped.
seonghobae added a commit that referenced this pull request Sep 6, 2026
Adopt the GitHub-verified conflict-free merge tree for exact parent #85172df615 and child ed6502e. The tree preserves ADR 0312/v2.69.0 and inherits ADR 0304 Proposed plus its regression. No force push and no valid delta is dropped.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant