feat(reports): leftover-map axis share on grouping comparison graphic (v2.62.0) - #844
Conversation
… (v2.62.0)
Return persisted leftover-map axes on GET /api/reports/compare/{period}
and caption leftover-map axis share on the grouping comparison leftover-map
graphic when finite (ADR 0305). Comparison copy stays distinct from hyphen
leftover-map axis share on the period-report graphic. Rank-0 unused axes
still name zero leftover-map axis share. Do not invent leftover-map axis
share from leftover-map rank, leftover-map distance, or leftover-map
reconstruction. Never invent a leftover score. Never invent a theta.
|
Cycle overlay 2026-08-31 03:55 KST. Writes work. Do not self-approve. Do not squash-merge.
Independent approval is required. No self-approval, admin bypass, or force push. |
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
|
Cycle retry 2026-08-31T04:10KST: leftover-map axis share on the grouping comparison graphic (ADR 0305 / v2.62.0) remains open for independent review. Next buyer gap is leftover-map complete-case coverage on that same comparison graphic (deferred in this PR). Do not self-approve. Do not squash onto the unprotected leftover base. |
|
write-probe cycle 2026-08-31 leftover-map coverage next |
|
Cycle retry 2026-08-31T04:10+09:00. GitHub writes succeed (comment + PR read). Head remains Next buyer gap: leftover-map complete-case coverage on the grouping comparison leftover-map graphic (ADR 0306 / v2.63.0), deferred by ADR 0305. Will stack |
|
Exact head |
|
Cycle 2026-08-31 04:23 KST. Writes work as seonghobae. Exact head Next buyer gap is stacking leftover-map complete-case coverage on this grouping comparison leftover-map graphic (ADR 0306 / v2.63.0) as |
seonghobae
left a comment
seonghobae
left a comment
There was a problem hiding this comment.
Parent-convergence finding: this PR body/base metadata still referenced obsolete #841 ee467df2..., while the live parent branch is 98e2915b2aee3be7decbd74460fefccde667404d. The base has been refreshed to the current #841 branch and GitHub now correctly reports a conflict. Compare is ahead 1 / behind 30 from merge base ee467df2.... Preserve the one-commit ADR 0305/v2.62.0 grouping-comparison graphic axis-share delta, but reconstruct it non-force only after #841's premature ADR-0304 Accepted state is repaired. Do not use the stale merge ref/checks, drop current-parent changes, or force-rebase.
seonghobae
left a comment
seonghobae
left a comment
There was a problem hiding this comment.
Exact-head Tests 34004997965 confirms the current failures are inherited from parent #841 rather than defects in this v2.62 axis-share-on-graphic delta. Frontend reproduces the same three foundation failures: small-canvas caption escapes above 20px (labelY=-20), Vietnamese explained-share copy has regressed to phần dư giải thích..., and the Vietnamese regression duplicates the pre-coverage English caption instead of importing production LEFTOVER_MAP_PLOT_CAPTION. The full PostgreSQL/Python suite reached 1766 passed / 147 skipped / 1 failed; the only failure is runtime provenance (lineageweave.__version__ == 2.41.0 vs package/frontend 2.62.0). Repair these once in #841, not again here. Keep this valid ADR0305/v2.62 child Draft; after #841 moves, reconstruct #844 non-force from the repaired exact parent and then converge #845 and all descendants in order.
seonghobae
added
enhancement
ChatGPT Codex Connector
1 participant
Summary
Return persisted leftover-map axes on
GET /api/reports/compare/{period}and caption persisted axis share on the grouping-comparison leftover-map graphic when finite (ADR 0305 / v2.62.0). No SQL/new columns; never derive share from rank, distance, residual/reconstruction, coverage, pair count, or unused-axis count.Live authority
#841@87979568b36219ae99631e88f32d0af1a92479230882cc90a1af545d9d67e0965134c7686a1196718d37896a5246cd0045a9c210b504b95941a78f84Parent convergence
#841 added the executable ADR-governance regression and changed ADR 0304 from
AcceptedtoProposed. This child inherited that repaired authority while preserving its own ADR 0305/v2.62.0 delta. The final two-parent commit0882cc90...records current #841 as parent; no force rewrite occurred.Exact-head Tests RED is inherited from #841
Required Tests
34004997965is terminal failure on this exact child head. Review5124070192confirms the failures reproduce the same foundation defects already present on #841 rather than an axis-share-on-graphic regression:labelY=-20instead of>=12;phần dư giải thích..., and the regression duplicates the pre-coverage English caption instead of importing productionLEFTOVER_MAP_PLOT_CAPTION;lineageweave.__version__ == 2.41.0while pyproject/frontend are 2.62.0).These defects are being repaired once at canonical parent #841. Do not duplicate the same patch locally. When #841 obtains a verified clean repair and its product head moves, reconstruct this valid child non-force from that exact repaired parent, preserving ADR 0305/v2.62.0, then converge #845 and the remaining descendant stack in order. Existing GREEN from any predecessor does not transfer.
Product invariants
Keep Draft until the foundation repair is inherited, exact-product-head required/frontend/browser/a11y evidence is fresh, and qualifying independent approval exists. No self-approval, gate bypass, force push, destructive rebase, or predecessor-check transfer.