feat(reports): preserve unexplained-leftover comparison delta pending successor verification - #832
Draft
seonghobae wants to merge 1 commit into
Conversation
…on strip (v2.54.0) Caption persisted leftover-map unexplained leftover U = R − R̂ on grouping comparison leftover-pair buttons through formatLeftoverMapUnexplained (ADR 0297). Distinct aria-label Leftover map comparison unexplained leftover. Missing or non-finite U omits that badge and keeps x, s, e, R̂, d, and coverage notes. Do not invent U from R and R̂. Rank-0 origin cells still name U 0.00 when finite. Finite negative leftover is shown, never clamped. UI-only; no new columns.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This was referenced Aug 30, 2026
feat(reports): preserve grouping-comparison unexplained-leftover delta for serialized successor
#833
Draft
seonghobae
changed the title
seonghobae
marked this pull request as draft
September 7, 2026 08:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recovery status
This PR was closed unmerged while its valid grouping-comparison unexplained-leftover
Udelta was not yet proven to be fully inherited by a verified successor. Reopened under the no-drop rule. Do not merge this historical head or write new product source here; it is a recovery/evidence lane until the serialized successor proves complete inheritance.Historical head
1511166c53c16fef65f3330eee58d3a5664b1583is one commit over historical #831 base2cefc0b63436989210bca3204e7750e87edba662. It introduced the persisted-Ucomparison presentation contract, helper/i18n/App tests, ADR0297 evidence, release metadata, and a generated-lock version update. Its ADR0297/v2.54.0 identity is historical and collides with the current serialized stack; do not promote it.Successor verification finding
#833 is the intended live successor for the same product behavior, but commit ancestry alone does not contain this head:
1511166c…and #833 feature origin18d89b49…are sibling commits over the same2cefc0b…parent. Their helper tests are nearly equivalent, but this head also carries an explicit assertion thatLEFTOVER_MAP_COMPARE_UNEXPLAINED_LABELmust not regress to the unexplained-share label, and it updated the generateduv.lockproject version. Those valid test/lock invariants must be explicitly inherited or equivalently proven in the reconstructed #833 before this recovery PR can be closed again.#833 itself must wait behind the current serialized sequence #828 → #829 → #830 → #831, allocate a collision-free ADR/release identity, preserve
Ufinite/missing/non-finite/negative/zero semantics, preserve the distinct comparison-label contract, regenerate rather than hand-edit the lock when its project version changes, and inherit the current accessible-name repair. The broaderLeftoverPairListaccessible-name defect is tracked separately in #976.Close criterion
Close this PR only after the exact reconstructed #833 successor demonstrates all valid source behavior, focused/edge tests including label non-confusion, fixture/contract/evidence inheritance, correctly regenerated lock/version parity, and current-parent GREEN. Until then this remains Draft recovery authority, not a competing source writer.
No force-push, destructive rebase, self-approval, gate weakening, source duplication, or psychometric recomputation.