feat(reports): preserve grouping-comparison residual delta for serialized successor - #835
Conversation
Caption leftover residual R on grouping comparison leftover-pair buttons through formatLeftoverMapResidual (ADR 0298). After make seed, closest and farthest leftover pairs sit above the member list with the Gabriel biplot of already-named coordinates and grouping comparison leftover-pair buttons that match R on the pair row; click a post marker or a pair button opens that post. A missing or non-finite R omits that leftover-map comparison residual badge and keeps leftover-map unexplained leftover U when finite. A finite negative leftover is shown, never clamped. Do not invent R from Y and E or from U and R̂. UI-only; no new columns. Never invent a leftover score or a theta. Jeon, M., Jin, I. H., Schweinberger, M., & Baugh, S. (2021). Mapping unobserved item-respondent interactions: A latent space item response model with interaction map. Psychometrika, 86(2), 378-403. Gabriel, K. R. (1971). The biplot graphic display of matrices with application to principal component analysis. Biometrika, 58(3), 453-467.
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Cycle 2026-08-31 01:35 KST. Head Leave this PR open. Do not squash-merge onto the unprotected leftover base (#833). Do not self-approve. After independent review, retarget onto leftover-coordinates ( Parallel residual #834 on #832 is a competing stack of the same buyer gap; leave both open. Next increment on this head: leftover observed |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
| const unexplainedLeftover = formatLeftoverMapUnexplained( | ||
| pair.leftover_map_unexplained, | ||
| ); | ||
| const residual = formatLeftoverMapResidual(pair.leftover_residual); |
There was a problem hiding this comment.
📝 Info: Residual remains persisted evidence
formatLeftoverMapResidual reads the comparison payload directly. Missing or non-finite residuals omit only this badge, preserving neighboring measurements.
Was this helpful? React with 👍 or 👎 to provide feedback.
| export const LEFTOVER_MAP_COMPARE_RESIDUAL_LABEL = | ||
| "Leftover map comparison residual"; |
There was a problem hiding this comment.
📝 Info: Signed residual values remain intact
The finiteness gate retains zero and negative residuals. Formatting matches the existing pair-row badge without clamping.
Was this helpful? React with 👍 or 👎 to provide feedback.
|
Cycle 2026-08-31 01:42 KST. Head |
seonghobae
added
enhancement
ChatGPT Codex Connector
seonghobae
changed the title
1 participant
Summary
Preserve the valid grouping-comparison persisted leftover residual
Rdelta while the serialized report stack is repaired. Missing/non-finiteRomits only that badge; finite zero and negative values remain explicit and are never clamped. UI/read-model composition only: no SQL, new measurement authority, theta, or invented score.Current stack / identity authority
Historical ADR0298/v2.55.0 is evidence only. Exact current #827 is v2.53.0, #828 is reconstructing its immediate successor as v2.54.0, and #829 is the next valid serialized delta. Keeping this branch's old v2.55.0 title as current authority would collide with the repairing chain. Allocate an unclaimed ADR/release identity only after #828→#829→#830→#831 and the canonical unexplained-leftover predecessor have converged.
Closed #834 is an unmerged competing implementation of the same residual buyer gap; do not reopen or duplicate its stale stack merely because it is closed. Preserve whichever valid source/test/evidence delta is not already inherited here when reconstructing the successor, and document exact succession before treating #834 as fully superseded.
Product invariants
Romits only the grouping-comparison residual badge; finite zero and negative values remain explicit.RfromY-E,UandR̂, distance, plotted coordinates, reconstruction, shares, rank, coverage counts, or unused-axis count.aria-label.UI / evidence boundary
Canonical KO/EN/JA/ZH/VI/ES/DE/FR translation authority remains #922/#929/#932; historical inline locale strings are compatibility evidence only. Keep Draft until current-parent reconstruction, exact-head repository/security checks, Storybook/browser/keyboard/focus/a11y evidence, translation-ledger convergence, applicable authenticated PostgreSQL/k6 acceptance, and qualifying independent review are current. No self-approval, bypass, force-push, or gate weakening.
Jeon, M., Jin, I. H., Schweinberger, M., & Baugh, S. (2021). Mapping unobserved item–respondent interactions: A latent space item response model with interaction map. Psychometrika, 86(2), 378–403.
Gabriel, K. R. (1971). The biplot graphic display of matrices with application to principal component analysis. Biometrika, 58(3), 453–467.