feat(reports): preserve grouping-comparison coordinates delta for serialized successor - #839
Draft
seonghobae wants to merge 2 commits into
Draft
Conversation
…(v2.59.0) Caption leftover-map coordinates ξ / ζ on grouping comparison leftover-pair buttons through formatLeftoverMapCoordinates (ADR 0302). After make seed, closest and farthest leftover pairs sit above the member list with the Gabriel biplot of already-named coordinates and grouping comparison leftover-pair buttons that match ξ (x, y) ζ (x, y) on the pair row; click a post marker or a pair button opens that post. A missing or non-finite axis omits that leftover-map comparison coordinates badge and keeps leftover-map rank when that rank is a non-negative integer. Rank-0 origin cells still name ξ (0.00, 0.00) ζ (0.00, 0.00). Do not invent coordinates from leftover-map rank, leftover-map distance, or leftover-map reconstruction. UI-only; no new columns. Never invent a leftover score or a theta. Jeon, M., Jin, I. H., Schweinberger, M., & Baugh, S. (2021). Mapping unobserved item-respondent interactions: A latent space item response model with interaction map. Psychometrika, 86(2), 378-403. Gabriel, K. R. (1971). The biplot graphic display of matrices with application to principal component analysis. Biometrika, 58(3), 453-467.
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
Author
Cycle overlay 2026-08-31 02:25 KSTWrites work (
Independent approval is required. No self-approval, admin bypass, or force push. |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Comment on lines
+4119
to
+4124
| const coordinates = formatLeftoverMapCoordinates( | ||
| pair.leftover_map_person_axis_1, | ||
| pair.leftover_map_person_axis_2, | ||
| pair.leftover_map_item_axis_1, | ||
| pair.leftover_map_item_axis_2, | ||
| ); |
There was a problem hiding this comment.
🟡 Coordinates absent from live comparisons
For live responses, formatLeftoverMapCoordinates receives undefined axes because fetch_period_comparison omits all four persisted coordinates. Every coordinate badge disappears outside mocked tests.
Prompt for agents
The grouping comparison UI in frontend/src/App.tsx reads leftover_map_person_axis_1, leftover_map_person_axis_2, leftover_map_item_axis_1, and leftover_map_item_axis_2, but backend/app/report_ingestion.py fetch_period_comparison does not select or serialize those columns. Extend that comparison query and its leftover_pairs payload to return the four persisted coordinate values, preserving nulls and converting finite database numerics consistently with the detailed report payload. Add an API-level comparison test that verifies real response coordinates, not only a mocked frontend response.
Was this helpful? React with 👍 or 👎 to provide feedback.
Comment on lines
+4119
to
+4124
| const coordinates = formatLeftoverMapCoordinates( | ||
| pair.leftover_map_person_axis_1, | ||
| pair.leftover_map_person_axis_2, | ||
| pair.leftover_map_item_axis_1, | ||
| pair.leftover_map_item_axis_2, | ||
| ); |
There was a problem hiding this comment.
📝 Info: Formatter fail-closes independently
formatLeftoverMapCoordinates rejects any missing or non-finite axis while preserving zero and signed finite values. It never derives coordinates from neighboring measurements.
Was this helpful? React with 👍 or 👎 to provide feedback.
Contributor
Author
|
Cycle overlay 2026-08-31 02:35 KST: leftover-map coordinates |
seonghobae
marked this pull request as draft
September 4, 2026 08:07
seonghobae
added
enhancement
ChatGPT Codex Connector
seonghobae
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Preserve the valid grouping-comparison persisted leftover-map coordinates
ξ/ζdelta while the serialized report stack is repaired. Missing/non-finite coordinates omit only that badge; finite origin coordinates remain explicit. UI/read-model composition only: no SQL/schema, theta authority, or invented score.Current stack authority
GitHub base metadata points to immediate predecessor #838 (
feat/leftover-map-compare-rank-v2580@3d40d04db30e54138efb6f734b47e72965093572). #838 now waits on reconstructed #837 and the repaired predecessor chain. Historical ADR0302/v2.59.0 and its focused validation are evidence only, not current release authority.Reconstruct the coordinates delta only after exact promoted #838, allocate the then-next unclaimed ADR/release identity, and keep it Proposed while Draft. The historical instruction to retarget directly to #782 is superseded because it would bypass valid serialized predecessors.
Product invariants
Evidence boundary
Historical focused frontend evidence was 361 passing tests plus oxlint success, but it predates current-parent reconstruction and does not transfer. Canonical KO/EN/JA/ZH/VI/ES/DE/FR translation authority remains #922/#929/#932. Keep Draft until realistic current-parent RED, causal repair, exact-head backend/frontend GREEN, lint/build/Storybook, applicable browser/responsive/keyboard/focus/a11y evidence, translation-ledger convergence, applicable authenticated PostgreSQL/k6 acceptance, and qualifying independent approval are current. No self-approval, bypass, force-push, destructive rebase, or ancestor skip.
Jeon, M., Jin, I. H., Schweinberger, M., & Baugh, S. (2021). Mapping unobserved item–respondent interactions: A latent space item response model with interaction map. Psychometrika, 86(2), 378–403.
Gabriel, K. R. (1971). The biplot graphic display of matrices with application to principal component analysis. Biometrika, 58(3), 453–467.