Skip to content

fix(voice): distinguish carrying and evidence exports - #780

Open
seonghobae wants to merge 67 commits into
mainfrom
fix/voice-export-authority-20260828
Open

fix(voice): distinguish carrying and evidence exports#780
seonghobae wants to merge 67 commits into
mainfrom
fix/voice-export-authority-20260828

Conversation

@seonghobae

@seonghobae seonghobae commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

Summary

Repairs Voice-of-X export authority. Exact-value CSV distinguishes the carrying Post from derivation-evidence Post, ADR 0251/0256 ownership is reconciled, and historical frontend/browser observations remain predecessor evidence after branch movement.

Protected-main convergence

Review 5116306008 found this branch anchored on the pre-#931 protected line. Commit 1d8fa267b059289e77301a09985dfac70a439814 adopted the exact protected Tests/PROV-O/Ontology Draft-admission workflows plus tests/test_tests_workflow_contract.py and joined the repaired product tree to protected main@83eba56149eb802cd63642c507c324c9976ec78e without rewriting the Voice/export delta.

Exact live boundary

  • protected base: main@83eba56149eb802cd63642c507c324c9976ec78e
  • exact head: 1d8fa267b059289e77301a09985dfac70a439814
  • PR: open / Ready / mechanically mergeable; Ready is validation admission, not merge readiness
  • Ready-trigger Tests 33952504686: success; Frontend 101269793625 and Full suite 101269793798: success
  • Ready-trigger Ontology Pages 33952504679: ontology validation 101269793684 success; publish job correctly skipped on PR
  • fresh exact-head check inventory still contains no new Ready-trigger Security/SAST/CodeQL required runs; only the earlier Draft-state central executions exist, so they are not current Ready-state terminal GREEN evidence
  • no qualifying current-head APPROVED review; normal merge remains unavailable

The missing central Ready-transition executions are a workflow-lifecycle/control-plane defect, not a LineageWeave source result. This exact canary was already handed to the canonical .github owner path; do not replace it with local scans, synthetic statuses, a no-op head churn, or gate weakening. The separate central dispatcher-identity defect (opencode-agent[bot] versus the stale single-entry organization allowlist) is tracked in .github#1927, but that does not retroactively create the absent #780 Ready-trigger central runs.

Direct descendants remain stacked on this parent. #901 is no longer intentionally RED: its stale ADR 0134 StatusNotice baseline row was repaired in isolated GREEN run 34007470247 and clean product commit 308ebdfae50606127316fa8c51d772ea93327f64; because #901 remains Draft, that child evidence does not transfer to this parent. #934 and #936 remain Draft. #937 retains the post-write reauthorization rollback repair on its own Draft head; child tests and evidence do not transfer to this parent.

This parent remains the active validation lane for the Voice/export stack. Keep descendants stacked until normal protected integration; predecessor/child checks and approvals do not transfer. Do not self-approve, bypass required governance, force-push, or treat cancelled/skipped evidence as merge-ready.

@seonghobae
seonghobae enabled auto-merge (squash) August 28, 2026 03:00
@coderabbitai

coderabbitai Bot commented Aug 28, 2026

Copy link
Copy Markdown

Review Change Stack

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 83db76f0-e8e1-4c4a-8fe9-ae38c61526a9

📥 Commits

Reviewing files that changed from the base of the PR and between ddcc473 and cfe7a42.

📒 Files selected for processing (1)
  • docs/product-technical-gap-baseline.md
🚧 Files skipped from review as they are similar to previous changes (1)
  • docs/product-technical-gap-baseline.md

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

Voice 할당 CSV가 carrying_post_idderivation_evidence_post_id를 제공합니다. Voice 조합 문서는 ADR 0256을 참조합니다. 관련 테스트와 감사 기준선을 갱신합니다.

Changes

Voice 조합 정합성

Layer / File(s) Summary
Voice 할당 CSV 식별 열 추가
frontend/src/ontologyLayout.ts, frontend/src/ontologyLayout.test.ts
neighborhoodCsv의 열 순서를 변경합니다. Voice 할당 행은 evidence_post_id, carrying_post_id, derivation_evidence_post_id를 구분하여 출력합니다. 테스트는 헤더, 행 값, 기본 Voice의 중복 증거 ID 방지를 검증합니다.
Voice 조합 ADR 참조 정렬
docs/voice-combination-technical-requirements.md, docs/adr/0252-temporal-primary-voice-history.md, docs/adr/README.md, docs/storybook-inventory.md, tests/test_voice_authority_contract.py
Voice 조합 문서와 Storybook 인벤토리가 ADR 0256을 참조합니다. 새 테스트가 ADR 0251 참조의 부재와 ADR 0256 참조를 검증합니다.
감사 기준선 갱신
docs/product-technical-gap-baseline.md
감사 기준선에 최신 main 헤드, 14개 open PR 상태와 16:46 KST queue-audit 결과를 기록합니다. PR #782와 stacked child #783의 검증 상태도 기록합니다.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to cfe7a

The change adds explicit carrying and derivation-evidence CSV fields while preserving compatibility and updating related authority documentation and metadata; no actionable merge-blocking risk remains beyond normal checks and review.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 66.67% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 3 files. (1 skipped: 1… Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed 제목은 carrying 및 evidence export를 구분하는 주요 변경 사항을 정확하고 간결하게 설명합니다.
Full details: Docstring Coverage

Explanation

Docstring coverage is 66.67% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 3 files. (1 skipped: 1 unsupported.)

  • Fix all pre-merge checks with AI
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/voice-export-authority-20260828

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

devin-ai-integration[bot]

This comment was marked as resolved.

chatgpt-codex-connector[bot]

This comment was marked as resolved.

coderabbitai[bot]

This comment was marked as resolved.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@opencode-agent
opencode-agent Bot disabled auto-merge August 28, 2026 04:06
…ority-20260828

# Conflicts:
#	docs/product-technical-gap-baseline.md
#	uv.lock
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

devin-ai-integration[bot]

This comment was marked as resolved.

@seonghobae
seonghobae enabled auto-merge (squash) August 28, 2026 04:10
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

devin-ai-integration[bot]

This comment was marked as resolved.

@opencode-agent
opencode-agent Bot disabled auto-merge August 28, 2026 05:23
@seonghobae
seonghobae enabled auto-merge (squash) August 28, 2026 05:23
coderabbitai[bot]

This comment was marked as resolved.

Signed-off-by: Codex <codex@localhost>

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note

This report is out of date. Scroll down for Devin Review's latest report on this PR.

Devin Review found 0 new potential issues.

Devin Review

Signed-off-by: Codex <codex@localhost>

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note

This report is out of date. Scroll down for Devin Review's latest report on this PR.

Devin Review found 0 new potential issues.

Devin Review

Signed-off-by: Codex <codex@localhost>
devin-ai-integration[bot]

This comment was marked as resolved.

devin-ai-integration[bot]

This comment was marked as resolved.

Signed-off-by: Codex <codex@localhost>
@opencode-agent
opencode-agent Bot disabled auto-merge August 28, 2026 12:34
Merge protected main@3f61c824 into the voice export root without rewriting history. The intervening protected-main delta only adds docs/index.md and is disjoint from the voice/export/ontology changes.
seonghobae added a commit that referenced this pull request Sep 1, 2026
Merge the current #780 root after it incorporated protected main@3f61c824. The parent movement only adds docs/index.md; this PR's product-gap baseline delta remains unchanged.
@seonghobae
seonghobae enabled auto-merge (squash) September 1, 2026 12:34
Signed-off-by: Codex <codex@localhost>
@opencode-agent
opencode-agent Bot disabled auto-merge September 1, 2026 23:34
@seonghobae seonghobae added the bug Something isn't working label Sep 2, 2026 — with ChatGPT Codex Connector
Signed-off-by: Codex <codex@localhost>

Copy link
Copy Markdown
Contributor Author

Cycle 2026-09-03: independent APPROVE still required on exact head 68c4285a10b6717e25abddc8a69a62a0fd30aa95. Reviewer request to org maintainers failed (not a collaborator). Copilot is not independent APPROVE. No self-approval. Do not squash-merge until independent APPROVE + exact-head required success.

Copy link
Copy Markdown
Contributor Author

Cycle 2026-09-03T05:01Z: writes work. Independent APPROVE still required on the exact head. Copilot/Devin/CodeRabbit are not independent. No self-approve. Do not squash-merge without independent APPROVE + exact-head required success. Not mixing i18n #922 into this PR.

Adopt #924's restored docs-contract test triggering while preserving Voice export authority delta without force rewrite.
@seonghobae
seonghobae marked this pull request as draft September 3, 2026 05:30
seonghobae added a commit that referenced this pull request Sep 3, 2026
Adopt #7800bf2440 after protected main #924 while preserving the one-file gap-baseline delta without force rewrite.
Adopt protected #931 workflow/contract blobs on the Voice export branch while preserving the evidence/export product delta. This non-force two-parent convergence keeps the child stack repairable without transferring predecessor evidence.
seonghobae added a commit that referenced this pull request Sep 4, 2026
Adopt #7801d8fa26 after protected #931 while preserving this child's one-file gap-baseline delta. The child tree is rebuilt from the moved parent plus the exact prior baseline blob, without force rewrite or ancestry loss.

@seonghobae seonghobae left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fresh parent/base review found #780 still anchored on the pre-#931 protected line. Its Voice/export product delta does not need to own or fork repository-local CI semantics. Repaired non-destructively at 1d8fa267b059289e77301a09985dfac70a439814 by adopting the exact protected #931 workflow/contract blobs and recording main@83eba56149eb802cd63642c507c324c9976ec78e as the second parent. Immediately restacked child #901 onto this moved parent at 9e582e4be080ae74bffac83817e639993ac85a71, preserving the child's exact baseline blob. No force rewrite or predecessor evidence transfer.

@seonghobae seonghobae left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fresh governance finding on the unchanged exact head: repository-local Ready-trigger Tests/Ontology are terminal GREEN, but the organization-ruleset required central workflow evidence on this SHA is still only the prior Draft-era cancelled Security/SAST/central-CodeQL/scheduler set; ready_for_review did not recreate those required-workflow runs. The separate GitHub Advanced Security CodeQL check is success but is not a substitute for the ruleset-pinned .github/workflows/codeql-pr.yml. Exact canary evidence has been handed to canonical owner ContextualWisdomLab/.github#712 (comment 5552270732). Keep #780 Ready as the stack's validation lane, but do not merge/bypass until the central owner recreates terminal required-workflow evidence on this unchanged head and a qualifying independent APPROVE exists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant