fix(voice): distinguish carrying and evidence exports - #780
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughVoice 할당 CSV가 ChangesVoice 조합 정합성
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to The change adds explicit carrying and derivation-evidence CSV fields while preserving compatibility and updating related authority documentation and metadata; no actionable merge-blocking risk remains beyond normal checks and review. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 66.67% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 3 files. (1 skipped: 1 unsupported.)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
…ority-20260828 # Conflicts: # docs/product-technical-gap-baseline.md # uv.lock
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Signed-off-by: Codex <codex@localhost>
Signed-off-by: Codex <codex@localhost>
Signed-off-by: Codex <codex@localhost>
Signed-off-by: Codex <codex@localhost>
Merge protected main@3f61c824 into the voice export root without rewriting history. The intervening protected-main delta only adds docs/index.md and is disjoint from the voice/export/ontology changes.
Merge the current #780 root after it incorporated protected main@3f61c824. The parent movement only adds docs/index.md; this PR's product-gap baseline delta remains unchanged.
Signed-off-by: Codex <codex@localhost>
Signed-off-by: Codex <codex@localhost>
|
Cycle 2026-09-03: independent APPROVE still required on exact head |
|
Cycle 2026-09-03T05:01Z: writes work. Independent APPROVE still required on the exact head. Copilot/Devin/CodeRabbit are not independent. No self-approve. Do not squash-merge without independent APPROVE + exact-head required success. Not mixing i18n #922 into this PR. |
Adopt #924's restored docs-contract test triggering while preserving Voice export authority delta without force rewrite.
Adopt protected #931 workflow/contract blobs on the Voice export branch while preserving the evidence/export product delta. This non-force two-parent convergence keeps the child stack repairable without transferring predecessor evidence.
seonghobae
left a comment
There was a problem hiding this comment.
Fresh parent/base review found #780 still anchored on the pre-#931 protected line. Its Voice/export product delta does not need to own or fork repository-local CI semantics. Repaired non-destructively at 1d8fa267b059289e77301a09985dfac70a439814 by adopting the exact protected #931 workflow/contract blobs and recording main@83eba56149eb802cd63642c507c324c9976ec78e as the second parent. Immediately restacked child #901 onto this moved parent at 9e582e4be080ae74bffac83817e639993ac85a71, preserving the child's exact baseline blob. No force rewrite or predecessor evidence transfer.
seonghobae
left a comment
There was a problem hiding this comment.
Fresh governance finding on the unchanged exact head: repository-local Ready-trigger Tests/Ontology are terminal GREEN, but the organization-ruleset required central workflow evidence on this SHA is still only the prior Draft-era cancelled Security/SAST/central-CodeQL/scheduler set; ready_for_review did not recreate those required-workflow runs. The separate GitHub Advanced Security CodeQL check is success but is not a substitute for the ruleset-pinned .github/workflows/codeql-pr.yml. Exact canary evidence has been handed to canonical owner ContextualWisdomLab/.github#712 (comment 5552270732). Keep #780 Ready as the stack's validation lane, but do not merge/bypass until the central owner recreates terminal required-workflow evidence on this unchanged head and a qualifying independent APPROVE exists.
Summary
Repairs Voice-of-X export authority. Exact-value CSV distinguishes the carrying Post from derivation-evidence Post, ADR 0251/0256 ownership is reconciled, and historical frontend/browser observations remain predecessor evidence after branch movement.
Protected-main convergence
Review
5116306008found this branch anchored on the pre-#931 protected line. Commit1d8fa267b059289e77301a09985dfac70a439814adopted the exact protected Tests/PROV-O/Ontology Draft-admission workflows plustests/test_tests_workflow_contract.pyand joined the repaired product tree to protectedmain@83eba56149eb802cd63642c507c324c9976ec78ewithout rewriting the Voice/export delta.Exact live boundary
main@83eba56149eb802cd63642c507c324c9976ec78e1d8fa267b059289e77301a09985dfac70a43981433952504686: success; Frontend101269793625and Full suite101269793798: success33952504679: ontology validation101269793684success; publish job correctly skipped on PRThe missing central Ready-transition executions are a workflow-lifecycle/control-plane defect, not a LineageWeave source result. This exact canary was already handed to the canonical
.githubowner path; do not replace it with local scans, synthetic statuses, a no-op head churn, or gate weakening. The separate central dispatcher-identity defect (opencode-agent[bot]versus the stale single-entry organization allowlist) is tracked in.github#1927, but that does not retroactively create the absent #780 Ready-trigger central runs.Direct descendants remain stacked on this parent. #901 is no longer intentionally RED: its stale ADR 0134
StatusNoticebaseline row was repaired in isolated GREEN run34007470247and clean product commit308ebdfae50606127316fa8c51d772ea93327f64; because #901 remains Draft, that child evidence does not transfer to this parent. #934 and #936 remain Draft. #937 retains the post-write reauthorization rollback repair on its own Draft head; child tests and evidence do not transfer to this parent.This parent remains the active validation lane for the Voice/export stack. Keep descendants stacked until normal protected integration; predecessor/child checks and approvals do not transfer. Do not self-approve, bypass required governance, force-push, or treat cancelled/skipped evidence as merge-ready.