fix(voice): preserve singleton relations across export pages - #968
Draft
seonghobae wants to merge 2 commits into
Draft
fix(voice): preserve singleton relations across export pages#968seonghobae wants to merge 2 commits into
seonghobae wants to merge 2 commits into
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Accumulating JSON-LD pages dropped earlier Voice relations when either page used a singleton value. Preserve supplied property values across singleton/array forms, retaining subject identity, existing labels, replay idempotency, and input immutability. This implements ADR 0256's existing union contract without new inference, Voice codes, API/schema changes, or release identities.
Stacked on #780 at
1d8fa267b059289e77301a09985dfac70a439814. Merge the parent under protection first, then retarget this child to main and collect fresh exact-head checks and independent approval. Existing parent work is preserved.Validation: direct Node invocation reproduced relation loss before the repair and passed three singleton/array cases afterward, including replay and immutability assertions. Added the same cases to the existing Vitest regression suite. Lint passed. Vitest failed before executing tests because its process pool did not respond within the startup timeout, including after a project-local frozen/offline dependency installation; no warning or failing gate was suppressed. The production typecheck did not complete during the bounded audit and was stopped. Storybook started, but the desktop/mobile browser audit failed with navigation/control-wait timeouts. No screenshots or rendered acceptance are claimed.
The baseline records dated exact heads, current ruleset observations, canonical repository names, release-title collisions, and explicit evidence limits. No authenticated candidate PostgreSQL API or k6 capacity acceptance is claimed. No qualifying independent approval or merge SHA is claimed. Keep Draft until validation is complete.