fix(voice): reject exports outside admitted Post endpoints - #971
fix(voice): reject exports outside admitted Post endpoints#971seonghobae wants to merge 4 commits into
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
seonghobae
left a comment
There was a problem hiding this comment.
Exact-head review: the repair is causal and keeps Voice export authority inside the admitted ontology neighborhood. exact_value_rows() already rejects a carrying identifier that is not an admitted Post via the Post-label lookup; this head adds the missing evidence-Post validation. jsonld_document() now validates both carrying and evidence Post endpoints before emitting Voice assignment nodes. The new parametrized regression covers both projections and both endpoint roles, including the wrong-type-but-present Person case. I found no additional source defect in this three-file delta. Keep Draft: the current head only has Draft-skipped repository admission so far; authenticated PostgreSQL/API/rendered acceptance, current-head central gates, and qualifying independent approval remain non-transferable.
Voice exports admitted endpoints outside the authorized Post neighborhood and emitted additional assignments after their derivation evidence was absent. Validate admitted endpoint types and omit unsupported additional assignments completely in exact-value/CSV and JSON-LD projections, preserving imported primary Voices and genuine derivation evidence.
Validation on exact
b6046c9c23f647abfd7b2436419c5b5b0db91bc5: the missing-evidence regression failed before repair; all 78 ontology neighborhood, ingestion, Voice authority, and SHACL tests passed afterward. Exact-head hosted Tests34084370524later completed GREEN. A prior same-head Draft-admission Tests run was skipped. Neither result changes stack governance or supplies independent approval.Fresh review found no further defect in the three-file export repair, but also recorded that this child should remain Draft. The PR had nevertheless been left Ready while stacked on unmerged #780. It is now Draft again without changing the product head. Parent #780 must merge normally under protected governance before this child is retargeted/converged to main; then collect fresh exact-head/base checks, central security verdicts, and qualifying independent approval. Do not allocate Ready-state product lanes merely to wait behind an unmerged parent, and do not transfer the current hosted GREEN across that future base movement.
Authenticated candidate PostgreSQL/API acceptance, desktop/mobile rendered acceptance where applicable, and synthetic k6 saturation remain incomplete. No UI layout/copy, API shape, schema, release number, inference policy, or owner-boundary changes. #934/#968 retain page-accumulation ownership; #936/#937 retain history and read-authorization ownership. No self-approval, bypass, force-push, destructive rebase, or gate weakening.