feat(zotero): apply steward decision patches offline - #32
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai full review |
|
…ion-patch' into HEAD
|
Current-stack correction (2026-09-05): exact base |
Signed-off-by: Seongho Bae <me@seonghobae.me>
Verified local approval-order repair — 2026-09-06 checkpoint
Exact head:
autoresearch/zotero-review-decision-cli@f0bf02a8a600924d254adfa7b4796aa2ef868165. Exact base:autoresearch/zotero-review-decision-patch@0dad7ca52bd2932e82bbf34eb4b7f4aec6b4f3f2.Original planner owner #13 preserves regression
505e111c993d8269e5b7b9e17a25a5ce20f8606eand repair8a684882005085d8b3cb47812e185975084e0475. Every existing local request/mode/item/metadata check finishes before the external approval verifier. Invalid requests invoke it zero times; valid complete requests invoke it exactly once. Local validation errors intentionally precede approval denial. Deterministic operations and complete before/after/rollback metadata are unchanged.This exact head passed locked Rust 1.98.0 workspace tests (158 tests / 34 unfiltered suites, doctests included), strict all-target Clippy, formatting, warnings-denied rustdoc, CI contract and diff checks before normal push. Normal parent integration retains both the prior child and verified parent as ancestors. Coverage from another stack head is not attributed to this head.
Keep Draft behind the existing prerequisite stack. This is local verification, not hosted current-head GREEN, independent approval, protected merge or release. No later full-text feature was reverse-merged into an earlier owner. Full-text-aware write admission, authentic decisions and independent authority remain separate gaps; no real Zotero/model request, label, approval or write was performed for this repair.
Earlier coordinates and status claims below are historical.
Prior PR description, retained without discarding evidence
Current repair checkpoint — 2026-09-05
Exact head:
bd7669d28abfd3476106362b790198f6dd9d2e2c. Named base:autoresearch/zotero-review-decision-patchat1c67d1e7b9ff90a84314d4e4bbf227d199771589when checked.This ordinary merge retains old head
2483d253d7a2dd5b4934d99f734ddb9f1a8d6adeand its repaired named parent as ancestors. It carries PR #29's earliest-owner static private-JSON diagnostic, inclusive 16 MiB pre-create metadata writer guard and regression tests, plus PR #28's fixture warning repair. Existing child functionality remains intact; full-text features were not reverse-merged into earlier owners.This exact head passed
cargo +1.98.0 test --locked --workspace(153 tests across 34 unfiltered suites, including doctests), strict Clippy across all targets, formatting, warnings-denied rustdoc, the CI contract check andgit diff --check. Nested filtered subprocess results are not counted twice. Coverage was not rerun at this particular new head; historical or later-child coverage is not transferred to it.Normal push preserves history and the existing Draft/prerequisite boundary. These are local results, not hosted current-head GREEN or independent protected approval. All required reviews/checks must be revalidated on the unchanged current head after prerequisites integrate. No force push, close, retarget, self-approval, dismissal, protected merge, new label, model request or Zotero write occurred. Authentic decisions and independently approved labels remain separately 0/3,715.
Preserved earlier description and historical checkpoints
Current source-integrity note — 2026-09-05
autoresearch/zotero-review-decision-cli@8c9eac55c904916334637c03c6f9c3621a2084bc.autoresearch/zotero-review-decision-patch@65b6472f398878ff52d8a39469e7f7afcb81a348.e7d4e59f1b55b5954c5f8436527bc96e7ef2fb13through ordinary merge ancestry. The source-snapshot digest binds complete captured raw provider JSON and the actual typed classifier inputs; source evidence and derived proposals retain separate identities.GoldenSetApproval.proposal_digestis required and binds the complete proposal records used for evaluation. The current proposal digest is checked before the caller-owned governance verifier. Do not backfill old receipts: regenerate evidence and obtain a new approval bound to the reviewed evidence.Earlier heads, runtime snapshots, campaign counts, and verification statements below are historical notes, not current acceptance evidence.
Historical PR notes — original text retained
Current exact authority — 2026-09-05
autoresearch/zotero-review-decision-patch@e5a1e521f25bfc4ff155240ddf55863adb455b1c;0ac89b6c5c319ae003611572ce60b8f1e4c0d43a;0ac89b6....The owner-only CLI retains bounded/no-follow/distinct-input protections, validates the report/current worksheet/decision input before creating a new exact-
0600worksheet, and performs no Zotero mutation or governance approval. The inherited #30 private-input and production-coverage repairs remain source state but require current-head terminal evidence.Keep Draft behind #31 -> #30 and the complete predecessor stack. Require one unchanged exact head with terminal required checks, independent approval where applicable, and zero valid unresolved findings. No force push, destructive rebase, self-approval, predecessor-evidence transfer, live mutation, or authority promotion.