feat(zotero): apply incremental steward decisions - #31
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai full review |
|
…ess' into HEAD # Conflicts: # crates/conceptweave-zotero/tests/classification_write_receipt_contract.rs
|
Current-stack correction (2026-09-05): exact base |
# Conflicts: # docs/PRD.md
Signed-off-by: Seongho Bae <me@seonghobae.me>
Latest decision-patch content checkpoint — September 7
Exact head
eaf248afd33dcac477daf1e3a31d79d47c5cbb69normally retains original PR3161072a70f7ec5a1fbd0b477430aacb8e770aa109and repaired PR30ee1ac9925c5287e9f10c2e9581b7cf513b170bd7via ef0ce43. Base remains autoresearch/zotero-review-progress. Baseline158tests33suites; integrated204/33.RED7208d80 compiled3pass2fail: old patch accepted against changed content plus fresh valid worksheet, and missing content field deserialized. Fix89bb941 adds required patch proposal_digest and compares it with existing recomputed identity before updates; no new hash/default/backfill/authority. Missing or stale patches require genuine current review, not copying a current digest at application. Atomic late-invalid-batch behavior, same-label idempotency and conflict refusal remain. Bounded independent source review found no additional defect, not formal approval.
Final source89bb941 passes207tests33suites including3doctests, strictClippy/rustdoc/fmt/CI/diff and unchanged coverage331reportedfunctions2965normalizedregions544normalizedbranches. Raw3971/4033lines6125/6232regions499/544branches are not100. Logs /tmp/conceptweave-pr31-{baseline,integrated,binding-red,verified,clippy,rustdoc,coverage}.log. Documentation-only successors update PRD/TRD/ProposedADR0006/Gap.
Keep OPEN Draft. Root/later patch consumers need required binding and prior cascade adoption. Actual decisions/independent approvals0/3715 plus4unresolved sources. Metadata patches remain unverified local review input, not full-text or Zotero write authority. Visual Inspection retried: Mac locked, no fresh screen. No real write, hosted GREEN, protected merge or release. Earlier snapshot-only patch descriptions below are superseded; historical evidence remains attributed to original heads.
Latest bounded-read integration checkpoint
Exact head
61072a70f7ec5a1fbd0b477430aacb8e770aa109normally merges parenta11e889d1680ab4d91f3565e3debf7ed0f10ba23while retaining previous child0dad7ca52bd2932e82bbf34eb4b7f4aec6b4f3f2. Base remainsautoresearch/zotero-review-progress. The #9 whole-snapshot elapsed-time repair and its RED/GREEN evidence are inherited without reverse-merging later features or discarding predecessor deltas.This exact head passes Rust 1.98.0 locked workspace tests=158 suites=33, including doctests and excluding filtered subprocess duplicates, strict all-target Clippy, warnings-denied rustdoc, formatting, the existing CI contract and diff checks. Log:
/private/tmp/conceptweave-deadline-pr31-20260906.log. Intermediate coverage is not inferred from owner/final-endpoint coverage. No new dependency, actual paper read/decision, Zotero mutation or authority issuer was used.Draft and protected prerequisites remain. Local tests are not hosted GREEN, independent approval, merged/released source or evidence for another head. Earlier checkpoints below are retained history, not the current head.
Verified local approval-order repair — 2026-09-06 checkpoint
Exact head:
autoresearch/zotero-review-decision-patch@0dad7ca52bd2932e82bbf34eb4b7f4aec6b4f3f2. Exact base:autoresearch/zotero-review-progress@a43ddceaf5dfaa4daba5270b954bda9f42a59cdb.Original planner owner #13 preserves regression
505e111c993d8269e5b7b9e17a25a5ce20f8606eand repair8a684882005085d8b3cb47812e185975084e0475. Every existing local request/mode/item/metadata check finishes before the external approval verifier. Invalid requests invoke it zero times; valid complete requests invoke it exactly once. Local validation errors intentionally precede approval denial. Deterministic operations and complete before/after/rollback metadata are unchanged.This exact head passed locked Rust 1.98.0 workspace tests (155 tests / 33 unfiltered suites, doctests included), strict all-target Clippy, formatting, warnings-denied rustdoc, CI contract and diff checks before normal push. Normal parent integration retains both the prior child and verified parent as ancestors. Coverage from another stack head is not attributed to this head.
Keep Draft behind the existing prerequisite stack. This is local verification, not hosted current-head GREEN, independent approval, protected merge or release. No later full-text feature was reverse-merged into an earlier owner. Full-text-aware write admission, authentic decisions and independent authority remain separate gaps; no real Zotero/model request, label, approval or write was performed for this repair.
Earlier coordinates and status claims below are historical.
Prior PR description, retained without discarding evidence
Current repair checkpoint — 2026-09-05
Exact head:
1c67d1e7b9ff90a84314d4e4bbf227d199771589. Named base:autoresearch/zotero-review-progressat88d4931f12942c3d2e0a1114fde9c6f97a73afacwhen checked.This ordinary merge retains old head
d8ba81c7a841cccde29271afc07edfc41bd935ecand its repaired named parent as ancestors. It carries PR #29's earliest-owner static private-JSON diagnostic, inclusive 16 MiB pre-create metadata writer guard and regression tests, plus PR #28's fixture warning repair. Existing child functionality remains intact; full-text features were not reverse-merged into earlier owners.This exact head passed
cargo +1.98.0 test --locked --workspace(150 tests across 33 unfiltered suites, including doctests), strict Clippy across all targets, formatting, warnings-denied rustdoc, the CI contract check andgit diff --check. Nested filtered subprocess results are not counted twice. Coverage was not rerun at this particular new head; historical or later-child coverage is not transferred to it.Normal push preserves history and the existing Draft/prerequisite boundary. These are local results, not hosted current-head GREEN or independent protected approval. All required reviews/checks must be revalidated on the unchanged current head after prerequisites integrate. No force push, close, retarget, self-approval, dismissal, protected merge, new label, model request or Zotero write occurred. Authentic decisions and independently approved labels remain separately 0/3,715.
Preserved earlier description and historical checkpoints
Current source-integrity note — 2026-09-05
autoresearch/zotero-review-decision-patch@65b6472f398878ff52d8a39469e7f7afcb81a348.autoresearch/zotero-review-progress@509ce7d4b15d755f05a59d1520bd75008207393c.e7d4e59f1b55b5954c5f8436527bc96e7ef2fb13through ordinary merge ancestry. The source-snapshot digest binds complete captured raw provider JSON and the actual typed classifier inputs; source evidence and derived proposals retain separate identities.GoldenSetApproval.proposal_digestis required and binds the complete proposal records used for evaluation. The current proposal digest is checked before the caller-owned governance verifier. Do not backfill old receipts: regenerate evidence and obtain a new approval bound to the reviewed evidence.Earlier heads, runtime snapshots, campaign counts, and verification statements below are historical notes, not current acceptance evidence.
Historical PR notes — original text retained
Current exact authority — 2026-09-05
autoresearch/zotero-review-progress@ddd0e4cf568a7fb3a20c8e57e299f1fd9b8f92d9;e5a1e521f25bfc4ff155240ddf55863adb455b1c;e5a1e52....The existing contract remains snapshot-bound and owner-only, rejects stale/conflicting review state, performs no Zotero mutation, and does not confer governance approval or publication authority. #32 is the dependent CLI consumer. Live reviewed completion remains 0/3,715.
Keep Draft behind #30 and the complete predecessor chain. Require one unchanged exact head with terminal required checks, independent approval where applicable, and zero valid unresolved findings. No force push, destructive rebase, self-approval, predecessor-evidence transfer, live mutation, or authority promotion.