feat(zotero): add snapshot-bound steward worksheet - #25
Conversation
|
@coderabbitai review |
|
@codex review |
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
@coderabbitai full review |
|
|
|
Current-stack correction (2026-09-05): exact base |
# Conflicts: # docs/PRD.md
Signed-off-by: Seongho Bae <me@seonghobae.me>
Latest worksheet source-scope checkpoint
Exact head
51631fbf711b403a40f3b9fafa2ec3958d54ceafnormally retains previous PR25c6b4c17e931951a2e1d4ea79ac79363f6306a5bfand parent PR2435c57ca4510a65cf48069285d78b95cf47db65ba. Base remainsautoresearch/zotero-complete-review-evaluation.RED
900038ecompiled4pass2fail: source inventory omission and hidden pending scope admitted.5b54d06reuses the complete report validator, deleting54 duplicate lines while preserving valid unresolved source preparation. RED30aa091compiled6pass2fail: changed metadata yields equal worksheet and missing binding deserializes. Final source97046c7requires existing v2 proposal_digest; source/context identity changes and missing-field rejection tested. Blank decisions preserved; no actual labels or approval issued.Final local evidence:158tests24suitesincluding3doctests; strictClippy/rustdoc/fmt/CI/diff and unchanged pinnedcoverage282functions2468normalizedregions414normalizedbranches pass. Raw3232/3293lines4858/4960regions369/414branches NOT100%. Logs
/tmp/conceptweave-pr25-{source-red,binding-red,final,clippy-final,rustdoc-final,coverage-final}.log. Independent read-only review no additional production finding. PRD/TRD/ProposedADR0006/Gap updated.Keep OPEN Draft. Later progress/patch/finalization consumers must compare worksheet/report proposal identity before governance; reject blank or rewritten bindings, regenerate old worksheets without backfill. Root has not adopted repair. Actual decisions/approvals0/3715 plus4unresolvedsources, noZoterowrite/protectedmerge/release. Visual Inspection retried but Maclocked. Local evidence is not hosted GREEN or protected approval. Next PR26 export pair must preserve these scope boundaries. Earlier checkpoints below are retained history.
Latest bounded-read integration checkpoint
Exact head
c6b4c17e931951a2e1d4ea79ac79363f6306a5bfnormally merges parent1e73e1545de32ae9a349c469a7794c5c3fc2ae9bwhile retaining previous child6af51119f434035c9e8fc2743e8327c0199a8c92. Base remainsautoresearch/zotero-complete-review-evaluation. The #9 whole-snapshot elapsed-time repair and its RED/GREEN evidence are inherited without reverse-merging later features or discarding predecessor deltas.This exact head passes Rust 1.98.0 locked workspace tests=126 suites=24, including doctests and excluding filtered subprocess duplicates, strict all-target Clippy, warnings-denied rustdoc, formatting, the existing CI contract and diff checks. Log:
/private/tmp/conceptweave-deadline-pr25-20260906.log. Intermediate coverage is not inferred from owner/final-endpoint coverage. No new dependency, actual paper read/decision, Zotero mutation or authority issuer was used.Draft and protected prerequisites remain. Local tests are not hosted GREEN, independent approval, merged/released source or evidence for another head. Earlier checkpoints below are retained history, not the current head.
Verified local approval-order repair — 2026-09-06 checkpoint
Exact head:
autoresearch/zotero-steward-review-worksheet@6af51119f434035c9e8fc2743e8327c0199a8c92. Exact base:autoresearch/zotero-complete-review-evaluation@ba3a691bb246258d2a27bc83c308be21031e310e.Original planner owner #13 preserves regression
505e111c993d8269e5b7b9e17a25a5ce20f8606eand repair8a684882005085d8b3cb47812e185975084e0475. Every existing local request/mode/item/metadata check finishes before the external approval verifier. Invalid requests invoke it zero times; valid complete requests invoke it exactly once. Local validation errors intentionally precede approval denial. Deterministic operations and complete before/after/rollback metadata are unchanged.This exact head passed locked Rust 1.98.0 workspace tests (123 tests / 24 unfiltered suites, doctests included), strict all-target Clippy, formatting, warnings-denied rustdoc, CI contract and diff checks before normal push. Normal parent integration retains both the prior child and verified parent as ancestors. Coverage from another stack head is not attributed to this head.
Keep Draft behind the existing prerequisite stack. This is local verification, not hosted current-head GREEN, independent approval, protected merge or release. No later full-text feature was reverse-merged into an earlier owner. Full-text-aware write admission, authentic decisions and independent authority remain separate gaps; no real Zotero/model request, label, approval or write was performed for this repair.
Earlier coordinates and status claims below are historical.
Prior PR description, retained without discarding evidence
Current source-integrity note — 2026-09-05
autoresearch/zotero-steward-review-worksheet@b92bc57bccd97612ddf7f8851c9b98fc3c683eed.autoresearch/zotero-complete-review-evaluation@68e3186f3638fbc7f111ed4c91a99dbe87ccf48a.e7d4e59f1b55b5954c5f8436527bc96e7ef2fb13through ordinary merge ancestry. The source-snapshot digest binds complete captured raw provider JSON and the actual typed classifier inputs; source evidence and derived proposals retain separate identities.GoldenSetApproval.proposal_digestis required and binds the complete proposal records used for evaluation. The current proposal digest is checked before the caller-owned governance verifier. Do not backfill old receipts: regenerate evidence and obtain a new approval bound to the reviewed evidence.Earlier heads, runtime snapshots, campaign counts, and verification statements below are historical notes, not current acceptance evidence.
Historical PR notes — original text retained
Outcome
Derive one blank steward decision for every bibliographic proposal, bind the worksheet to the exact library/rule/digest/complete item revisions, reject contradictory/incomplete-provenance/failed reports before review, and omit duplicated titles, abstracts, tags, collections and rule evidence.
Current exact stack — 2026-09-05
autoresearch/zotero-complete-review-evaluation@005826d069940d7cbf89028ee36ea14ef4a339dd;8a239eefb7a28aa12558f794ba01a6d8f7353132;8a239ee....Boundary
The worksheet starts with every steward decision blank. The last local campaign had 3,715 proposals, but live reviewed completion remains 0/3,715 until a steward supplies decisions and Governance verifies the approval. This PR performs no Zotero mutation and does not create publication authority.
Keep Draft behind #24 and the complete predecessor stack. Require one unchanged exact head with terminal Product/security/SAST/dependency/review evidence before integration.