Skip to content

feat(zotero): retain minimal steward review context - #22

Draft
seonghobae wants to merge 21 commits into
autoresearch/zotero10-rollback-reconciliationfrom
autoresearch/zotero-steward-review-context
Draft

feat(zotero): retain minimal steward review context#22
seonghobae wants to merge 21 commits into
autoresearch/zotero10-rollback-reconciliationfrom
autoresearch/zotero-steward-review-context

Conversation

@seonghobae

@seonghobae seonghobae commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Verified local approval-order repair — 2026-09-06 checkpoint

Exact head: autoresearch/zotero-steward-review-context@0b0691ee264264a7c50f894ef0190d12d97dea0d. Exact base: autoresearch/zotero10-rollback-reconciliation@9302f8525aa3b3aba2f68576a97b6d2c853f2819.

Original planner owner #13 preserves regression 505e111c993d8269e5b7b9e17a25a5ce20f8606e and repair 8a684882005085d8b3cb47812e185975084e0475. Every existing local request/mode/item/metadata check finishes before the external approval verifier. Invalid requests invoke it zero times; valid complete requests invoke it exactly once. Local validation errors intentionally precede approval denial. Deterministic operations and complete before/after/rollback metadata are unchanged.

This exact head passed locked Rust 1.98.0 workspace tests (117 tests / 23 unfiltered suites, doctests included), strict all-target Clippy, formatting, warnings-denied rustdoc, CI contract and diff checks before normal push. Normal parent integration retains both the prior child and verified parent as ancestors. Coverage from another stack head is not attributed to this head.

Keep Draft behind the existing prerequisite stack. This is local verification, not hosted current-head GREEN, independent approval, protected merge or release. No later full-text feature was reverse-merged into an earlier owner. Full-text-aware write admission, authentic decisions and independent authority remain separate gaps; no real Zotero/model request, label, approval or write was performed for this repair.

Earlier coordinates and status claims below are historical.

Prior PR description, retained without discarding evidence

Current source-integrity note — 2026-09-05

  • Exact head: autoresearch/zotero-steward-review-context@10eb8e1034b4ed174f47f254e21da85d7a1cd6bc.
  • Exact base: autoresearch/zotero10-rollback-reconciliation@05051d8c175eccd864eeac78f54b70116d8ee941.
  • This head inherits PR feat(research): add steward golden-set evaluation #10 root e7d4e59f1b55b5954c5f8436527bc96e7ef2fb13 through ordinary merge ancestry. The source-snapshot digest binds complete captured raw provider JSON and the actual typed classifier inputs; source evidence and derived proposals retain separate identities.
  • GoldenSetApproval.proposal_digest is required and binds the complete proposal records used for evaluation. The current proposal digest is checked before the caller-owned governance verifier. Do not backfill old receipts: regenerate evidence and obtain a new approval bound to the reviewed evidence.
  • Keep Draft. This note does not claim current exact-head hosted GREEN, independent approval, protected merge, live Zotero mutation, or governed publication. Root, predecessor, and terminal-stack local test evidence is not transferred as per-PR hosted evidence.

Earlier heads, runtime snapshots, campaign counts, and verification statements below are historical notes, not current acceptance evidence.

Historical PR notes — original text retained

Outcome

Retain a nonempty abstract for steward-review abstentions exactly once, reuse matched evidence when it already contains the abstract instead of duplicating sensitive text, omit review-only context from deterministically decided items, and keep the live classification report outside the repository.

Current exact stack — 2026-09-05

  • base: rollback reconciliation feat(zotero): reconcile indeterminate rollbacks #21 autoresearch/zotero10-rollback-reconciliation@d51762da7ddf614072918813adb750b6edebecbf;
  • exact head: 2c8ee56307c8f2ef5d51b61df9e19316776fdafb;
  • Draft/open/mergeable; non-force successor preserving steward-review context semantics while adopting current feat(zotero): reconcile indeterminate rollbacks #21/Foundation ancestry;
  • previously recorded Rust/coverage/CI/live read-only evidence is lineage evidence and is not protected exact-head GREEN for 2c8ee56... without fresh terminal workflows.

Boundary

The last read-only campaign observed Zotero 9.0.6 / Local API v3/schema 42, library version 12341, 8,326 records, 3,658 abstentions and 2,665 review-only abstracts with no duplicate decided-item copies. Those are observation/evaluation facts only. No Zotero record was changed, no steward decision was supplied, and secure Zotero 10 write-back remains gated by the predecessor security/governance contracts.

Keep Draft behind #21 and the full predecessor stack. Descendant private-report or worksheet evidence cannot back-prove this exact head.

@coderabbitai

coderabbitai Bot commented Sep 4, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@seonghobae

Copy link
Copy Markdown
Contributor Author

@coderabbitai review

@seonghobae

Copy link
Copy Markdown
Contributor Author

@codex review

@coderabbitai

coderabbitai Bot commented Sep 4, 2026

Copy link
Copy Markdown

Rate Limit Exceeded

@seonghobae have exceeded the limit for the number of chat messages per hour. Please wait 4 minutes and 49 seconds before sending another message.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@seonghobae

Copy link
Copy Markdown
Contributor Author

Independent exact-head re-review of 0a606c65ba400ac41e172c9e4816de2beb39f9f8 found no actionable issues and confirmed the earlier duplicate-abstract P2 is fixed. The reviewer statically verified the shared guard and conflict serialization test; the primary run separately executed the full Rust 1.98 test, Clippy, CI-contract, and 100% owned region/branch coverage checks.

Non-force restack PR #22 onto PR #21 current head. Preserve minimal steward-review context semantics while carrying the current predecessor receipt RED contracts and inherited security boundary through ancestry; no predecessor GREEN is claimed.
seonghobae added a commit that referenced this pull request Sep 4, 2026
Non-force restack PR #23 onto PR #22 current head. Preserve owner-only report semantics while carrying current predecessor receipt RED contracts and inherited security boundary through ancestry; no predecessor GREEN is claimed.
# Conflicts:
#	docs/TRD.md
#	docs/product-technical-gap-baseline.md
Non-force two-parent restack onto current rollback-reconciliation parent. Preserve minimal steward-review context while inheriting the repaired Foundation CI and receipt lineage.

Signed-off-by: Seongho Bae <me@seonghobae.me>
…econciliation' into HEAD

# Conflicts:
#	docs/TRD.md
#	docs/product-technical-gap-baseline.md

Copy link
Copy Markdown
Contributor Author

Current-stack correction (2026-09-05): exact base #21 18c4de16645473478065ff000e7d02e4ef979483; exact head 0312fc534afb2c25576753d74c66aa6461eea32f. Steward-review-context delta is preserved non-force; older body SHAs are historical.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant