feat(zotero): retain minimal steward review context - #22
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai review |
|
@codex review |
Rate Limit Exceeded
|
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Independent exact-head re-review of |
# Conflicts: # docs/TRD.md # docs/product-technical-gap-baseline.md
Non-force two-parent restack onto current rollback-reconciliation parent. Preserve minimal steward-review context while inheriting the repaired Foundation CI and receipt lineage. Signed-off-by: Seongho Bae <me@seonghobae.me>
…econciliation' into HEAD # Conflicts: # docs/TRD.md # docs/product-technical-gap-baseline.md
|
Current-stack correction (2026-09-05): exact base |
Signed-off-by: Seongho Bae <me@seonghobae.me>
Verified local approval-order repair — 2026-09-06 checkpoint
Exact head:
autoresearch/zotero-steward-review-context@0b0691ee264264a7c50f894ef0190d12d97dea0d. Exact base:autoresearch/zotero10-rollback-reconciliation@9302f8525aa3b3aba2f68576a97b6d2c853f2819.Original planner owner #13 preserves regression
505e111c993d8269e5b7b9e17a25a5ce20f8606eand repair8a684882005085d8b3cb47812e185975084e0475. Every existing local request/mode/item/metadata check finishes before the external approval verifier. Invalid requests invoke it zero times; valid complete requests invoke it exactly once. Local validation errors intentionally precede approval denial. Deterministic operations and complete before/after/rollback metadata are unchanged.This exact head passed locked Rust 1.98.0 workspace tests (117 tests / 23 unfiltered suites, doctests included), strict all-target Clippy, formatting, warnings-denied rustdoc, CI contract and diff checks before normal push. Normal parent integration retains both the prior child and verified parent as ancestors. Coverage from another stack head is not attributed to this head.
Keep Draft behind the existing prerequisite stack. This is local verification, not hosted current-head GREEN, independent approval, protected merge or release. No later full-text feature was reverse-merged into an earlier owner. Full-text-aware write admission, authentic decisions and independent authority remain separate gaps; no real Zotero/model request, label, approval or write was performed for this repair.
Earlier coordinates and status claims below are historical.
Prior PR description, retained without discarding evidence
Current source-integrity note — 2026-09-05
autoresearch/zotero-steward-review-context@10eb8e1034b4ed174f47f254e21da85d7a1cd6bc.autoresearch/zotero10-rollback-reconciliation@05051d8c175eccd864eeac78f54b70116d8ee941.e7d4e59f1b55b5954c5f8436527bc96e7ef2fb13through ordinary merge ancestry. The source-snapshot digest binds complete captured raw provider JSON and the actual typed classifier inputs; source evidence and derived proposals retain separate identities.GoldenSetApproval.proposal_digestis required and binds the complete proposal records used for evaluation. The current proposal digest is checked before the caller-owned governance verifier. Do not backfill old receipts: regenerate evidence and obtain a new approval bound to the reviewed evidence.Earlier heads, runtime snapshots, campaign counts, and verification statements below are historical notes, not current acceptance evidence.
Historical PR notes — original text retained
Outcome
Retain a nonempty abstract for steward-review abstentions exactly once, reuse matched evidence when it already contains the abstract instead of duplicating sensitive text, omit review-only context from deterministically decided items, and keep the live classification report outside the repository.
Current exact stack — 2026-09-05
autoresearch/zotero10-rollback-reconciliation@d51762da7ddf614072918813adb750b6edebecbf;2c8ee56307c8f2ef5d51b61df9e19316776fdafb;2c8ee56...without fresh terminal workflows.Boundary
The last read-only campaign observed Zotero 9.0.6 / Local API v3/schema 42, library version 12341, 8,326 records, 3,658 abstentions and 2,665 review-only abstracts with no duplicate decided-item copies. Those are observation/evaluation facts only. No Zotero record was changed, no steward decision was supplied, and secure Zotero 10 write-back remains gated by the predecessor security/governance contracts.
Keep Draft behind #21 and the full predecessor stack. Descendant private-report or worksheet evidence cannot back-prove this exact head.