Repository navigation
fix: order and page the user feed by article, newest first - #1259
devin-ai-integration[bot] wants to merge 2 commits into
Conversation
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
There was a problem hiding this comment.
✅ Devin Review: No Issues Found
Devin Review analyzed this PR and found no bugs or issues to report.
Custom reviewers
…faultJwtServiceTest
|
I added 4 tests for the feed paging change in a separate test PR, but couldn't run them: Gradle couldn't download dependencies on my machine. The test file compiles and is formatted correctly. Someone still needs to run Maven Central returned HTTP 429, and the mirror hosts this machine is set up to use ( Review of #1259
Gaps filled in
I didn't approve, merge, or push to the author's branch. |
Summary
GET /articles/feedreturned the wrong page:findArticlesOfAuthorsappliedlimit offset, nto the article × tag join rows and had noorder by. With two tags per article,limit=10returned 5 articles, oldest first, whilearticlesCountcounted all of them, so the Angular "Your Feed" showed only the oldest five posts and never a second page.The query now pages article ids first, newest first, then loads them, like
queryArticlesdoes for the global list:Found while running the Angular app against the #1258 backend (angular-realworld-example-app#85). The mapper is unchanged by #1258, so this targets
masterand merges on its own on either side of it.Added
ArticleQueryServiceTest.should_page_user_feed_by_article_newest_first(passes with./gradlew test --tests ArticleQueryServiceTeston JDK 11).spotlessJavaCheckonmasteralready fails onDefaultJwtServiceTest.java, which this PR does not touch.Implemented in session Wire Angular RealWorld app to Boot 3 backend
Review with Devin · Open in Devin Desktop