Skip to content

test: extra coverage for paged user feed (#1259) - #1261

Open
devin-ai-integration[bot] wants to merge 1 commit into
devin/task-25-feed-order-paginationfrom
devin/tests-for-pr-1259
Open

devin-ai-integration[bot] wants to merge 1 commit into
devin/task-25-feed-order-paginationfrom
devin/tests-for-pr-1259

Conversation

@devin-ai-integration

@devin-ai-integration devin-ai-integration Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

Summary

Test-only follow-up to #1259 (rewrite of findArticlesOfAuthors in ArticleReadService.xml). Adds four ArticleQueryServiceTest cases for findUserFeed that the PR's own test does not cover:

  • should_page_user_feed_across_followed_authors_newest_first: two followed authors with interleaved timestamps. Checks that pages are ordered across authors, not grouped per author.
  • should_page_user_feed_by_article_when_tag_counts_differ: a 0-tag article and a 4-tag article. Checks that limit counts articles, not joined tag rows, and that tag lists stay complete.
  • should_exclude_unfollowed_authors_from_user_feed_page: articles from an unfollowed user and from the viewer themselves are not in the page or the count.
  • should_return_empty_user_feed_page_when_offset_past_end: an offset past the end returns an empty list, and the count is still correct.

Not run: the sandbox could not resolve Gradle dependencies (Maven Central returned 429 and the mirror host is not allowlisted). I verified that compileTestJava passes and that the file matches google-java-format. ./gradlew spotlessJavaCheck test still needs to run in CI or locally.

Devin-Org: engineering

Link to Devin session: https://devin-gtm.devinenterprise.com/sessions/8e7f045362d641d8a302dbd348e2f6d5
Open in Devin Desktop: https://devin-gtm.devinenterprise.com/desktop/session/8e7f045362d641d8a302dbd348e2f6d5?variant=devin


Devin Review

@devin-ai-integration

Copy link
Copy Markdown
Author

I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".

  • Disable automatic comment, CI, and merge conflict monitoring

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants