Repository navigation
test: extra coverage for paged user feed (#1259) - #1261
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
Author
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test-only follow-up to #1259 (rewrite of
findArticlesOfAuthorsinArticleReadService.xml). Adds fourArticleQueryServiceTestcases forfindUserFeedthat the PR's own test does not cover:should_page_user_feed_across_followed_authors_newest_first: two followed authors with interleaved timestamps. Checks that pages are ordered across authors, not grouped per author.should_page_user_feed_by_article_when_tag_counts_differ: a 0-tag article and a 4-tag article. Checks thatlimitcounts articles, not joined tag rows, and that tag lists stay complete.should_exclude_unfollowed_authors_from_user_feed_page: articles from an unfollowed user and from the viewer themselves are not in the page or the count.should_return_empty_user_feed_page_when_offset_past_end: an offset past the end returns an empty list, and the count is still correct.Not run: the sandbox could not resolve Gradle dependencies (Maven Central returned 429 and the mirror host is not allowlisted). I verified that
compileTestJavapasses and that the file matches google-java-format../gradlew spotlessJavaCheck teststill needs to run in CI or locally.Devin-Org: engineering
Link to Devin session: https://devin-gtm.devinenterprise.com/sessions/8e7f045362d641d8a302dbd348e2f6d5
Open in Devin Desktop: https://devin-gtm.devinenterprise.com/desktop/session/8e7f045362d641d8a302dbd348e2f6d5?variant=devin