Skip to content

fix: return an empty feed page past the end instead of a 500 - #1263

Open
devin-ai-integration[bot] wants to merge 1 commit into
devin/task-25-feed-order-paginationfrom
devin/task-25-feed-empty-page
Open

devin-ai-integration[bot] wants to merge 1 commit into
devin/task-25-feed-order-paginationfrom
devin/task-25-feed-empty-page

Conversation

@devin-ai-integration

@devin-ai-integration devin-ai-integration Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

Summary

Stacked on #1259. Asking for a feed page past the end returned a 500 over REST (/articles/feed?offset=18 with 18 articles) and an SQL error over GraphQL (feed(first:10, after:<last cursor>)).

Cause: ArticleQueryService.fillExtraInfo ran the favorites-count, favorited and following lookups even when the page was empty. Their MyBatis <foreach> then rendered where id in (), which SQLite rejects (near "group": syntax error). fillExtraInfo now returns early for an empty list, so:

  • REST: {"articles": [], "articlesCount": <total>}, 200
  • GraphQL: edges: [], hasNextPage: false, endCursor: null

Nothing else changes; non-empty pages run the same queries as before.

Testing

Devin-Org: engineering


Migration Engineer opened this PR for Matthew
Implemented in session Wire Angular RealWorld app to Boot 3 backend
Review with Devin · Open in Devin Desktop


@devin-ai-integration

Copy link
Copy Markdown
Author

I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".

  • Disable automatic comment, CI, and merge conflict monitoring

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Custom reviewers

  • 🧪 Test 2 reviewer: no findings · View
  • 🚩 TD Enterprise Architecture: no findings · View
  • 👁️ TD Information Security: no findings · View
  • 🧠 TD French Language (Bill 96): no findings · View
  • ⏱️ TD API Contracts: no findings · View

Devin Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants