Repository navigation
fix: load the profile once per switch and show an error for unknown users - #91
Conversation
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
| this.articlesConfig.set({ | ||
| type: 'all', | ||
| filters: { | ||
| author: params.get('username')!, |
There was a problem hiding this comment.
🔍 Profile tabs use unverified URL usernames
When a profile lookup resolves a username differently from the URL, articlesConfig uses the URL value instead of the returned username. Check whether profile lookup and article filtering apply the same username matching rules; the favorites tab makes the same change.
Was this helpful? React with 👍 or 👎 to provide feedback.
| ? { errors: { profile: ['not found'] } } | ||
| : { errors: error.errors ?? { profile: ['could not be loaded'] } }, |
There was a problem hiding this comment.
🧠 TD French Language (Bill 96): English-only profile error messages
On lookup failures, ProfileComponent hard-codes “profile not found” and the fallback “profile could not be loaded”. ListErrorsComponent renders these without translation. Canadian French equivalents are profile.notFound: « Profil introuvable » and profile.loadFailed: « Impossible de charger le profil ».
View in Devin Review · Custom reviewer
Was this helpful? React with 👍 or 👎 to provide feedback.
c427cf7 to
0de77c5
Compare
7bd746a to
7e09c9d
Compare
|
CHECKED in the browser: #91 at 7e09c9d (includes #85), run against spring-boot-realworld #1258 + #1259 (94dab597) on seed data, after a fresh
|




Summary
Stacked on #85 (base
devin/task-25-angular-boot3-contract-v2) so #85 stays as approved; restacked on #85's rebase onto #87 (#85 head 0de77c5), merges cleanly with #88. Fixes the two follow-ups found when checking #85 at c427cf7:ProfileArticlesComponentandProfileFavoritesComponenteach fetchedGET /profiles/:usernameonly to readprofile.usernamefor the article filter. The parent also clearsprofileon switch, which tears down and recreates the<router-outlet>, so the old and new child each fetched again. The tabs now readusernamefromroute.parent.paramMapand fetch nothing; onlyProfileComponentloads the profile. Direct load also drops from 2 requests to 1.ProfileComponentstorederror.errors(the inner map) inerrors, but<app-list-errors>expects{ errors: {...} }, so it rendered an empty<ul>. It now sets{ errors: { profile: ['not found'] } }on 404 (rendered "profile not found") and wraps other failures correctly.Verified locally against #1258 on seed data (jake): direct load 1 request, sam → jake via navbar 1 request with jake's content and 10 posts, Favorited tab 0 extra requests, sam/favorites → jake 1 request,
/profile/nobodyxyzshows "profile not found", and navigating back to a real profile recovers.bun run format:check,bun run test -- --run(180/180)bun run buildandbun run lintpass.Devin-Org: engineering
Implemented in session Wire Angular RealWorld app to Boot 3 backend
Review with Devin · Open in Devin Desktop