Skip to content

bug: Snyk transitive overrides from #70, rebased onto #79 - #86

Open
devin-ai-integration[bot] wants to merge 1 commit into
devin/1789994881-sonarqube-security-fixesfrom
devin/task-19-snyk-overrides-on-79
Open

devin-ai-integration[bot] wants to merge 1 commit into
devin/1789994881-sonarqube-security-fixesfrom
devin/task-19-snyk-overrides-on-79

Conversation

@devin-ai-integration

@devin-ai-integration devin-ai-integration Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

Summary

#70 rebased onto #79 with only its bun overrides kept (stack 1 of 2; base is #79's branch, retarget to main once #79 lands). Supersedes #70; #70 itself is left untouched, close it once this lands.

Dropped from #70 because #79 already covers them: the @angular/* 21.2.19 bump (#79 goes to 21.2.23), zone.js devDependency, and the @analogjs/vite-plugin-angular ~2.2.2 pin (unit tests are green on #79 without it).

"overrides": {
  "hono": "4.13.5",            // #70 had 4.12.34; #79 already resolves 4.13.5, so pinning #70's value would downgrade
  "brace-expansion@1": "1.1.18",
  "brace-expansion@2": "2.1.4",
  "minimatch@3": "3.1.3",
  "minimatch@9": "9.0.7",
  "minimatch@10": "10.2.3",
  "picomatch@2": "2.3.2",
  "ng-morph": "5.0.1"          // drops ng-morph 4.x's exact pin on vulnerable minimatch@10.0.1
}

Lockfile effect vs #79: ng-morph 4.8.4 → 5.0.1 (pulls multimatch 8, so minimatch@3/brace-expansion@1 and the vulnerable minimatch@10.0.1 leave the tree). Also replaces #72, #73, #74, #75, #76, #77, #78 and #3 per the landing plan.

Verification

  • bun run format:check: clean
  • bun run test -- --run: 180/180 passed
  • bun run build: green

Devin-Org: engineering


Product Engineer opened this PR for Matthew
Implemented in session Rebase angular-realworld dependency PRs onto #79
Review with Devin · Open in Devin Desktop


@devin-ai-integration

Copy link
Copy Markdown
Author

I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".

  • Disable automatic comment, CI, and merge conflict monitoring

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 potential issue.

Custom reviewers

  • 🧪 Test 2 reviewer: no findings · View
  • 🚩 TD Enterprise Architecture: no findings · View
  • 👁️ TD Information Security: no findings · View
  • 🧠 TD French Language (Bill 96): no findings · View
  • ⏱️ TD API Contracts: no findings · View

Devin Review

Comment thread package.json
"minimatch@9": "9.0.7",
"minimatch@10": "10.2.3",
"picomatch@2": "2.3.2",
"ng-morph": "5.0.1"

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 RxAngular receives unsupported ng-morph version

With ng-morph overridden to 5.0.1, both RxAngular packages receive a version outside their declared ^4.0.3 range. Their ng-morph-dependent functionality runs against an unsupported major version.

Learn more

The application installs @rx-angular/cdk and @rx-angular/template, and both declare ng-morph: ^4.0.3 in the locked dependency metadata. A global override replaces that dependency with ng-morph@5.0.1, regardless of the requested range. This leaves RxAngular's ng-morph-dependent integration outside its declared compatibility range; the passing app tests and build do not establish compatibility for every package feature.

Example: An Angular CLI operation using an RxAngular schematic loads ng-morph 5.0.1, although RxAngular 21.0.0 requested ng-morph 4.x.

Recommended fix: Use a supported RxAngular release that declares compatibility with ng-morph 5, or choose a patched ng-morph 4 release and address its vulnerable transitive dependency without forcing an incompatible major.

Devin Review


Was this helpful? React with 👍 or 👎 to provide feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants