Repository navigation
bug: Snyk transitive overrides from #70, rebased onto #79 - #86
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
…comatch, ng-morph) onto #79
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
| "minimatch@9": "9.0.7", | ||
| "minimatch@10": "10.2.3", | ||
| "picomatch@2": "2.3.2", | ||
| "ng-morph": "5.0.1" |
There was a problem hiding this comment.
🟡 RxAngular receives unsupported ng-morph version
With ng-morph overridden to 5.0.1, both RxAngular packages receive a version outside their declared ^4.0.3 range. Their ng-morph-dependent functionality runs against an unsupported major version.
Learn more
The application installs @rx-angular/cdk and @rx-angular/template, and both declare ng-morph: ^4.0.3 in the locked dependency metadata. A global override replaces that dependency with ng-morph@5.0.1, regardless of the requested range. This leaves RxAngular's ng-morph-dependent integration outside its declared compatibility range; the passing app tests and build do not establish compatibility for every package feature.
Example: An Angular CLI operation using an RxAngular schematic loads ng-morph 5.0.1, although RxAngular 21.0.0 requested ng-morph 4.x.
Recommended fix: Use a supported RxAngular release that declares compatibility with ng-morph 5, or choose a patched ng-morph 4 release and address its vulnerable transitive dependency without forcing an incompatible major.
Was this helpful? React with 👍 or 👎 to provide feedback.
Summary
#70 rebased onto #79 with only its bun
overrideskept (stack 1 of 2; base is #79's branch, retarget tomainonce #79 lands). Supersedes #70; #70 itself is left untouched, close it once this lands.Dropped from #70 because #79 already covers them: the
@angular/*21.2.19 bump (#79 goes to 21.2.23),zone.jsdevDependency, and the@analogjs/vite-plugin-angular ~2.2.2pin (unit tests are green on #79 without it).Lockfile effect vs #79:
ng-morph4.8.4 → 5.0.1 (pullsmultimatch8, sominimatch@3/brace-expansion@1and the vulnerableminimatch@10.0.1leave the tree). Also replaces #72, #73, #74, #75, #76, #77, #78 and #3 per the landing plan.Verification
bun run format:check: cleanbun run test -- --run: 180/180 passedbun run build: greenDevin-Org: engineering
Implemented in session Rebase angular-realworld dependency PRs onto #79
Review with Devin · Open in Devin Desktop