Fix on-demand tool persist unlocking in-flight natal generate - #58
Draft
cursor[bot] wants to merge 1 commit into
Draft
cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
On-demand tool visits were completing generationLocks/jobs and rewriting users.profileDataHash. A concurrent Generate that returns 409 already sends the user to /tools, so opening a tool released the in-flight natal lock. Finalize those writes only for Generate Full Report natal commit. Co-authored-by: Andy Oliver Rozario <andyrozario7@gmail.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
19 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
generationLocks/generationJobsor rewriteusers.profileDataHash.finalizeGeneration: true.Why this change is safe
persistOnDemandToolReportswas copied from catalog finalize. Visiting a tool after a 409 generate (profile page already redirects to/tools) released the natal lock while Generate was still writing Vedic/Western charts.Verification
pnpm exec eslinton touched filespnpm test— 70 suites / 383 testspnpm run securityRegression prevention
tests/unit/onDemandPersistFinalize.test.tsfails before this change (on-demand persist wrotegenerationLockscompleted)finalizeGeneration: true(tests/integration/profile-generate.test.ts)Release checklist (solo-friendly)
mainafter CIrunninguntil natal persist finishes