Utilize YAML for terminal behavior - #702
Open
1000TurquoisePogs wants to merge 3 commits into
Open
Conversation
Signed-off-by: 1000TurquoisePogs <sgrady@rocketsoftware.com>
This was referenced Jul 22, 2026
Signed-off-by: 1000TurquoisePogs <sgrady@rocketsoftware.com>
Signed-off-by: 1000TurquoisePogs <sgrady@rocketsoftware.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Proposed changes
Adds per-component
allowListsupport to the terminal WebSocket proxy, enabling operators to restrict which hostnames TN3270 and VT terminal sessions may connect to. When configured, any connection attempt to a host not in the list is rejected with WebSocket close code 4003 and logged asZWED0181W. Also adds theZWED0181Wlog message definition that the proxy code references.Files changed:
plugins/terminal-proxy/lib/terminalProxy.js— readscomponents.tn3270-ng2.allowList/components.vt-ng2.allowListfromzowe.yaml; rejects unlisted hosts with WS close code 4003 (Forbidden)plugins/terminal-proxy/lib/assets/i18n/log/messages_en.json— addsZWED0181W:"Host %s rejected, not in allowList. %s"PR Checklist
Testing
AllowList enforcement:
zowe.yaml:allowed-host.example.com— connection should proceed normally.ZWED0181Wwarning identifying the rejected host.No allowList (default behavior):
allowListkey entirely fromzowe.yaml.VT allowList:
components.vt-ng2.allowListand the VT terminal app.Further comments
The
allowListis optional and defaults tonullwhen absent. The check is an exact string match (Array.includes). WS close code 4003 was chosen as an application-level "Forbidden" code, complementing the existing 4000 (going away) and 4999 (internal error) codes already used by the proxy. The corresponding frontend changes (displaying "Connection forbidden" on code 4003) are in the tn3270-ng2 and vt-ng2 PRs.