Skip to content

React to message 4003 - #83

Open
1000TurquoisePogs wants to merge 2 commits into
v3.x/stagingfrom
fix/v3/terminal-allowlist
Open

React to message 4003#83
1000TurquoisePogs wants to merge 2 commits into
v3.x/stagingfrom
fix/v3/terminal-allowlist

Conversation

@1000TurquoisePogs

@1000TurquoisePogs 1000TurquoisePogs commented Jul 22, 2026

Copy link
Copy Markdown
Member

Proposed changes

This PR depends upon the following PRs:
zowe/zlux-server-framework#702

One enhancement to the VT terminal UI:

  1. AllowList rejection message: When the server closes the WebSocket with code 4003 (host not in allowList), the status bar now displays "Connection forbidden" instead of a generic websocket error.

Files changed:

  • webClient/src/app/app.component.ts — handles WS close code 4003 in onWSError with a "Connection forbidden" message

PR Checklist

  • If the changes in this PR are meant for the next release / mainline, this PR targets the "staging" branch.
  • My code follows the style guidelines of this project (see: Contributing guideline)
  • I have made corresponding changes to the documentation
  • Relevant update to CHANGELOG.md
  • My changes generate no new warnings

Testing

AllowList rejection UX:

  1. Configure components.vt-ng2.allowList in zowe.yaml to exclude the target host (see zlux-server-framework PR).
  2. Open the VT terminal app and attempt to connect to the excluded host.
  3. Verify the status bar shows "Connection forbidden" (not a raw websocket error code or blank message).

Further comments

The 4003 close code is handled as a known application-level rejection in onWSError, parallel to how other known close codes are handled. No changes to connection logic — this is purely a UI message improvement.

Signed-off-by: 1000TurquoisePogs <sgrady@rocketsoftware.com>
Signed-off-by: 1000TurquoisePogs <sgrady@rocketsoftware.com>
@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant