fix: JSONC config loading, clarify cost.rate docs (v0.7.1) - #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #9
What
rate(cost display exchange rate) confusion from question about rate field. #9: clarified incache-hit.config.example.json($comment-rate) and both READMEs — it is a manual snapshot (USD→CNY), omitted → built-in default 6.77, USD users can skip it, non-USD users should set the current rate (Xe / Wise / OANDA links added).src/jsonc.ts. Previously a config with//comments failed to parse silently and fell back to all defaults.Tests
bun test: 408 pass / 0 fail (+2 JSONC load tests intests/load-config.test.ts).