Repository navigation
ci: drop serializing --nocapture from CI test steps (RUST-017) - #1331
Merged
Merged
Conversation
Refs forge-ci/ci.yml#132 Local-Gate: v1 tree=d57d78f26d3891210f95c22ed171a1793e7aae88 secs=877 lanes=linux-quick:run Ci-Attestation: {"at":1792979988,"gate":"rust/all/fmt","host":"linux-x86_64","key":"c1d19105e5049d742d876c8deace92e92ecfcc1099bf0e3b3dbc3d48693295ad","lane":"linux-quick","parents":["dee1c2c6307739b6aed08927264a775bd6a2b727"],"secs":877,"stamp":"4c7fff5b913135e8e43c67412650c99c","tree":"d57d78f26d3891210f95c22ed171a1793e7aae88","v":1,"via":"run"} Ci-Attestation: {"at":1792979988,"gate":"python/all/static","host":"linux-x86_64","key":"c1d19105e5049d742d876c8deace92e92ecfcc1099bf0e3b3dbc3d48693295ad","lane":"linux-quick","parents":["dee1c2c6307739b6aed08927264a775bd6a2b727"],"secs":877,"stamp":"5010a4451cb8d8c7984557f75208fe07","tree":"d57d78f26d3891210f95c22ed171a1793e7aae88","v":1,"via":"run"} Ci-Attestation: {"at":1792979988,"gate":"rust/x86_64-unknown-linux-gnu/check","host":"linux-x86_64","key":"c1d19105e5049d742d876c8deace92e92ecfcc1099bf0e3b3dbc3d48693295ad","lane":"linux-quick","parents":["dee1c2c6307739b6aed08927264a775bd6a2b727"],"secs":877,"stamp":"831f82b4712f68fdc51a96c0519ec48c","tree":"d57d78f26d3891210f95c22ed171a1793e7aae88","v":1,"via":"run"} Ci-Attestation: {"at":1792979988,"gate":"rust/x86_64-unknown-linux-gnu/dylint","host":"linux-x86_64","key":"c1d19105e5049d742d876c8deace92e92ecfcc1099bf0e3b3dbc3d48693295ad","lane":"linux-quick","parents":["dee1c2c6307739b6aed08927264a775bd6a2b727"],"secs":877,"stamp":"a99bd800619c17bfa8d853a47be66e0e","tree":"d57d78f26d3891210f95c22ed171a1793e7aae88","v":1,"via":"run"} Ci-Attestation: {"at":1792979988,"gate":"rust/x86_64-unknown-linux-gnu/test","host":"linux-x86_64","key":"c1d19105e5049d742d876c8deace92e92ecfcc1099bf0e3b3dbc3d48693295ad","lane":"linux-quick","parents":["dee1c2c6307739b6aed08927264a775bd6a2b727"],"secs":877,"stamp":"c7640ce8ce754c94db10b6dcd9ddbfdf","tree":"d57d78f26d3891210f95c22ed171a1793e7aae88","v":1,"via":"run"} Ci-Attestation: {"at":1792979988,"gate":"python/linux-x64/test","host":"linux-x86_64","key":"c1d19105e5049d742d876c8deace92e92ecfcc1099bf0e3b3dbc3d48693295ad","lane":"linux-quick","parents":["dee1c2c6307739b6aed08927264a775bd6a2b727"],"secs":877,"stamp":"785801622a4639ed35257863fe7a1d22","tree":"d57d78f26d3891210f95c22ed171a1793e7aae88","v":1,"via":"run"} Ci-Attestation: {"at":1792979988,"gate":"general/linux-x64/perf","host":"linux-x86_64","key":"c1d19105e5049d742d876c8deace92e92ecfcc1099bf0e3b3dbc3d48693295ad","lane":"linux-quick","parents":["dee1c2c6307739b6aed08927264a775bd6a2b727"],"secs":877,"stamp":"7bfc839e8a891146c97972ba7710e693","tree":"d57d78f26d3891210f95c22ed171a1793e7aae88","v":1,"via":"run"}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the current ci-lint RUST-015/016/017 findings (
ci-lint precheck --local, ci.yml@main). The issue's list was stale: RUST-015 and RUST-016 already report nothing. Only RUST-017 was left.Findings fixed
ci-preflight.ymljobs.preflight.steps[18](Terminal graphics capability matrix): removed--nocapture. The matrix goes toRUNNING_PROCESS_TERMINAL_CAPABILITY_EXPORT_DIRand the next step reads it from there, so stdout isn't needed. libtest still prints the output of a failing test.independent-spawn.ymljobs.docker-fixture-build.steps[5](absent user session bus): removed--nocapture. It runs one test, and its output on failure is still shown.ci-preflight.ymljobs.preflight.steps[21](Broker Hello perf guard): kept--nocaptureand added# ci-lint: allow RUST-017 <reason>. It runs a single timing test, so there is nothing to run in parallel, and it shouldn't share cores anyway. The p50/p99 line it prints when it passes is the perf evidence.Coverage is unchanged: the same tests run with the same filters.
ci-lint before
(no RUST-015 or RUST-016 findings)
ci-lint after
No RUST-015, RUST-016 or RUST-017 findings.
The local gate passed (linux-quick, 877s) and stamped the head.
Refs forge-ci/ci.yml#132