Skip to content

ci: drop serializing --nocapture from CI test steps (RUST-017) - #1331

Merged
zackees merged 1 commit into
mainfrom
fix/ci-lint-rust-015-017
Oct 26, 2026
Merged

zackees merged 1 commit into
mainfrom
fix/ci-lint-rust-015-017

Conversation

@zackees

@zackees zackees commented Oct 26, 2026

Copy link
Copy Markdown
Owner

Fixes the current ci-lint RUST-015/016/017 findings (ci-lint precheck --local, ci.yml@main). The issue's list was stale: RUST-015 and RUST-016 already report nothing. Only RUST-017 was left.

Findings fixed

  • ci-preflight.yml jobs.preflight.steps[18] (Terminal graphics capability matrix): removed --nocapture. The matrix goes to RUNNING_PROCESS_TERMINAL_CAPABILITY_EXPORT_DIR and the next step reads it from there, so stdout isn't needed. libtest still prints the output of a failing test.
  • independent-spawn.yml jobs.docker-fixture-build.steps[5] (absent user session bus): removed --nocapture. It runs one test, and its output on failure is still shown.
  • ci-preflight.yml jobs.preflight.steps[21] (Broker Hello perf guard): kept --nocapture and added # ci-lint: allow RUST-017 <reason>. It runs a single timing test, so there is nothing to run in parallel, and it shouldn't share cores anyway. The p50/p99 line it prints when it passes is the perf evidence.

Coverage is unchanged: the same tests run with the same filters.

ci-lint before

== RUST-017 (3) ==
[RUST-017] VIOLATION .github/workflows/ci-preflight.yml  jobs.preflight.steps[18]: 'cargo test' passes --nocapture
[RUST-017] VIOLATION .github/workflows/ci-preflight.yml  jobs.preflight.steps[21]: 'cargo test' passes --nocapture
[RUST-017] VIOLATION .github/workflows/independent-spawn.yml  jobs.docker-fixture-build.steps[5]: 'cargo test' passes --nocapture

(no RUST-015 or RUST-016 findings)

ci-lint after

No RUST-015, RUST-016 or RUST-017 findings.

The local gate passed (linux-quick, 877s) and stamped the head.

Refs forge-ci/ci.yml#132

Refs forge-ci/ci.yml#132

Local-Gate: v1 tree=d57d78f26d3891210f95c22ed171a1793e7aae88 secs=877 lanes=linux-quick:run
Ci-Attestation: {"at":1792979988,"gate":"rust/all/fmt","host":"linux-x86_64","key":"c1d19105e5049d742d876c8deace92e92ecfcc1099bf0e3b3dbc3d48693295ad","lane":"linux-quick","parents":["dee1c2c6307739b6aed08927264a775bd6a2b727"],"secs":877,"stamp":"4c7fff5b913135e8e43c67412650c99c","tree":"d57d78f26d3891210f95c22ed171a1793e7aae88","v":1,"via":"run"}
Ci-Attestation: {"at":1792979988,"gate":"python/all/static","host":"linux-x86_64","key":"c1d19105e5049d742d876c8deace92e92ecfcc1099bf0e3b3dbc3d48693295ad","lane":"linux-quick","parents":["dee1c2c6307739b6aed08927264a775bd6a2b727"],"secs":877,"stamp":"5010a4451cb8d8c7984557f75208fe07","tree":"d57d78f26d3891210f95c22ed171a1793e7aae88","v":1,"via":"run"}
Ci-Attestation: {"at":1792979988,"gate":"rust/x86_64-unknown-linux-gnu/check","host":"linux-x86_64","key":"c1d19105e5049d742d876c8deace92e92ecfcc1099bf0e3b3dbc3d48693295ad","lane":"linux-quick","parents":["dee1c2c6307739b6aed08927264a775bd6a2b727"],"secs":877,"stamp":"831f82b4712f68fdc51a96c0519ec48c","tree":"d57d78f26d3891210f95c22ed171a1793e7aae88","v":1,"via":"run"}
Ci-Attestation: {"at":1792979988,"gate":"rust/x86_64-unknown-linux-gnu/dylint","host":"linux-x86_64","key":"c1d19105e5049d742d876c8deace92e92ecfcc1099bf0e3b3dbc3d48693295ad","lane":"linux-quick","parents":["dee1c2c6307739b6aed08927264a775bd6a2b727"],"secs":877,"stamp":"a99bd800619c17bfa8d853a47be66e0e","tree":"d57d78f26d3891210f95c22ed171a1793e7aae88","v":1,"via":"run"}
Ci-Attestation: {"at":1792979988,"gate":"rust/x86_64-unknown-linux-gnu/test","host":"linux-x86_64","key":"c1d19105e5049d742d876c8deace92e92ecfcc1099bf0e3b3dbc3d48693295ad","lane":"linux-quick","parents":["dee1c2c6307739b6aed08927264a775bd6a2b727"],"secs":877,"stamp":"c7640ce8ce754c94db10b6dcd9ddbfdf","tree":"d57d78f26d3891210f95c22ed171a1793e7aae88","v":1,"via":"run"}
Ci-Attestation: {"at":1792979988,"gate":"python/linux-x64/test","host":"linux-x86_64","key":"c1d19105e5049d742d876c8deace92e92ecfcc1099bf0e3b3dbc3d48693295ad","lane":"linux-quick","parents":["dee1c2c6307739b6aed08927264a775bd6a2b727"],"secs":877,"stamp":"785801622a4639ed35257863fe7a1d22","tree":"d57d78f26d3891210f95c22ed171a1793e7aae88","v":1,"via":"run"}
Ci-Attestation: {"at":1792979988,"gate":"general/linux-x64/perf","host":"linux-x86_64","key":"c1d19105e5049d742d876c8deace92e92ecfcc1099bf0e3b3dbc3d48693295ad","lane":"linux-quick","parents":["dee1c2c6307739b6aed08927264a775bd6a2b727"],"secs":877,"stamp":"7bfc839e8a891146c97972ba7710e693","tree":"d57d78f26d3891210f95c22ed171a1793e7aae88","v":1,"via":"run"}
@zackees
zackees merged commit d3cbc41 into main Oct 26, 2026
17 checks passed
@zackees
zackees deleted the fix/ci-lint-rust-015-017 branch November 5, 2026 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant