Repository navigation
ci: mark the intentional --nocapture uses as RUST-017 allows - #1333
Merged
Merged
Conversation
Owner
Author
|
Local gate: not stamped. linux-quick failed only at the "Broker Hello perf guard" timing step on a shared host at load ~70. This diff only adds allow comments and a constant. |
ci-lint's RUST-017 flags these as needs_review. Each is deliberate: - ci/independent_spawn.py: one exact test per invocation on a real Windows Task Scheduler host; the captured output is the evidence. - ci/test.py brokered_backend_ui: a single trybuild test, nothing to serialize. - ci/test.py RUNNING_PROCESS_TEST_NOCAPTURE: local-debug opt-in, never set in CI. Refs forge-ci/ci.yml#132 Local-Gate: v1 tree=2c950185a3067b5cc4cbe5b35ca52f0e93f95698 secs=616 lanes=linux-quick:run Ci-Attestation: {"at":1793013015,"gate":"rust/all/fmt","host":"linux-x86_64","key":"2c3bb76cb0441159126fa4ec521fcd6310a2d7e035f473d4c94a853e228be14a","lane":"linux-quick","parents":["d3cbc411bdd3cef2e0f1530ce7329e419ad0128a"],"secs":616,"stamp":"28097f38de4cd150e88738e80799ec0a","tree":"2c950185a3067b5cc4cbe5b35ca52f0e93f95698","v":1,"via":"run"} Ci-Attestation: {"at":1793013015,"gate":"python/all/static","host":"linux-x86_64","key":"2c3bb76cb0441159126fa4ec521fcd6310a2d7e035f473d4c94a853e228be14a","lane":"linux-quick","parents":["d3cbc411bdd3cef2e0f1530ce7329e419ad0128a"],"secs":616,"stamp":"6bfdb62976dd3f63591120f6465808e5","tree":"2c950185a3067b5cc4cbe5b35ca52f0e93f95698","v":1,"via":"run"} Ci-Attestation: {"at":1793013015,"gate":"rust/x86_64-unknown-linux-gnu/check","host":"linux-x86_64","key":"2c3bb76cb0441159126fa4ec521fcd6310a2d7e035f473d4c94a853e228be14a","lane":"linux-quick","parents":["d3cbc411bdd3cef2e0f1530ce7329e419ad0128a"],"secs":616,"stamp":"55bbf34396eb5c219213c1604b7d0382","tree":"2c950185a3067b5cc4cbe5b35ca52f0e93f95698","v":1,"via":"run"} Ci-Attestation: {"at":1793013015,"gate":"rust/x86_64-unknown-linux-gnu/dylint","host":"linux-x86_64","key":"2c3bb76cb0441159126fa4ec521fcd6310a2d7e035f473d4c94a853e228be14a","lane":"linux-quick","parents":["d3cbc411bdd3cef2e0f1530ce7329e419ad0128a"],"secs":616,"stamp":"dee9cb04d209950dd5abe0546624426b","tree":"2c950185a3067b5cc4cbe5b35ca52f0e93f95698","v":1,"via":"run"} Ci-Attestation: {"at":1793013015,"gate":"rust/x86_64-unknown-linux-gnu/test","host":"linux-x86_64","key":"2c3bb76cb0441159126fa4ec521fcd6310a2d7e035f473d4c94a853e228be14a","lane":"linux-quick","parents":["d3cbc411bdd3cef2e0f1530ce7329e419ad0128a"],"secs":616,"stamp":"ffe11d2c05b5d2b8e71eb303a89ea47f","tree":"2c950185a3067b5cc4cbe5b35ca52f0e93f95698","v":1,"via":"run"} Ci-Attestation: {"at":1793013015,"gate":"python/linux-x64/test","host":"linux-x86_64","key":"2c3bb76cb0441159126fa4ec521fcd6310a2d7e035f473d4c94a853e228be14a","lane":"linux-quick","parents":["d3cbc411bdd3cef2e0f1530ce7329e419ad0128a"],"secs":616,"stamp":"809b8ef9b48ce0f3d8a344f368079986","tree":"2c950185a3067b5cc4cbe5b35ca52f0e93f95698","v":1,"via":"run"} Ci-Attestation: {"at":1793013015,"gate":"general/linux-x64/perf","host":"linux-x86_64","key":"2c3bb76cb0441159126fa4ec521fcd6310a2d7e035f473d4c94a853e228be14a","lane":"linux-quick","parents":["d3cbc411bdd3cef2e0f1530ce7329e419ad0128a"],"secs":616,"stamp":"e42a329c58b20283a2b47476c762c930","tree":"2c950185a3067b5cc4cbe5b35ca52f0e93f95698","v":1,"via":"run"}
zackees
force-pushed
the
ci/rust-017-allow-intentional-nocapture
branch
from
October 26, 2026 11:10
b85fb63 to
b231162
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ci-lint RUST-017 needs_review items left after #1331/#1329 are all deliberate:
EVIDENCE_OUTPUTconstant now carries the allow.Result:
ci-lint precheck --localreports zero RUST-015/016/017 findings.Refs forge-ci/ci.yml#132