Repository navigation
fix(win): track OpenConsole sidecar hosts alongside conhost - #1222
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upstream half of zackees/clud#1367. Coordinated with zackees/clud#1473. ConPTY sidecar launches OpenConsole.exe, but PTY Job assignment and orphan scanning only matched conhost.exe. Match both image names (case-insensitive, exact basename), report the actual host image in orphan diagnostics, and share a pure predicate test across platforms.
RED/GREEN:
soldr cargo test -p running-process-platform-internal --features pty --lib recognizes_system_and_sidecar_console_hostsfailed onOPENCONSOLE.EXEbefore adding it to the predicate; the same command passes after the fix.soldr cargo fmt --all --checkandgit diff --checkpass. Linux platform-internal unit suite: 132 passed, 4 ignored; one unrelated GNU build-ID assertion fails under the local soldr harness and passes when filtered. Windows behavior awaits PR CI.Merge this upstream fix first, then publish 4.10.15 via a separate version-bump PR before the dependent clud PR merges.