-
-
Notifications
You must be signed in to change notification settings - Fork 3
Tests passing on 8.3 and 8.4 #41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
60e5307
70dd1d9
2b06142
67efb07
8e14617
c04849a
1ca788e
322ded2
766852a
e8b662e
6ac4e4d
e8e3dbf
4522d4b
fa3c6d6
7166b2e
fde1686
4eb4a2a
cf82dde
79c05d9
4c10faa
69d2e20
a7a5dc2
64a13a7
5f3f5f8
a92ddc2
38a7f28
2af7588
46c9e52
2cd749c
97dc2a3
46ceb16
c4fb2f3
aecd003
ff3a005
fe129f6
9742bc6
7616e69
20e9d83
5b83fcf
c87bfda
1de5e0c
664c59f
0dd040b
70f9508
6fc4fd3
10a47ab
dd32ad4
b277620
baaa867
7975f61
c51d75a
290c790
b146d1e
7ba0a3f
d56b192
a8d4131
ce02fb3
2a2fd68
16d9ed3
2e5c452
812d44d
b4c73bf
1911c9f
b490eac
c7e5ec6
eb39682
775f7ad
54c8d32
afd0f9d
25a2b10
f4b69a5
df438a0
631b62a
b1397a4
5682793
fc796ed
5f0a48b
7d8f89a
d33215e
6ebb760
801ec70
d24507f
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -31,4 +31,4 @@ jobs: | |
| os: >- | ||
| ['ubuntu-latest'] | ||
| php: >- | ||
| ['8.1', '8.2', '8.3'] | ||
| ['8.3', '8.4'] | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -37,9 +37,8 @@ jobs: | |
| - ubuntu-latest | ||
|
|
||
| php: | ||
| - 8.1 | ||
| - 8.2 | ||
| - 8.3 | ||
| - 8.4 | ||
|
|
||
| mysql: | ||
| - 5.7 | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -37,9 +37,8 @@ jobs: | |
| - ubuntu-latest | ||
|
|
||
| php: | ||
| - 8.1 | ||
| - 8.2 | ||
| - 8.3 | ||
| - 8.4 | ||
|
|
||
| pgsql: | ||
| - 9 | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -33,9 +33,8 @@ jobs: | |
| - ubuntu-latest | ||
|
|
||
| php: | ||
| - 8.1 | ||
| - 8.2 | ||
| - 8.3 | ||
| - 8.4 | ||
|
|
||
| steps: | ||
| - name: Checkout. | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -29,4 +29,4 @@ jobs: | |
| os: >- | ||
| ['ubuntu-latest'] | ||
| php: >- | ||
| ['8.1', '8.2', '8.3'] | ||
| ['8.3', '8.4'] | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -25,4 +25,4 @@ composer.phar | |
| # PhpUnit | ||
| /phpunit.phar | ||
| /phpunit.xml | ||
| /.phpunit.cache | ||
| /.phpunit.cache | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| <?php | ||
|
|
||
| declare(strict_types=1); | ||
|
|
||
| use PhpCsFixer\Config; | ||
| use PhpCsFixer\Finder; | ||
| use PhpCsFixer\Runner\Parallel\ParallelConfigFactory; | ||
|
|
||
| ini_set('memory_limit', '512M'); | ||
|
|
||
| $root = __DIR__; | ||
| $finder = (new Finder()) | ||
| ->in([ | ||
| $root.'/src', | ||
| $root.'/tests', | ||
| ]) | ||
| ->exclude([ | ||
| ]) | ||
| ->append([ | ||
| ]); | ||
|
|
||
| return (new Config()) | ||
| ->setCacheFile(__DIR__ . '/runtime/cache/.php-cs-fixer.cache') | ||
| ->setParallelConfig(ParallelConfigFactory::detect( | ||
| // $filesPerProcess | ||
| 10, | ||
| // $processTimeout in seconds | ||
| 200, | ||
| // $maxProcesses | ||
| 10 | ||
| )) | ||
| ->setRules([ | ||
| '@PER-CS2.0' => true, | ||
| ]) | ||
| ->setFinder($finder); | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,122 @@ | ||
| .PHONY: m p pf pc pu ric riu i co cwn cs cm cu crc rdr rmc ep em es ex ea rp rm rs re x xd | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This style could be adjusted to match one is yiisoft/app for consistency. |
||
|
|
||
| m: | ||
| @echo "================================================================================" | ||
| @echo " Data Cycle SYSTEM MENU (Make targets)" | ||
| @echo "================================================================================" | ||
| @echo "" | ||
| @echo "make p - Run PHP Psalm" | ||
| @echo "make pf FILE=src/Foo.php - Run PHP Psalm on a specific file" | ||
| @echo "make pc - Clear Psalm's cache" | ||
| @echo "make pu - Run PHPUnit tests" | ||
| @echo "make ric - Roave Infection Covered" | ||
| @echo "make riu - Roave Infection Uncovered" | ||
| @echo "make i - Infection Mutation Test" | ||
| @echo "make co - Composer outdated" | ||
| @echo "make cwn REPO=yiisoft/yii-demo VERSION=1.1.1 - Composer why-not" | ||
| @echo "make cs - PHP CS Fixer dry-run" | ||
| @echo "make cm - PHP CS Fixer fix" | ||
| @echo "make cu - Composer update" | ||
| @echo "make crc - Composer require checker" | ||
| @echo "make rdr - Rector Dry Run (see changes)" | ||
| @echo "make rmc - Rector (make changes)" | ||
| @echo "" | ||
| @echo "Extension & DB Test Suite Menu:" | ||
| @echo "make ep - Check PostgreSQL PHP extensions" | ||
| @echo "make em - Check MySQL PHP extensions" | ||
| @echo "make es - Check SQLite PHP extensions" | ||
| @echo "make ex - Check MSSQL PHP extensions" | ||
| @echo "make ea - Check ALL DB PHP extensions" | ||
| @echo "make rp - Run PHPUnit Pgsql test suite" | ||
| @echo "make rm - Run PHPUnit Mysql test suite" | ||
| @echo "make rs - Run PHPUnit Sqlite test suite" | ||
| @echo "make re - Run PHPUnit Mssql test suite" | ||
| @echo "================================================================================" | ||
|
|
||
| p: | ||
| php vendor/bin/psalm | ||
|
|
||
| pf: | ||
| ifndef FILE | ||
| $(error Please provide FILE, e.g. 'make pf FILE=src/Foo.php') | ||
| endif | ||
| php vendor/bin/psalm "$(FILE)" | ||
|
|
||
| pc: | ||
| php vendor/bin/psalm --clear-cache | ||
|
|
||
| pu: | ||
| php vendor/bin/phpunit | ||
|
|
||
| ric: | ||
| php vendor/bin/roave-infection-static-analysis-plugin --only-covered | ||
|
|
||
| riu: | ||
| php vendor/bin/roave-infection-static-analysis-plugin | ||
|
|
||
| i: | ||
| php vendor/bin/infection | ||
|
|
||
| co: | ||
| composer outdated | ||
|
|
||
| cwn: | ||
| ifndef REPO | ||
| $(error Please provide REPO, e.g. 'make cwn REPO=yiisoft/yii-demo VERSION=1.1.1') | ||
| endif | ||
| ifndef VERSION | ||
| $(error Please provide VERSION, e.g. 'make cwn REPO=yiisoft/yii-demo VERSION=1.1.1') | ||
| endif | ||
| composer why-not $(REPO) $(VERSION) | ||
|
|
||
| cs: | ||
| php vendor/bin/php-cs-fixer fix --dry-run --diff | ||
|
|
||
| cm: | ||
| php vendor/bin/php-cs-fixer fix | ||
|
|
||
| cu: | ||
| composer update | ||
|
|
||
| crc: | ||
| php vendor/bin/composer-require-checker | ||
|
|
||
| rdr: | ||
| php vendor/bin/rector process --dry-run | ||
|
|
||
| rmc: | ||
| php vendor/bin/rector | ||
|
|
||
| ep: | ||
| @echo "Checking for pdo_pgsql and pgsql extensions..." | ||
| @php -m | grep -E "^pdo_pgsql$$|^pgsql$$" || (echo 'Missing PostgreSQL extensions!'; exit 1) | ||
|
|
||
| em: | ||
| @echo "Checking for pdo_mysql and mysql extensions..." | ||
| @php -m | grep -E "^pdo_mysql$$|^mysql$$" || (echo 'Missing MySQL extensions!'; exit 1) | ||
|
|
||
| es: | ||
| @echo "Checking for pdo_sqlite and sqlite3 extensions..." | ||
| @php -m | grep -E "^pdo_sqlite$$|^sqlite3$$" || (echo 'Missing SQLite extensions!'; exit 1) | ||
|
|
||
| ex: | ||
| @echo "Checking for pdo_sqlsrv and sqlsrv extensions..." | ||
| @php -m | grep -E "^pdo_sqlsrv$$|^sqlsrv$$" || (echo 'Missing MSSQL extensions!'; exit 1) | ||
|
|
||
| ea: | ||
| $(MAKE) ep | ||
| $(MAKE) em | ||
| $(MAKE) es | ||
| $(MAKE) ex | ||
|
|
||
| rp: | ||
| php vendor/bin/phpunit --testsuite Pgsql | ||
|
|
||
| rm: | ||
| php vendor/bin/phpunit --testsuite Mysql | ||
|
|
||
| rs: | ||
| php vendor/bin/phpunit --testsuite Sqlite | ||
|
|
||
| re: | ||
| php vendor/bin/phpunit --testsuite Mssql | ||
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -9,11 +9,14 @@ | |||||
| [](https://packagist.org/packages/yiisoft/data-cycle) | ||||||
| [](https://packagist.org/packages/yiisoft/data-cycle) | ||||||
| [](https://codecov.io/gh/yiisoft/data-cycle) | ||||||
| [](https://dashboard.stryker-mutator.io/reports/github.com/yiisoft/data-cycle/master) | ||||||
| [](https://dashboard.stryker-mutator.io/reports/github.com/yiisoft/data-cycle/master) | ||||||
| [](https://github.com/yiisoft/data-cycle/actions?query=workflow%3A%22static+analysis%22) | ||||||
| [](https://shepherd.dev/github/yiisoft/data-cycle) | ||||||
| [](https://shepherd.dev/github/yiisoft/data-cycle) | ||||||
|
|
||||||
| [](https://packagist.org/packages/yiisoft/data-cycle) | ||||||
| [](https://packagist.org/packages/yiisoft/data-cycle) | ||||||
|
|
||||||
|
Comment on lines
+17
to
+19
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
I don't think these are particularly useful. We don't have these in any other package. |
||||||
| There package provides [Cycle ORM](https://github.com/cycle/orm) query adapter for[Yii Data](https://github.com/yiisoft/data). For other | ||||||
| integrations of Cycle ORM with Yii framework see [Yii Cycle](https://github.com/yiisoft/yii-cycle) package. | ||||||
|
|
||||||
|
|
||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's no such directory.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still relevant.