Tests passing on 8.3 and 8.4 #41

rossaddison · 2025-09-03T20:40:44Z

Q	A
Is bugfix?	✔️/❌
New feature?	✔️/❌
Breaks BC?	✔️/❌

There should be 14 tests ... as in yiisoft data. Testing with test folder's .env file adjusted for mysql

All tests are linked to yiisoft/data test material.

The two escaped mutants are: 1) C:\wamp64\www\data-cycle\src\Reader\EntityReader.php:189 [M] IncrementInteger @@ @@ public function readOne(): null|array|object { if (!$this->oneItemCache->isCollected()) { - $item = $this->itemsCache->isCollected() ? $this->itemsCache->getGenerator()->current() : $this->withLimit(1)->getIterator()->current(); + $item = $this->itemsCache->isCollected() ? $this->itemsCache->getGenerator()->current() : $this->withLimit(2)->getIterator()->current(); $this->oneItemCache->setCollection($item === null ? [] : [$item]); } /**

Applied yiisoft/data/pull/234 Moved tests folder into psalm.xml - Level 1 tested EntityReader's readOne function's limit(1) has been removed to get the msi to 100. A suitable test needs to be developed to check for the IncrementInteger mutant on the readOne function with the mutant that changes limit(1) to limit(2) still causing a failure with current tests not picking it up mainly due to the \Generator->current returning mixed type where null, array, and object have to be checked in readOne with false also being returned.

Allow the connection to be created even if the password is empty which matches the CI config.

Convert empty string to null

composer.json

package.json

No js dependencies required

runtime/cache/.php-cs-fixer.cache

src/Reader/EntityReader.php

.github/workflows/composer-require-checker.yml

.github/workflows/mssql.yml

samdark · 2025-09-10T20:39:10Z

@rossaddison was it created with the help of LLMs? If so, please at least read it manually. There are tons of obvious weird places to fix. LLM doesn't seem to be able to handle it properly.

rossaddison · 2025-09-10T21:28:03Z

@rossaddison was it created with the help of LLMs? If so, please at least read it manually. There are tons of obvious weird places to fix. LLM doesn't seem to be able to handle it properly.

Please elaborate

samdark · 2025-09-10T22:21:19Z

I mean, it feels generated and seems to need either many iterations or manual checking-fixing to be of acceptable quality.

.github/workflows/mutation.yml

.github/workflows/pgsql.yml

.github/workflows/sqlite.yml

.github/workflows/static.yml

.php-cs-fixer.php

src/Reader/FilterHandler/LikeHandler/SqliteLikeHandler.php

src/Reader/FilterHandler/NotHandler.php

tests/Feature/Base/Writer/BaseEntityWriterTestCase.php

tests/Feature/Mysql/Reader/ReaderWithFilter/ReaderWithLikeTest.php

Co-authored-by: Alexander Makarov <sam@rmcreative.ru>

samdark · 2025-09-11T15:27:42Z

.php-cs-fixer.php

+    ]);
+
+return (new Config())
+    ->setCacheFile(__DIR__ . '/runtime/cache/.php-cs-fixer.cache')


Still relevant.

samdark · 2025-09-11T15:32:09Z

@rossaddison check the diff. There are many comments from previous reviews that were not addressed.

rossaddison added 30 commits August 18, 2025 09:13

Apply yiisoft/data#233

60e5307

Composer update

70dd1d9

Update static.yml

2b06142

Psalm testing: Override Attribute

67efb07

Php 8.3 - 8.4

8e14617

Test All replaced with AndX

c04849a

Update composer.json

1ca788e

Update MySql and Sqlite Tests

322ded2

Update sqlite.yml

766852a

syntax error

e8b662e

Testing: Restructure tests according to yiisoft data

6ac4e4d

There should be 14 tests ... as in yiisoft data. Testing with test folder's .env file adjusted for mysql

Psalm

e8e3dbf

Tests passing locally

4522d4b

All tests are linked to yiisoft/data test material.

Typo mysql to mssql

fa3c6d6

Upgrade LikeHandler postgres and mssql

7166b2e

Test 8.1 and 8.2 workflows

fde1686

Update composer.json

4eb4a2a

Revert to 8.3 and 8.4

cf82dde

Test mssql.yml

79c05d9

Update mssql.yml

4c10faa

Update mssql.yml

69d2e20

Update mssql.yml

a7a5dc2

Update mssql.yml

64a13a7

Update PHP version requirement to 8.3 or higher

a92ddc2

Update README.md

38a7f28

Additional Base Tests - Test 3 - msi 100

46c9e52

Allow the connection to be created even if the password is empty which matches the CI config.

Additional Base Tests - Test 4 - msi 100 - mySql

2cd749c

Additional Base Tests - Test 5 - empty string

97dc2a3

Convert empty string to null

rossaddison added 2 commits September 6, 2025 21:04

styleci

775f7ad

stylci

54c8d32

samdark requested changes Sep 7, 2025

View reviewed changes

composer.json Outdated Show resolved Hide resolved

package.json Outdated Show resolved Hide resolved

rossaddison added 2 commits September 8, 2025 14:53

Update composer.json

afd0f9d

Delete package.json

25a2b10

No js dependencies required

rossaddison requested a review from samdark September 8, 2025 16:27

samdark requested changes Sep 9, 2025

View reviewed changes

runtime/cache/.php-cs-fixer.cache Outdated Show resolved Hide resolved

src/Reader/EntityReader.php Outdated Show resolved Hide resolved

src/Reader/EntityReader.php Outdated Show resolved Hide resolved

src/Reader/EntityReader.php Outdated Show resolved Hide resolved

rossaddison added 2 commits September 10, 2025 17:39

Delete .php-cs-fixer.cache

f4b69a5

Include ImpureMethodCall in psalm.xml

df438a0

rossaddison requested a review from samdark September 10, 2025 20:04

Testing 1

631b62a

samdark requested changes Sep 10, 2025

View reviewed changes

.github/workflows/composer-require-checker.yml Outdated Show resolved Hide resolved

.github/workflows/mssql.yml Outdated Show resolved Hide resolved

rossaddison requested a review from samdark September 10, 2025 21:30

samdark requested changes Sep 10, 2025

View reviewed changes

rossaddison and others added 9 commits September 11, 2025 09:12

Lower msi to 97

b1397a4

Update EntityReader.php

5682793

Update src/Reader/FilterHandler/LikeHandler/SqliteLikeHandler.php

fc796ed

Co-authored-by: Alexander Makarov <sam@rmcreative.ru>

Update src/Reader/FilterHandler/NotHandler.php

5f0a48b

Co-authored-by: Alexander Makarov <sam@rmcreative.ru>

Update tests/Feature/Base/Writer/BaseEntityWriterTestCase.php

7d8f89a

Co-authored-by: Alexander Makarov <sam@rmcreative.ru>

Update .php-cs-fixer.php

d33215e

Merge branch 'master' of https://github.com/rossaddison/data-cycle

6ebb760

Update SqliteLikeHandler.php

801ec70

Update SqliteLikeHandler.php

d24507f

rossaddison requested a review from samdark September 11, 2025 12:41

samdark requested changes Sep 11, 2025

View reviewed changes

.php-cs-fixer.php

]);

return (new Config())

->setCacheFile(__DIR__ . '/runtime/cache/.php-cs-fixer.cache')

Copy link

Member

samdark Sep 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still relevant.

samdark closed this Oct 2, 2025

Uh oh!

Tests passing on 8.3 and 8.4 #41

Tests passing on 8.3 and 8.4 #41

Uh oh!

Conversation

rossaddison commented Sep 3, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

samdark commented Sep 10, 2025

Uh oh!

rossaddison commented Sep 10, 2025

Uh oh!

samdark commented Sep 10, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

samdark Sep 11, 2025

Choose a reason for hiding this comment

Uh oh!

samdark commented Sep 11, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants