Skip to content

fix: Allow readding removed streams/tracks #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
moufmouf merged 1 commit into from
Mar 16, 2026
Merged

fix: Allow readding removed streams/tracks #20

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,8 +137,6 @@ class Peer extends Lite {
this._setPreferredCodecs(track.kind, this._getTransceiverForSender(sender))
}
this._needsNegotiation()
} else if ((sender as RTCRtpSender & { removed?: boolean }).removed) {
throw errCode(new Error('Track has been removed. You should enable/disable tracks that you want to re-add.'), 'ERR_SENDER_REMOVED')
} else {
throw errCode(new Error('Track has already been added to that stream.'), 'ERR_SENDER_ALREADY_ADDED')
}
Expand Down Expand Up @@ -180,7 +178,7 @@ class Peer extends Lite {
throw errCode(new Error('Cannot remove track that was never added.'), 'ERR_TRACK_NOT_ADDED')
}
try {
(sender as RTCRtpSender & { removed?: boolean }).removed = true
submap?.delete(stream);
this._pc!.removeTrack(sender)
} catch (err) {
if ((err as Error).name === 'NS_ERROR_UNEXPECTED') {
Expand Down
Loading