Skip to content

1.21.4: Ensure SyncEntireContainer is not sent before client has started loading in #382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ScoreUnder wants to merge 2 commits into
base: 1.21.4
Choose a base branch
from
Open

1.21.4: Ensure SyncEntireContainer is not sent before client has started loading in #382

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0ee5e13
Ensure SyncEntireContainer is not sent before client has started load…
ScoreUnder Feb 25, 2026
2a09ed9
style: use "var" for variable decls
ScoreUnder Feb 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions common/src/main/java/io/wispforest/accessories/impl/AccessoriesCapabilityImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,8 @@
import io.wispforest.endec.util.MapCarrier;
import io.wispforest.owo.serialization.RegistriesAttribute;
import it.unimi.dsi.fastutil.Pair;
import net.minecraft.core.RegistryAccess;
import net.minecraft.server.MinecraftServer;
import net.minecraft.server.level.ServerPlayer;
import net.minecraft.world.entity.LivingEntity;
import net.minecraft.world.entity.ai.attributes.AttributeModifier;
Expand Down Expand Up @@ -96,11 +98,17 @@ public void reset(boolean loadedFromTag) {

if (!(this.entity instanceof ServerPlayer serverPlayer) || serverPlayer.connection == null) return;

var carrier = NbtMapCarrier.of();
var registryAccess = this.entity.level().registryAccess();

holder.write(carrier, SerializationContext.attributes(RegistriesAttribute.of(this.entity.level().registryAccess())));
// Defer update packet until end of tick because client may still be connecting at this point
var server = serverPlayer.server;
server.schedule(server.wrapRunnable(() -> {
var carrier = NbtMapCarrier.of();

AccessoriesNetworking.sendToTrackingAndSelf(serverPlayer, new SyncEntireContainer(serverPlayer.getId(), carrier));
holder.write(carrier, SerializationContext.attributes(RegistriesAttribute.of(registryAccess)));

AccessoriesNetworking.sendToTrackingAndSelf(serverPlayer, new SyncEntireContainer(serverPlayer.getId(), carrier));
}));
}

private boolean updateContainersLock = false;
Expand Down