1.21.4: Ensure SyncEntireContainer is not sent before client has started loading in#382
Open
ScoreUnder wants to merge 2 commits intowisp-forest:1.21.4from
Open
1.21.4: Ensure SyncEntireContainer is not sent before client has started loading in#382ScoreUnder wants to merge 2 commits intowisp-forest:1.21.4from
ScoreUnder wants to merge 2 commits intowisp-forest:1.21.4from
Conversation
ScoreUnder
changed the title
Noaaan
suggested changes
Feb 25, 2026
common/src/main/java/io/wispforest/accessories/impl/AccessoriesCapabilityImpl.java
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing the root cause of the stack trace shown in wisp-forest/owo-lib#466
We should wait until the client has spawned their player object before we send packets that concern the player. There is probably a better way of doing this but I'm not sure :)