GuiText: Fix color preset.#5
Open
V10lator wants to merge 1 commit into
Open
Conversation
It's broken and instead of searching a fix we can just remove the useless transitions between GX2ColorF32 and glm::vec4. Signed-off-by: Thomas Rohloff <v10lator@myway.de>
Author
|
You're probably right on this but then again: Why convert from glm::vec4 to GX2ColorF32 in the first place? All instances where it gets read out convert it back to glm::vec4, that's what I meanded with "useless transitions". *I'm even compiling libgui with way more agressive FLAGS: Didn't make a pull request for that yet as it's highly experimental and I want to make sure it doesn't break anything before. [EDIT]Also LTO might not be feasible upstream as all projects using the library would need to be compiled with LTO, too.[/EDIT] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's broken and instead of searching a fix we can just remove the useless transitions between GX2ColorF32 and glm::vec4.