Skip to content

GuiText: Fix color preset.#5

Open
V10lator wants to merge 1 commit into
wiiu-env:masterfrom
V10lator:presetText
Open

GuiText: Fix color preset.#5
V10lator wants to merge 1 commit into
wiiu-env:masterfrom
V10lator:presetText

Conversation

@V10lator

Copy link
Copy Markdown

It's broken and instead of searching a fix we can just remove the useless transitions between GX2ColorF32 and glm::vec4.

It's broken and instead of searching a fix we can just remove the useless transitions between GX2ColorF32 and glm::vec4.

Signed-off-by: Thomas Rohloff <v10lator@myway.de>
@V10lator

V10lator commented May 26, 2020

Copy link
Copy Markdown
Author

You're probably right on this but then again: Why convert from glm::vec4 to GX2ColorF32 in the first place? All instances where it gets read out convert it back to glm::vec4, that's what I meanded with "useless transitions".
I also think as a GUI library the codes should be as fast as possible* so converting back and forth shouldn't be done (esp if it's for no reason).

*I'm even compiling libgui with way more agressive FLAGS:

	@sed -i 's/-save-temps/-pipe/g' libgui/Makefile
	@sed -i '/			-ffunction-sections -fdata-sections \\/d' libgui/Makefile
	@sed -i 's/$$(ARCH) -/$$(ARCH) $$(CFLAGS) -/g' libgui/Makefile
	@sed -i 's/-DNDEBUG=1 -O2 -s/$(LIBGUIFLAGS)/g' libgui/Makefile
	@cd libgui && for patch in $(TOPDIR)/libgui-patches/*.patch; do echo Applying $$patch && git apply $$patch; done && $(MAKE)
release:	LIBGUIFLAGS	:=	-Ofast -flto=auto -fno-fat-lto-objects \
							-fuse-linker-plugin -s -DNDEBUG=1

Didn't make a pull request for that yet as it's highly experimental and I want to make sure it doesn't break anything before. [EDIT]Also LTO might not be feasible upstream as all projects using the library would need to be compiled with LTO, too.[/EDIT]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants