Skip to content

Change popover invoking attributes to use Element reflection #37815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chromium-wpt-export-bot merged 1 commit into from
Jan 10, 2023
Merged

Change popover invoking attributes to use Element reflection #37815

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions html/semantics/popovers/popover-invoking-attribute.tentative.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,10 @@
return el;
};
}
function setInvokingContentAttribute(invoker,attr,idref) {
invoker.setAttribute(attr,idref);
assert_equals(invoker[attr + "Element"],document.getElementById(idref));
}
const supportedButtonTypes = ['button','reset','submit',''].map(type => {
return {
name: `<button type="${type}">`,
Expand Down Expand Up @@ -85,13 +89,13 @@
assert_not_equals(popover1.id,popover2.id);
const invoker = testcase.makeElement(test);
if (use_idl) {
invoker.popoverToggleTarget = t===1 ? popover1.id : (t===2 ? popover2.id : null);
invoker.popoverShowTarget = s===1 ? popover1.id : (s===2 ? popover2.id : null);
invoker.popoverHideTarget = h===1 ? popover1.id : (h===2 ? popover2.id : null);
invoker.popoverToggleTargetElement = t===1 ? popover1 : (t===2 ? popover2 : null);
invoker.popoverShowTargetElement = s===1 ? popover1 : (s===2 ? popover2 : null);
invoker.popoverHideTargetElement = h===1 ? popover1 : (h===2 ? popover2 : null);
} else {
if (t) invoker.setAttribute('popovertoggletarget',t===1 ? popover1.id : popover2.id);
if (s) invoker.setAttribute('popovershowtarget',s===1 ? popover1.id : popover2.id);
if (h) invoker.setAttribute('popoverhidetarget',h===1 ? popover1.id : popover2.id);
if (t) setInvokingContentAttribute(invoker,'popoverToggleTarget',t===1 ? popover1.id : popover2.id);
if (s) setInvokingContentAttribute(invoker,'popoverShowTarget',s===1 ? popover1.id : popover2.id);
if (h) setInvokingContentAttribute(invoker,'popoverHideTarget',h===1 ? popover1.id : popover2.id);
}
assert_true(!document.getElementById(popover1.id));
assert_true(!document.getElementById(popover2.id));
Expand Down
2 changes: 1 addition & 1 deletion html/semantics/popovers/popover-top-layer-combinations.tentative.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@
document.body.appendChild(button);
assert_equals(ex.id,'');
ex.id = 'popover-id';
button.popoverToggleTarget = ex.id;
button.popoverToggleTargetElement = ex;
assert_true(ex.matches(':closed'));
await clickOn(button);
ensureIsOpenPopover(ex,'Invoking element should be able to invoke all popovers');
Expand Down
8 changes: 3 additions & 5 deletions interfaces/popover.tentative.idl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,9 @@ partial interface HTMLElement {
};

interface mixin PopoverTargetElement {
// TODO(crbug.com/1405856): These might change to `Element`, or additional
// attributes like `popoverToggleTargetElement` might be added for that.
[CEReactions] attribute DOMString? popoverToggleTarget;
[CEReactions] attribute DOMString? popoverHideTarget;
[CEReactions] attribute DOMString? popoverShowTarget;
[CEReactions] attribute Element? popoverToggleTargetElement;
[CEReactions] attribute Element? popoverHideTargetElement;
[CEReactions] attribute Element? popoverShowTargetElement;
};
HTMLInputElement includes PopoverTargetElement;
HTMLButtonElement includes PopoverTargetElement;
Expand Down