Change popover invoking attributes to use Element reflection#37815
Merged
Conversation
wpt-pr-bot
approved these changes
Jan 9, 2023
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
Collaborator
There was a problem hiding this comment.
The review process for this patch is being conducted in the Chromium project.
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4148056
branch
from
e0e8c51 to
cd639e6
Compare
Per the conversation at [1], we've decided to make the IDL reflections of the invoking attributes (popovertoggletarget, popovershowtarget, and popoverhidetarget) use Element reflection, and be named accordingly. [1] whatwg/html#8221 (comment) Fixed: 1405856 Bug: 1307772 Change-Id: Iace783795c2db7a19e11fbc4f0c4da33a8765779 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4148056 Auto-Submit: Mason Freed <masonf@chromium.org> Commit-Queue: Mason Freed <masonf@chromium.org> Reviewed-by: Joey Arhar <jarhar@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/main@{#1090582}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4148056
branch
from
cd639e6 to
cf10006
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per the conversation at [1], we've decided to make the IDL reflections
of the invoking attributes (popovertoggletarget, popovershowtarget, and
popoverhidetarget) use Element reflection, and be named accordingly.
[1] whatwg/html#8221 (comment)
Fixed: 1405856
Bug: 1307772
Change-Id: Iace783795c2db7a19e11fbc4f0c4da33a8765779
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4148056
Auto-Submit: Mason Freed <masonf@chromium.org>
Commit-Queue: Mason Freed <masonf@chromium.org>
Reviewed-by: Joey Arhar <jarhar@chromium.org>
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1090582}