Skip to content

fix: correct inert CodeRabbit keys (osv-scanner -> osvScanner, github_checks -> github-checks) #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yakimoto merged 4 commits into from
Aug 7, 2026
+12 −2
Merged

fix: correct inert CodeRabbit keys (osv-scanner -> osvScanner, github_checks -> github-checks) #46

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f79476a
fix: correct osv-scanner -> osvScanner, turning OSV scanning ON
yakimoto Aug 6, 2026
32ec516
fix: correct github_checks -> github-checks, same inert-key class
yakimoto Aug 6, 2026
2daab70
Merge branch 'main' into fix/coderabbit-osvscanner-key
yakimoto Aug 7, 2026
a1cf33a
chore: re-trigger review on the current head
yakimoto Aug 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions .coderabbit.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,12 @@ reviews:
enabled: true
semgrep:
enabled: true
osv-scanner:
# The schema key is `osvScanner`, camelCase. This read `osv-scanner` since the file was
# written; `tools` allows additional properties, so CodeRabbit accepted the misspelling
# silently and ran no OSV scanning at all. Verified against the live v2 schema
# (storage.googleapis.com/coderabbit_public_assets/schema.v2.json, 2026-08-06): the 57 tool
# keys include `osvScanner` and do not include `osv-scanner`. (#1083)
osvScanner:
enabled: true
Comment thread
devin-ai-integration[bot] marked this conversation as resolved.
shellcheck:
enabled: true
Expand All @@ -90,7 +95,12 @@ reviews:
enabled: true
packages:
- "ast-grep-essentials"
Comment on lines 95 to 97

@devin-ai-integration devin-ai-integration Bot Aug 7, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Remaining tool keys in the block were not re-verified in this PR

The PR fixes two mis-keyed entries but leaves the rest (gitleaks, semgrep, shellcheck, yamllint, markdownlint, actionlint, ruff, ast-grep) untouched. Since tools accepts additional properties, any other typo would be equally silent. These names do appear to match the documented schema, but the same verification pass that caught these two is worth applying once to the whole block so no other entry is silently inert.

(Refers to lines 72-97)

Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

@blacksmith-sh blacksmith-sh Bot Aug 7, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran the requested verification pass against the live v2 schema (schema.v2.json): all remaining tool keys (gitleaks, semgrep, shellcheck, yamllint, markdownlint, actionlint, ruff, ast-grep) and their sub-keys (packages, enabled, timeout_ms) exactly match documented schema keys. No other entry is inert, so no change is required.

github_checks:
# Same inert-key class as `osvScanner` above: the schema key is `github-checks`
# (hyphenated), not `github_checks`, so this block was silently accepted and ignored —
# GitHub Checks integration ran on its 90s default, not the 900s configured here.
# Verified against the live v2 schema (2026-08-06), which defines `github-checks` with
# `enabled` and `timeout_ms` (max 900000). (#1083)
github-checks:
enabled: true
timeout_ms: 900000
Comment on lines +98 to 105

@devin-ai-integration devin-ai-integration Bot Aug 7, 2026 •
edited
Loading

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 Info: Key renames enable previously inert tools — behavioral side effects worth expecting

Renaming osv-scanner -> osvScanner and github_checks -> github-checks moves both blocks from silently ignored to actively honored. Practically this means OSV dependency scanning will now run on PRs (potentially producing a burst of new findings on existing dependencies in sdk/ and edge-router/) and the GitHub Checks wait rises from the 90s default to the configured 900s, which can noticeably lengthen time-to-first-review. Both are the intended effect of the fix, but reviewers should expect the first few PRs after merge to look different.

Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.


Expand Down
Loading