fix: correct inert CodeRabbit keys (osv-scanner -> osvScanner, github_checks -> github-checks) - #46
fix: correct inert CodeRabbit keys (osv-scanner -> osvScanner, github_checks -> github-checks)#46yakimoto wants to merge 3 commits into
Conversation
`.coderabbit.yaml` has configured `reviews.tools.osv-scanner: enabled: true` since the file was written. That is not a key in CodeRabbit's v2 schema. The schema's `tools` object allows additional properties, so the misspelling was accepted silently and OSV dependency scanning has never run in this repo — the config READ as an enabled security scanner while gating nothing. Verified against the live schema rather than from memory (storage.googleapis.com/coderabbit_public_assets/schema.v2.json, fetched 2026-08-06): its 57 `reviews.tools` keys include `osvScanner` and do not include `osv-scanner`. Found by the RF.P6 fleet census (wave-av/claude-workstation#1995), which classifies a config surface as `inert` when it carries a key the vendor's schema silently drops. 12 live repos carry this same misspelling; this is one of them, shipping as its own PR so the before/after finding count is attributable per repo. This turns a security scanner ON. Expect new dependency-vulnerability findings on the next review here — that is the point, and they are pre-existing exposures that were simply never being reported. Refs wave-av/claude-workstation#1083 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_4a1b7f4c-54d1-4164-a15f-0c31f16a9eb0) |
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 46 minutes Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Comment |
PR Summary by QodoFix CodeRabbit OSV scanner config key to enable dependency scanning
AI Description
Diagram
High-Level Assessment
Files changed (1)
|
| osvScanner: | ||
| enabled: true |
There was a problem hiding this comment.
🔍 Enabling OSV scanning may surface new blocking findings
This flips OSV dependency scanning from silently disabled to actually running on every review. Since auto_approve.conditions.allowed_severities is limited to low/medium (.coderabbit.yaml:34-36), any high-severity OSV advisory in existing lockfiles will now block auto-approval and hence automerge. Worth confirming the current dependency set is clean before merging, otherwise the automerge pipeline may stall unexpectedly.
Was this helpful? React with 👍 or 👎 to provide feedback.
There was a problem hiding this comment.
Surfacing previously hidden OSV findings is the intended outcome of this PR, as stated in its description; any auto-approval blocks from high-severity advisories reflect real pre-existing exposure, not a config problem to fix here.
ApprovabilityVerdict: Needs human review Unable to check for correctness in 32ec516. This PR enables OSV security scanning and GitHub Checks that were previously silently disabled due to schema key typos. While the diff is small, it changes CI/CD pipeline behavior - PRs may now be blocked by high-severity vulnerability findings that were previously not detected. The unresolved review comment raises a valid concern about verifying existing dependencies before enabling this scanning. No code changes detected at You can customize Macroscope's approvability policy. Learn more. |
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require reviewTo customize comments, go to the Qodo configuration screen, or learn more in the docs. |
Qodo FixerNo findings are available for this PR yet. Findings appear here once Qodo has reviewed the PR. |
There was a problem hiding this comment.
No issues found across 1 file
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Heads up: you’re close to your included review allowance. Set a flex budget so reviews don’t pause.
Re-trigger cubic
The schema key is `github-checks` (hyphenated). `github_checks` was silently accepted and ignored, so GitHub Checks ran on its 90s default rather than the 900s configured here. Verified against the live v2 schema (2026-08-06). Refs wave-av/claude-workstation#1083
| # Same inert-key class as `osvScanner` above: the schema key is `github-checks` | ||
| # (hyphenated), not `github_checks`, so this block was silently accepted and ignored — | ||
| # GitHub Checks integration ran on its 90s default, not the 900s configured here. | ||
| # Verified against the live v2 schema (2026-08-06), which defines `github-checks` with | ||
| # `enabled` and `timeout_ms` (max 900000). (#1083) | ||
| github-checks: | ||
| enabled: true | ||
| timeout_ms: 900000 |
There was a problem hiding this comment.
🔍 Second rename (github_checks -> github-checks) is outside the stated PR scope
The PR title and primary description only cover the osv-scanner -> osvScanner rename, but this diff also renames github_checks -> github-checks (.coderabbit.yaml:98-105). That second rename activates a previously-inert 900000 ms GitHub Checks timeout, meaning CodeRabbit will now wait up to 15 minutes for checks instead of the 90 s default — a real change in review latency worth acknowledging explicitly. Worth confirming against the live schema that timeout_ms max is indeed 900000 so the value is not rejected once the key is actually parsed.
Was this helpful? React with 👍 or 👎 to provide feedback.
The config read as an enabled security scanner and gated nothing
.coderabbit.yamlhas carried this since the file was written:osv-scanneris not a key in CodeRabbit's v2 schema. The schema'stoolsobject does not setadditionalProperties: false, so the misspelling was accepted silently — no warning, no error, and no OSV dependency scanning has ever run in this repo.Grounded against the live schema rather than from memory (
storage.googleapis.com/coderabbit_public_assets/schema.v2.json, fetched 2026-08-06):osvScannerosv-scannertools.additionalPropertiesBefore / after
This turns a security scanner on. New dependency-vulnerability findings are the expected outcome, not a regression.
Second rename in this diff:
github_checks->github-checksSame inert-key class, same file. The schema key is hyphenated
github-checks; the underscore spelling was silently accepted and ignored, so the GitHub Checks integration ran on its 90 s defaulttimeout_ms, not the 900000 ms configured here. With the key now parsed, CodeRabbit will wait up to 15 minutes for checks to conclude, which is a real change in review latency and the intended behavior of the original config.Confirmed against the live v2 schema (fetched 2026-08-07):
reviews.tools.github-checks.timeout_mshasmaximum: 900000, so the configured value sits exactly at the allowed max and is not rejected once the key is parsed.How it was found
The RF.P6 fleet census (wave-av/claude-workstation#1995) classifies a vendor surface as
inertwhen it carries a key the vendor's schema silently drops — the difference between config that reads like a control and config that is one. 12 live repos carry this same misspelling. Each ships as its own PR so the before/after count is attributable per repo rather than averaged across a fleet-wide sweep.Refs wave-av/claude-workstation#1083
🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is enabled.Note
Medium Risk
Turns on OSV scanning and changes GitHub Checks wait behavior during CodeRabbit reviews; may add new security findings and longer review waits, but does not alter runtime application code.
Overview
Fixes silent no-op CodeRabbit
reviews.toolsentries in.coderabbit.yamlby renaming keys to match the live v2 schema.osv-scanner→osvScanner— dependency OSV scanning was never running despiteenabled: true. After merge, reviews should surface dependency vulnerabilities that were previously invisible.github_checks→github-checks— the configured 900000ms wait for GitHub Checks was ignored; integration fell back to the 90s default.Inline comments document the schema verification (#1083). No application code changes — only review-time scanner behavior changes.
Reviewed by Cursor Bugbot for commit 2daab70. Configure here.
Note
Fix tool key names in
.coderabbit.yamlto activate OSV scanning and GitHub Checksosv-scannertoosvScannerin .coderabbit.yaml so the OSV scanner tool key matches the schema and scanning actually runs.github_checkstogithub-checksso the 900000ms timeout and enabled state are correctly applied.Macroscope summarized 2daab70.