Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sdk/rust/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ categories = ["api-bindings"]
[dependencies]
ureq = "2"
serde_json = "1"
base64 = "0.22" # 0.5.1 β€” wallet_hook(privy) needs Basic auth encoding
base64 = "0.23" # 0.5.1 β€” wallet_hook(privy) needs Basic auth encoding

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ” Verify base64 0.23 exists and API compatibility

This bumps the base64 dependency from 0.22 to 0.23. Because pre-1.0 crates treat the minor version as the semver-breaking component, 0.23 is a breaking upgrade and must actually exist on crates.io for the build to resolve. The SDK uses the engine API in sdk/rust/src/lib.rs:30 (base64::engine::general_purpose::URL_SAFE_NO_PAD.encode) and sdk/rust/src/lib.rs:234 (STANDARD.encode); if 0.23 renames or reorganizes general_purpose/Engine, both call sites need updating. There is no Cargo.lock committed for sdk/rust, so nothing here pins/validates resolution β€” a CI build of the SDK crate is the only signal. Worth confirming the release exists and that cargo build for sdk/rust passes before merge.

Open in Devin Review

Was this helpful? React with πŸ‘ or πŸ‘Ž to provide feedback.

urlencoding = "2" # 0.5.1 β€” wallet_hook(privy) URL-encodes the wallet_id path segment
p256 = { version = "0.13", features = ["pkcs8", "ecdsa"] } # 0.6.2 β€” CDP-JWT (ES256) signing
rand_core = "0.6" # 0.6.2 β€” nonce randomness for CDP-JWT
Loading