chore(deps): update rust crate base64 to 0.23 - #38
Conversation
|
0f22a5c to
2f349ac
Compare
|
PR author is in the excluded authors list. |
| ureq = "2" | ||
| serde_json = "1" | ||
| base64 = "0.22" # 0.5.1 — wallet_hook(privy) needs Basic auth encoding | ||
| base64 = "0.23" # 0.5.1 — wallet_hook(privy) needs Basic auth encoding |
There was a problem hiding this comment.
🔍 Verify base64 0.23 exists and API compatibility
This bumps the base64 dependency from 0.22 to 0.23. Because pre-1.0 crates treat the minor version as the semver-breaking component, 0.23 is a breaking upgrade and must actually exist on crates.io for the build to resolve. The SDK uses the engine API in sdk/rust/src/lib.rs:30 (base64::engine::general_purpose::URL_SAFE_NO_PAD.encode) and sdk/rust/src/lib.rs:234 (STANDARD.encode); if 0.23 renames or reorganizes general_purpose/Engine, both call sites need updating. There is no Cargo.lock committed for sdk/rust, so nothing here pins/validates resolution — a CI build of the SDK crate is the only signal. Worth confirming the release exists and that cargo build for sdk/rust passes before merge.
Was this helpful? React with 👍 or 👎 to provide feedback.
ApprovabilityVerdict: Needs human review Unable to check for correctness in 2f349ac. Dependency update to base64 0.23 touches a file owned by wave-av/streaming-team (not owned by renovate bot). An open review comment raises valid concerns about verifying the new version exists and passes CI build. The designated code owners should verify this update. No code changes detected at You can customize Macroscope's approvability policy. Learn more. |
2f349ac to
a649734
Compare
a649734 to
7492384
Compare
This PR contains the following updates:
0.22→0.23Release Notes
marshallpierce/rust-base64 (base64)
v0.23.1Compare Source
v0.23.0Compare Source
simd-unsafefeature:Simdpicks the bestinstruction set at runtime (AVX2 on
x86_64, NEON onaarch64) and falls back to the scalarGeneralPurposeengine, whileAvx2andNeontarget one instruction set with no runtimedetection and work in
no_std. The engines support the standard and URL-safe alphabets.Configuration
📅 Schedule: (UTC)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.