Repository navigation
feat: Add verified household administration workspace (#27) - #28
Conversation
|
To preview the documentation for this pull request, visit the following URL:
|
Bugbot: review complete
|
There was a problem hiding this comment.
Current status: All findings originating in this review are resolved.
Last reconciled on3e10c39. See aggregate Bugbot status.
🤖 Bugbot review snapshot
Bugbot reported 1 potential problem when commit 58957fc was analyzed. This snapshot is historical; use the status block above for current state. 1 finding is linked to changed code.
Findings
- medium: Clear drafts when the verified household changes —
frontend/src/presentation/domus-administration.ts:43
There was a problem hiding this comment.
Current status: All findings originating in this review are resolved.
Last reconciled on3e10c39. See aggregate Bugbot status.
🤖 Bugbot review snapshot
Bugbot reported 1 potential problem when commit 9ba10d7 was analyzed. This snapshot is historical; use the status block above for current state. 1 finding is linked to changed code.
Findings
- medium: Use value assertions for household draft inputs —
frontend/tests/e2e/administration.spec.ts:204
There was a problem hiding this comment.
Current status: All findings originating in this review are resolved.
Last reconciled on3e10c39. See aggregate Bugbot status.
🤖 Bugbot review snapshot
Bugbot reported 1 potential problem when commit 2155e4b was analyzed. This snapshot is historical; use the status block above for current state. 1 finding is linked to changed code.
Findings
- low: Example links point to missing sections —
specs/household-administration-browser.md:223
There was a problem hiding this comment.
Current status: All findings originating in this review are resolved.
Last reconciled on3e10c39. See aggregate Bugbot status.
🤖 Bugbot review snapshot
Bugbot reported 1 potential problem when commit 127cb48 was analyzed. This snapshot is historical; use the status block above for current state. 1 finding is linked to changed code.
Findings
- medium: Wrong-identity test includes the valid first sequence number —
tests/python/test_image_channel.py:115
Refs #27. Add the English/Spanish household administration workspace in native Ingress and standalone: verified identity/roster, public aliases, owner-private preferences, household settings, participant profiles/ordinary exceptions and HA administrator mapping. Every command uses current authority, the original exact revision/payload/key and stable participant reference. Changed or missing verified household proof retires private drafts and detached callbacks.
Deliver the workspace as Edge.7. The Supervisor recipe pins runtime
3200bd9278f57f142ed03b54843a38a4138fc0afand its verified archive;addon-edge/artifact.jsondeclares all 151 Python and four UI fingerprints. Edge.5's installed recipe remains byte-identical in a separate non-discoverable compatibility fixture. Schema 9 upgrades preserve supported older data/history; old images refuse new data without changing it.Edge.7 fixes the prior package's implicit hot-backup policy with a tests-first
backup: coldcontract. Supervisor stops Domus while copying private SQLite storage. The distinct package version keeps Edge.6's runtime/UI/schema, private listener and Core permission scope. Operator guidance distinguishes readable warm archives, stopped-app captures, prior-state-aware restart and restoration that retains later processing evidence.Current test/evidence head:
3e10c3935c254115aa4066736d28415a135dc3a9. Five retained identity/profile acceptance boundaries now have explicit assertions: verified/neutral labels in both languages, the exact unavailable-source roster identity set, full actual task/performance authorship across archive/reactivation, no invented recurrence history for genuine pre-8 migrations, and deliberately persisted orphan-profile rejection without repair. Local full backend passes 4,404 tests at 100% supported global/per-module statement/branch coverage across 151 modules; Chromium passes 1,263 tests at 100% of all four metrics across 31 authored runtime files, with independent inventories. Strict frontend types, changed-test Ruff checks and documentation validation pass. Current CI Check passes all ten jobs. Current native review completes all 13 partitions with complete context and no findings; candidate/published/overflow/open/reopened/verification-required/unknown are zero and all seven historical threads remain resolved. The separate current progress scope-clause-limit failure is recorded in copilot#828.Previous fully verified test/evidence head:
e5f08ebe46f1ae3e2f81080746c0fd76c705b9fc. It added six explicit HA directory boundary cases. Runtime, Edge.7 installation definition and artifact fingerprints remain unchanged across both test-only increments. The following hosted results refer to that prior head:The new provider acceptance covers exactly 256 distinct canonical accounts, preserving order, names, eligibility and the exact own subject at the final position. Distinct 257-account overflow or a malformed 256th account makes the entire directory unavailable. Native credentials never use their own current_user as human fallback; standalone may independently verify only its own subject. All six controls pass against the existing runtime: this strengthens household-admin-C47 and does not claim a new production bug or a complete UI selector acceptance.
On the owner's actual HA, the authorized Edge.7 package is now installed, configured with the local browser origin and running through Ingress with the existing HA sign-in. Chrome dogfooding exercised explicit fresh-household creation, an own-alias change and reversal, saved English/Spanish preferences and summary opt-in/out, a reversible household-name change, and original-result lookup after later changes. Full page reloads and one application restart retained the current household, independent revisions and private preferences; reopening reverified the current HA identity without another login. Participant and access-rule forms were inspected and cancelled without changing authority. With the owner's explicit development-data authorization, the old Edge.3 and Edge.5 app instances were uninstalled; Edge.7 is the only installed Domus app. The prior selected-app cold backup remains a temporary rollback input. This is fresh-install agent dogfooding, not a demonstrated owner-data upgrade, restored owner backup or second-human UX approval. Private owner identifiers and screenshots are not published.
The current assessment-text-limit failure, exact diagnostic and independent no-findings review are recorded in copilot#829. The recurring progress-publication scope failure is reported with exact commit/job/timestamp/reference and preserved state in copilot#828. The typed-JSON false premise and independent controls are in copilot#875. Neither report relaxes product acceptance. Copilot source/resources/configuration/workflows/models/credentials/bounds and gateway remain untouched.
Continue full acceptance on this issue/ref. All 20 owning documents and 186 required cases remain; complete semantic audit, remaining human UX and owner restore/adoption acceptance remain unfinished. The owner understands the initial alias/language/review flow but requests less visible technical detail and immediate access to tasks/calendar; no full UX approval is inferred. Tasks and calendar UI are the next priority in #23 / PR #29. Evidence and limits are in docs/evidence/household-administration-browser.json and docs/household-administration-operations.md. Issue #23 recurrence/calendar, remaining domains, HA services/entities and complete Stable/Edge product remain required. This PR does not claim full product completion.