Skip to content

fix: ground async review in complete statements and lifecycle evidence (#848) - #877

Merged
efraespada merged 2 commits into
developfrom
bugfix/848-bugbot-reports-a-missing-lit-update-await-that-is-already-present-in-the-reviewed-source
Nov 3, 2026
Merged

efraespada merged 2 commits into
developfrom
bugfix/848-bugbot-reports-a-missing-lit-update-await-that-is-already-present-in-the-reviewed-source

Conversation

@efraespada

@efraespada efraespada commented Nov 3, 2026 •

Copy link
Copy Markdown
Member

Fixes #848.

Bugbot reported that a Lit test omitted the wait between closed and ready views, although the exact source already awaited that update on the same line. Source-bound review now reads complete statements, traces receiver/current-cycle/helper ownership and reached lifecycle writes, and omits hypotheses that their own evidence disproves. Real unfinished-update defects remain reportable.

One pure shared instruction reaches ordinary/partitioned/framed source review and the actual benchmark. Existing ports, schemas, Python candidate-verification activation, source/traffic limits, finding history and permissions remain unchanged. The companion SDD, owner/catalog and detection/quality docs are aligned. No finding-text filter, new product setting, dependency or production executor is added.

Fresh execution of the unchanged original consumer head ecdd85b4 passes the selected test (1 passed, 54 not selected) and the complete frontend (11 files / 565 tests, all four coverage metrics 100%); all 52 selected source blobs remain unchanged. The historical native frontend gate was independently inspected and its merge checkout has that exact head's tree. The original finding had already been marked resolved before this work; no consumer source or review history was changed.

Eighteen deterministic SDK regressions bind twelve fixed owned controls to exact source and real Lit 3.3.3 / Chromium observations, enforce opposite-verdict scorer controls, and verify delivery/privacy/legacy/query accounting. A versioned optional runner and repeatable command reproduce all twelve observations; relative SDK, wrong package pin and existing-output guards pass. It is contributor test infrastructure and adds no mandatory browser/Lit runtime dependency.

Actual qualification evidence retains all three baseline trials, both rejected distinct source revisions, all three final trials, predictions, scores and source/runtime identities. Frozen inputs/references/anchors and thresholds never change. The baseline has 10 false positives; the final three-trial aggregate passes every unchanged floor with zero false positives, recall 17/18 and exact locations 14/17. One delayed-descendant defect is omitted and three anchors are imprecise. Final trial 1 fails its individual location floor, trial 2 fails recall and trial 3 passes. This is bounded controlled evidence, not a full historical model replay or general accuracy guarantee.

Local validation passes: 881 Jest suites / 17,184 tests (35 existing skips), all 18 new cases, 267 extension tests with every coverage metric at 100%, and exhaustive coverage of the new pure module (one executable statement, zero functions/branches). Full-suite LCOV hits 3/3 modified coverable lines with zero misses/partials against 04ae6b2f. Existing setup human acceptances remain unchanged. Types, lint, specs/catalog, docs/navigation/agent docs, workflow contracts and Graphify pass. Bundles synchronize and the 96-file npm package passes CLI, typed Bugbot API and isolated local web smoke. Both normal commits pass full build/Jest/lint hooks; measured runtime/CLI hashes remain identical.

Remote acceptance passes for head 91aac4c6b03e56ae7cd7f22fbfe0bc1ef6e040d0 against base 04ae6b2f25d6bfdc7cf98cf121df178a4ac56746: CI, Commit, Branch Sync and Linux/macOS/Windows pass. All three native checkouts have parents [base, head], the exact head tree and one successful deferred-cleanup footer; actual Linux Firefox ESR passes 19 assertions on the matching extension input digest. The full review completes 2/2 partitions with no omissions, findings or open threads. Official Codecov confirms 3/3 modified coverable lines hit, zero misses and zero partials, at the exact base/head. Base coverage refresh 41704966530 also passes. Copilot / Approval is advisory neutral for protected paths; native develop rules require the strict CI Check and no additional review. The standing maintainer authorization applies to an ordinary exact-head merge; no native approval, check or protection is changed.

…present-in-the-reviewed-source: ground asynchronous findings in complete statements and lifecycle evidence
…present-in-the-reviewed-source: publish the repeatable owned Lit qualification runner and its operator instructions
@docs-page

docs-page Bot commented Nov 3, 2026

Copy link
Copy Markdown

To preview the documentation for this pull request, visit the following URL:

docs.page/vypdev/copilot~877

Documentation is deployed and generated using docs.page

@vypbot
vypbot self-requested a review November 3, 2026 20:45
@vypbot vypbot added this to vypdev Nov 3, 2026
@vypbot vypbot moved this to In Progress in vypdev Nov 3, 2026
@vypbot
vypbot changed the base branch from develop to master November 3, 2026 20:46
@vypbot
vypbot changed the base branch from master to develop November 3, 2026 20:46
@vypbot vypbot added the size: XXL Indicates an extremely large task or issue that requires significant time and effort to complete. label Nov 3, 2026
@vypbot

vypbot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

Bugbot: review complete

Current status: No active findings on 91aac4c.

Pull request · Verified commit · Workflow run

@vypbot

vypbot commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

Copilot approval · Human review needed

Status: A protected workflow, policy, or trust-boundary file changed.
Completed: 1/1 observed checks succeeded; Bugbot complete.
Action required: Ask a human reviewer to decide.
Impact: No new approval is confirmed for this revision.
See checks

Technical evidence

Revision: 91aac4c6b03e; base: 04ae6b2f25d6; reason: protected-path.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.40%. Comparing base (04ae6b2) to head (91aac4c).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #877   +/-   ##
========================================
  Coverage    95.40%   95.40%           
========================================
  Files         1148     1149    +1     
  Lines        37989    37992    +3     
  Branches     11309    11309           
========================================
+ Hits         36243    36246    +3     
  Misses         672      672           
  Partials      1074     1074           
Files with missing lines Coverage Δ
src/prompts/bugbot.ts 100.00% <100.00%> (ø)
src/prompts/bugbot_async_statement_evidence.ts 100.00% <100.00%> (ø)
src/tooling/bugbot_benchmark_runner.ts 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@efraespada
efraespada merged commit 7d1e8d3 into develop Nov 3, 2026
13 checks passed
@github-project-automation github-project-automation Bot moved this from In Progress to Done in vypdev Nov 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: XXL Indicates an extremely large task or issue that requires significant time and effort to complete. state:verified

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

🐛🧑‍💻 - Bugbot reports a missing Lit update await that is already present in the reviewed source

3 participants