Repository navigation
fix: ground async review in complete statements and lifecycle evidence (#848) - #877
Merged
Conversation
…present-in-the-reviewed-source: ground asynchronous findings in complete statements and lifecycle evidence
…present-in-the-reviewed-source: publish the repeatable owned Lit qualification runner and its operator instructions
|
To preview the documentation for this pull request, visit the following URL:
|
vypbot
self-requested a review
November 3, 2026 20:45
Contributor
Bugbot: review complete
|
Contributor
Copilot approval · Human review neededStatus: A protected workflow, policy, or trust-boundary file changed. Technical evidenceRevision: |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #877 +/- ##
========================================
Coverage 95.40% 95.40%
========================================
Files 1148 1149 +1
Lines 37989 37992 +3
Branches 11309 11309
========================================
+ Hits 36243 36246 +3
Misses 672 672
Partials 1074 1074
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #848.
Bugbot reported that a Lit test omitted the wait between closed and ready views, although the exact source already awaited that update on the same line. Source-bound review now reads complete statements, traces receiver/current-cycle/helper ownership and reached lifecycle writes, and omits hypotheses that their own evidence disproves. Real unfinished-update defects remain reportable.
One pure shared instruction reaches ordinary/partitioned/framed source review and the actual benchmark. Existing ports, schemas, Python candidate-verification activation, source/traffic limits, finding history and permissions remain unchanged. The companion SDD, owner/catalog and detection/quality docs are aligned. No finding-text filter, new product setting, dependency or production executor is added.
Fresh execution of the unchanged original consumer head
ecdd85b4passes the selected test (1 passed, 54 not selected) and the complete frontend (11 files / 565 tests, all four coverage metrics 100%); all 52 selected source blobs remain unchanged. The historical native frontend gate was independently inspected and its merge checkout has that exact head's tree. The original finding had already been marked resolved before this work; no consumer source or review history was changed.Eighteen deterministic SDK regressions bind twelve fixed owned controls to exact source and real Lit 3.3.3 / Chromium observations, enforce opposite-verdict scorer controls, and verify delivery/privacy/legacy/query accounting. A versioned optional runner and repeatable command reproduce all twelve observations; relative SDK, wrong package pin and existing-output guards pass. It is contributor test infrastructure and adds no mandatory browser/Lit runtime dependency.
Actual qualification evidence retains all three baseline trials, both rejected distinct source revisions, all three final trials, predictions, scores and source/runtime identities. Frozen inputs/references/anchors and thresholds never change. The baseline has 10 false positives; the final three-trial aggregate passes every unchanged floor with zero false positives, recall 17/18 and exact locations 14/17. One delayed-descendant defect is omitted and three anchors are imprecise. Final trial 1 fails its individual location floor, trial 2 fails recall and trial 3 passes. This is bounded controlled evidence, not a full historical model replay or general accuracy guarantee.
Local validation passes: 881 Jest suites / 17,184 tests (35 existing skips), all 18 new cases, 267 extension tests with every coverage metric at 100%, and exhaustive coverage of the new pure module (one executable statement, zero functions/branches). Full-suite LCOV hits 3/3 modified coverable lines with zero misses/partials against
04ae6b2f. Existing setup human acceptances remain unchanged. Types, lint, specs/catalog, docs/navigation/agent docs, workflow contracts and Graphify pass. Bundles synchronize and the 96-file npm package passes CLI, typed Bugbot API and isolated local web smoke. Both normal commits pass full build/Jest/lint hooks; measured runtime/CLI hashes remain identical.Remote acceptance passes for head
91aac4c6b03e56ae7cd7f22fbfe0bc1ef6e040d0against base04ae6b2f25d6bfdc7cf98cf121df178a4ac56746: CI, Commit, Branch Sync and Linux/macOS/Windows pass. All three native checkouts have parents[base, head], the exact head tree and one successful deferred-cleanup footer; actual Linux Firefox ESR passes 19 assertions on the matching extension input digest. The full review completes 2/2 partitions with no omissions, findings or open threads. Official Codecov confirms 3/3 modified coverable lines hit, zero misses and zero partials, at the exact base/head. Base coverage refresh 41704966530 also passes. Copilot / Approval is advisory neutral for protected paths; native develop rules require the strict CI Check and no additional review. The standing maintainer authorization applies to an ordinary exact-head merge; no native approval, check or protection is changed.