🐛🧑‍💻 - Bugbot reports a missing Lit update await that is already present in the reviewed source #848

Is there an existing issue for this?

• I have searched the existing issues. repo:vypdev/copilot is:issue "await" "Lit" returned no matches. This is separate from 🐛🧑‍💻 - Bugbot mistakes a source bound nonpersonal UI shell for an authentication bypass #847's nonpersonal-resource classification finding.

Which actions are affected?

Pull Request

Which platforms are affected?

Linux (hosted review); macOS (unchanged original Chromium reproduction).

Description

Bugbot published a medium-severity reliability finding at98% confidence claiming that a Lit test assigns closed and ready views without awaiting the closed update and therefore fails the frontend suite. The immutable reviewed source already contains precisely that await, and the original named test passes without any edit.

Consumer: vypdev/domus#15
Reviewed head: ecdd85b4b08479eede41a517f9acdfdde9393b17
Finding: vypdev/domus#15 (comment)
Path: frontend/tests/component.test.ts:177
Finding identity: frontend/tests/component.test.ts:177:closed-draft-test-batches-transitions
Fingerprint: fp-2e2596f4; semantic key: sf-f1be81de.

The finding says both assignments occur before updateComplete and recommends awaiting between them. The exact reviewed lines176–178 are:

f.element.view = view('unconfigured', {phase: 'closed', session: null, decision: null, journal: null}); await f.element.updateComplete;
f.element.view = view(); await f.element.updateComplete;
expect(f.root.querySelector<HTMLInputElement>('#name')!.value).toBe('');

The first await is a separate statement on the same line as the assignment. It is executed before the next assignment. This report does not dispute Lit's batching semantics; it disputes the claim that this code omits the await.

Expected: read the complete reviewed statement/neighboring line before asserting a missing await or publishing a patch equivalent to existing behavior. Verify a claimed deterministic suite failure against the actual test result where available.

Actual: the finding's central source premise is false, and its assertion that the suite is blocked contradicts both the hosted passing frontend gate and a fresh targeted execution of the unchanged original case.

Reproducing the issue

1. Review the exact consumer head above using the installed PR workflow.
2. Read both statements at lines176 and177. Each assignment is followed by await updateComplete.
3. Run against the unchanged original source, with the locked Node24.20.0, pnpm10.34.0, Lit3.3.3, Vitest5.0.5, Playwright1.64.1 and actual headless Chromium:

pnpm --filter @domus/frontend exec vitest run tests/component.test.ts --no-coverage -t 'closed presentation retires'

4. Actual result:1passed,54not-selected, original file55cases; duration798ms. The targeted skips are selection, not claimed complete-suite coverage. Raw original output is retained.
5. The full published frontend gate on this same head independently passes565cases and all four coverage metrics at100%. The consumer now prepares a readability-only expansion of the existing awaits onto separate lines plus assertions that the intermediate closed heading is rendered and no input is present. It does not pretend that moving the await fixes a previous runtime bug.

copilot Version

vypdev/copilot@v3, source 3e7ceea08e6131360e026937d1c0cc1b120472e0, configured reviewer/findings model gpt-6-luna, effort smart. No model, resource, prompt, policy or credential was changed.

Relevant Log Output

Review job
Frontend gate

reviewId=vypdev:domus:pr-15:ecdd85b4b084
changedFiles=94 changedLines=11333
analysisPartitions=14 completedAnalysisPartitions=14
candidateFindings=3 publishedFindings=3
findingStates:open=3 fixed=2 obsolete=1 verification-required=0 unknown=0
human-conversation:fetched11 retained5 omitted6 truncated0 limitReached=true

Additional context and comments

The other two new findings are valid and are being corrected normally: a double-invocation provider-error assertion can miss a leak on its first call, and a technical membership value remains an English identifier in Spanish. Neither justifies dismissing this report or suppressing other findings. We are retaining native history and requesting evidence-based verification of this one false positive.

The partial conversation context is already tracked in #843 and does not establish the cause here. The missing-await premise can be disproven using the immutable diff itself. Please own any upstream source-reading/evidence-quality regression. No consumer Copilot files/settings/credentials/gateway were modified, no owner data is included, and no review gate is weakened.